authoravatarclover caruso<git@paperclover.net>2026-11-22 00:12:20-08:00
committeravatarclover caruso<git@paperclover.net>2026-11-22 03:33:00-08:00
log8ef31a67af6341ab217275f11548130c36a80ba2
tree70ae99a9da44e4fcd59d40b9231f4e4b090db35e
parented2aea165bc6405e39e62f73434e710238e42fd0
signature Signed by SSH key SHA256:52mNGHRsVFBDED9IAX5pe+LRWUefqTbxEReunq21QvU

Shale webhook: list only new commits, at most twenty

A new branch serialized every commit in the repository (6011 in snowcord-server), so the push timed out with an HTTP 500. Match GitHub: only commits no other branch or tag has, capped at 20. Assisted-by: claude-sonnet-5.5

2 files changed, 22 insertions(+), 2 deletions(-)

service/shale/webhook.sh+2-2
......@@ -106,11 +106,11 @@ while read -r before after ref; do
106106 if is_zero "$before"; then
107107 created=true
108108 forced=false
109 commits=$(git rev-list --reverse "$after")
109 commits=$(git rev-list -n 20 --reverse "$after" --not --exclude="$short_ref" --branches --tags)
110110 else
111111 created=false
112112 if git merge-base --is-ancestor "$before" "$after"; then forced=false; else forced=true; fi
113 commits=$(git rev-list --reverse "$before..$after")
113 commits=$(git rev-list -n 20 --reverse "$before..$after")
114114 fi
115115 compare="$origin/commit/$after"
116116 {
tools/shale-webhook-test.py+20
......@@ -102,6 +102,26 @@ class ShaleWebhookTests(unittest.TestCase):
102102 event, _, payload = Receiver.events.pop(0)
103103 self.assertEqual((event, payload["ref_type"], payload["ref"]), ("delete", "branch", "delete-me"))
104104
105 def test_payload_lists_only_new_commits_capped_at_twenty(self):
106 work = self.repositories()
107 for i in range(24):
108 self.git("commit", "--allow-empty", "-m", f"c{i}", cwd=work)
109 env = {
110 **os.environ,
111 "DOMAIN": "shale.test",
112 "SHALE_WEBHOOK_ENABLED": "true",
113 "SHALE_WEBHOOK_URL": f"http://127.0.0.1:{self.server.server_port}/hook",
114 }
115 self.git("push", "origin", "main", cwd=work, env=env)
116 _, _, payload = Receiver.events.pop(0)
117 self.assertEqual([c["message"] for c in payload["commits"]][-1], "c23")
118 self.assertEqual(len(payload["commits"]), 20)
119
120 self.git("push", "origin", "main:topic", cwd=work, env=env)
121 _, _, payload = Receiver.events.pop(0)
122 self.assertEqual(payload["commits"], [])
123 self.assertEqual(payload["head_commit"]["id"], payload["after"])
124
105125 def test_prepare_installs_only_named_repository_hooks(self):
106126 owned = self.root / "repositories_owned"
107127 database = self.root / "data/astheno.shale.db"