| author |  Julius Marminge <julius0216@outlook.com> 2026-09-05 00:26:27-07:00 |
| committer |  GitHub <noreply@github.com> 2026-09-05 00:26:27-07:00 |
| log | 1c59d3b72cbddefa186ce18bea5cd7e6e0ae4874 |
| tree | 619d1cbfd9d090e06f037e5987f380490253b9cd |
| parent | 1e24b43d3f6eea6333a3c8da6946eb614d00a662 |
| signature | Signed by PGP key B5690EEEBB952194 |
refactor(mobile): keep review default ID helper private (#10000)
2 files changed, 1 insertions(+), 3 deletions(-)
apps
mobile
src
features
apps/mobile/src/features/review/reviewFileVisibility.test.ts-2
| ... | @@ -1,7 +1,6 @@ | ... | @@ -1,7 +1,6 @@ |
| 1 | import { describe, expect, it } from "vite-plus/test"; | 1 | import { describe, expect, it } from "vite-plus/test"; |
| 2 | 2 | ||
| 3 | import { | 3 | import { |
| 4 | getDefaultReviewExpandedFileIds, | ||
| 5 | getValidExplicitReviewFileIds, | 4 | getValidExplicitReviewFileIds, |
| 6 | getValidReviewFileIds, | 5 | getValidReviewFileIds, |
| 7 | removeReviewFileId, | 6 | removeReviewFileId, |
| ... | @@ -29,7 +28,6 @@ describe("review file visibility", () => { | ... | @@ -29,7 +28,6 @@ describe("review file visibility", () => { |
| 29 | const files = [makeFile("a.ts"), makeFile("b.ts")]; | 28 | const files = [makeFile("a.ts"), makeFile("b.ts")]; |
| 30 | 29 | ||
| 31 | it("defaults expanded files to every renderable file", () => { | 30 | it("defaults expanded files to every renderable file", () => { |
| 32 | expect(getDefaultReviewExpandedFileIds(files)).toEqual(["a.ts", "b.ts"]); | ||
| 33 | expect(getValidReviewFileIds(files, undefined)).toEqual(["a.ts", "b.ts"]); | 31 | expect(getValidReviewFileIds(files, undefined)).toEqual(["a.ts", "b.ts"]); |
| 34 | }); | 32 | }); |
| 35 | 33 |
apps/mobile/src/features/review/reviewFileVisibility.ts+1-1
| ... | @@ -3,7 +3,7 @@ import { useCallback, useMemo } from "react"; | ... | @@ -3,7 +3,7 @@ import { useCallback, useMemo } from "react"; |
| 3 | import { updateReviewExpandedFileIds, updateReviewViewedFileIds } from "./reviewState"; | 3 | import { updateReviewExpandedFileIds, updateReviewViewedFileIds } from "./reviewState"; |
| 4 | import type { ReviewRenderableFile } from "./reviewModel"; | 4 | import type { ReviewRenderableFile } from "./reviewModel"; |
| 5 | 5 | ||
| 6 | export function getDefaultReviewExpandedFileIds( | 6 | function getDefaultReviewExpandedFileIds( |
| 7 | files: ReadonlyArray<ReviewRenderableFile>, | 7 | files: ReadonlyArray<ReviewRenderableFile>, |
| 8 | ): ReadonlyArray<string> { | 8 | ): ReadonlyArray<string> { |
| 9 | return files.map((file) => file.id); | 9 | return files.map((file) => file.id); |