Commit 2a264adc6f6c65f98d4273acaa1af567eca83f2a | the-knife

author	shivam <91240327+shivamhwp@users.noreply.github.com> 2026-09-15 22:41:54+05:30
committer	GitHub <noreply@github.com> 2026-09-15 14:11:54-03:00
log	2a264adc6f6c65f98d4273acaa1af567eca83f2a
tree	1fdfe03983fbd202d1fd4537dde60e372b059e51
parent	9a6b57be2ae601e6969669a8ad276f974b2a5978
signature	Signed by PGP key B5690EEEBB952194

fix(server): explain how to configure a missing Codex executable (#11345)

2 files changed, 29 insertions(+), 13 deletions(-)

apps
- server
  - src
    provider
    Layers
    CodexProvider.ts
    ProviderRegistry.test.ts

apps/server/src/provider/Layers/CodexProvider.ts+4-1

 @@ -628,7 +628,10 @@ export const checkCodexProviderStatus = Effect.fn("checkCodexProviderStatus")(fu
         auth: { status: "unknown" },
         message: installed
           ? `Codex app-server provider probe failed: ${error.message}.`
-          : "Codex CLI (`codex`) was not found on PATH.",
+          : `Could not start Codex CLI (\`${codexSettings.binaryPath}\`). Check Settings → Providers → Codex → Binary path on the server.` +
+            (codexSettings.binaryPath === "codex"
+              ? " Installing ChatGPT or Codex desktop may not add codex to PATH."
+              : " Make sure the configured executable exists and can be run."),
       },
     });
   }

apps/server/src/provider/Layers/ProviderRegistry.test.ts+25-12

 @@ -513,20 +513,35 @@ it.layer(Layer.mergeAll(NodeServices.layer, ServerSettingsModule.layerTest(), Te
         }),
       );
-      it.effect("returns unavailable when codex is missing", () =>
+      it.effect.each([
+        "codex",
+        "/Applications/Custom App.app/Contents/Resources/codex",
+        "C:\\Tools\\codex.exe",
+      ])("explains how to configure a Codex executable that cannot start: %s", (binaryPath) =>
         Effect.gen(function* () {
-          const status = yield* checkCodexProviderStatus(defaultCodexSettings, () =>
+          const settings = { ...defaultCodexSettings, binaryPath };
-            Effect.fail(
+          const status = yield* checkCodexProviderStatus(settings, (input) => {
+            assert.strictEqual(input.binaryPath, binaryPath);
+            return Effect.fail(
               new CodexErrors.CodexAppServerSpawnError({
-                command: "codex app-server",
+                command: `${binaryPath} app-server`,
-                cause: new Error("spawn codex ENOENT"),
+                cause: new Error("spawn ENOENT"),
               }),
-            ),
+            );
-          );
+          });
           assert.strictEqual(status.status, "error");
           assert.strictEqual(status.installed, false);
           assert.strictEqual(status.auth.status, "unknown");
-          assert.strictEqual(status.message, "Codex CLI (`codex`) was not found on PATH.");
+          assert.include(status.message, binaryPath);
+          assert.include(
+            status.message,
+            "Settings → Providers → Codex → Binary path on the server",
+          );
+          assert.strictEqual(
+            status.message?.includes("Installing ChatGPT or Codex desktop"),
+            binaryPath === "codex",
+          );
+          assert.strictEqual(settings.binaryPath, binaryPath);
         }),
       );
 @@ -2331,10 +2346,8 @@ it.layer(Layer.mergeAll(NodeServices.layer, ServerSettingsModule.layerTest(), Te
               "Real Codex probe against a missing binary should surface as 'error' in the aggregator",
             );
             assert.strictEqual(codexPersonal?.installed, false);
-            assert.strictEqual(
+            assert.include(codexPersonal?.message, missingBinary);
-              codexPersonal?.message,
+            assert.include(codexPersonal?.message, "Settings → Providers → Codex → Binary path");
-              "Codex CLI (`codex`) was not found on PATH.",
-            );
           }).pipe(Effect.provide(runtimeServices));
         }),
       );