From 2ab188f1c0afe99ba269739704e2e96f0bbbe78f Mon Sep 17 00:00:00 2001 From: "t3-code[bot]" <269035359+t3-code[bot]@users.noreply.github.com> Date: Thu, 13 Aug 2026 14:51:31 +0000 Subject: [PATCH] fix: ignore pull request actions in latency tracker (#6476) Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> --- apps/web/src/rpc/requestLatencyState.test.ts | 10 ++++++++++ apps/web/src/rpc/requestLatencyState.ts | 6 +++++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/apps/web/src/rpc/requestLatencyState.test.ts b/apps/web/src/rpc/requestLatencyState.test.ts index e5b3144d2520f0249b3e6cd9f573b6c35739521f..68433035fd1894559028ad002466be8e8be51680 100644 --- a/apps/web/src/rpc/requestLatencyState.test.ts +++ b/apps/web/src/rpc/requestLatencyState.test.ts @@ -59,6 +59,16 @@ describe("requestLatencyState", () => { expect(getSlowRpcAckRequests()).toEqual([]); }); + it.each(Object.values(WS_METHODS).filter((method) => method.startsWith("pullRequests.")))( + "ignores pull request workspace request %s", + (method) => { + trackRpcRequestSent("1", method); + vi.advanceTimersByTime(SLOW_RPC_ACK_THRESHOLD_MS * 2); + + expect(getSlowRpcAckRequests()).toEqual([]); + }, + ); + it("keeps ignoring untracked methods when a display tag is supplied", () => { trackRpcRequestSent( "1", diff --git a/apps/web/src/rpc/requestLatencyState.ts b/apps/web/src/rpc/requestLatencyState.ts index 4736d3783c3b60113ea6113886e4f8bd3b2ffa60..4ec5b56f9e2bbd23cfc8c646cf2c5a3a937aa08c 100644 --- a/apps/web/src/rpc/requestLatencyState.ts +++ b/apps/web/src/rpc/requestLatencyState.ts @@ -49,7 +49,11 @@ function getSlowRpcAckRequestsValue(): ReadonlyArray { } function shouldTrackRpcAck(method: string): boolean { - return !method.includes("subscribe") && !untrackedRpcAckMethods.has(method); + return ( + !method.includes("subscribe") && + !method.startsWith("pullRequests.") && + !untrackedRpcAckMethods.has(method) + ); } function rpcAckThresholdMs(method: string): number { -- 2.54.0