Commit 38e0bb07bb24894524f1502ac0487c5ea4ff85de | the-knife

author	Jake Leventhal <jakeleventhal@me.com> 2026-07-18 07:17:30-04:00
committer	GitHub <noreply@github.com> 2026-07-18 13:17:30+02:00
log	38e0bb07bb24894524f1502ac0487c5ea4ff85de
tree	2ebd44463832745f9fb133fadf816b9bc1e01463
parent	765e1b5fc044b899741a11dcba141bb2c49c6c37
signature	Signed by PGP key B5690EEEBB952194

Default diffs to working changes (#3974)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

4 files changed, 47 insertions(+), 9 deletions(-)

apps
- web
  - src
    components
    ChatView.tsx
    DiffPanel.tsx
    diffPanelStore.test.ts
    diffPanelStore.ts

apps/web/src/components/ChatView.tsx+12-3

 @@ -2252,12 +2252,13 @@ function ChatViewContent(props: ChatViewProps) {
         worktreePath: activeThread?.worktreePath ?? null,
       })
     : null;
+  const gitStatusCwd = activeThread?.worktreePath ?? gitCwd;
   const gitStatusQuery = useEnvironmentQuery(
-    gitCwd === null
+    gitStatusCwd === null
       ? null
       : vcsEnvironment.status({
           environmentId,
-          input: { cwd: gitCwd },
+          input: { cwd: gitStatusCwd },
         }),
   );
   const keybindings = useAtomValue(primaryServerKeybindingsAtom);
 @@ -2291,6 +2292,9 @@ function ChatViewContent(props: ChatViewProps) {
     terminalUiLaunchContext?.threadId === activeThreadId ? terminalUiLaunchContext : null;
   // Default true while loading to avoid toolbar flicker.
   const isGitRepo = gitStatusQuery.data?.isRepo ?? true;
+  const initialDiffPanelGitScope =
+    gitStatusQuery.data?.hasWorkingTreeChanges === true ? "unstaged" : "branch";
+  const diffPanelGitStatusResolutionKey = gitStatusQuery.data ? "resolved" : "pending";
   const terminalShortcutLabelOptions = useMemo(
     () => ({
       context: {
 @@ -5136,7 +5140,12 @@ function ChatViewContent(props: ChatViewProps) {
       />
     ) : activeRightPanelSurface?.kind === "diff" ? (
       <Suspense fallback={null}>
-        <DiffPanel mode="embedded" composerDraftTarget={composerDraftTarget} />
+        <DiffPanel
+          key={`${activeThreadKey}:${diffPanelGitStatusResolutionKey}`}
+          mode="embedded"
+          composerDraftTarget={composerDraftTarget}
+          initialGitScope={initialDiffPanelGitScope}
+        />
       </Suspense>
     ) : activeRightPanelSurface?.kind === "plan" ? (
       <PlanSidebar

apps/web/src/components/DiffPanel.tsx+14-4

 @@ -178,13 +178,19 @@ const DIFF_PANEL_UNSAFE_CSS = `
 interface DiffPanelProps {
   mode?: DiffPanelMode;
   composerDraftTarget: ScopedThreadRef | DraftId;
+  initialGitScope: "branch" | "unstaged";
 }
 export { DiffWorkerPoolProvider } from "./DiffWorkerPoolProvider";
-export default function DiffPanel({ mode = "inline", composerDraftTarget }: DiffPanelProps) {
+export default function DiffPanel({
+  mode = "inline",
+  composerDraftTarget,
+  initialGitScope: initialGitScopeProp,
+}: DiffPanelProps) {
   const { resolvedTheme } = useTheme();
   const settings = useClientSettings();
+  const [initialGitScope] = useState(initialGitScopeProp);
   const [diffRenderMode, setDiffRenderMode] = useState<DiffRenderMode>("stacked");
   const [wordWrap, setWordWrap] = useState(settings.wordWrap);
   const [diffIgnoreWhitespace, setDiffIgnoreWhitespace] = useState(settings.diffIgnoreWhitespace);
 @@ -199,9 +205,6 @@ export default function DiffPanel({ mode = "inline", composerDraftTarget }: Diff
     strict: false,
     select: (params) => resolveThreadRouteRef(params),
   });
-  const diffSelection = useDiffPanelStore((state) =>
-    selectThreadDiffPanelSelection(state.byThreadKey, routeThreadRef),
-  );
   const activeThreadId = routeThreadRef?.threadId ?? null;
   const activeThread = useThread(routeThreadRef);
   const activeProjectId = activeThread?.projectId ?? null;
 @@ -229,6 +232,13 @@ export default function DiffPanel({ mode = "inline", composerDraftTarget }: Diff
         })
       : null,
   );
+  const diffSelection = useDiffPanelStore((state) =>
+    selectThreadDiffPanelSelection(
+      state.byThreadKey,
+      routeThreadRef,
+      initialGitScope === "unstaged",
+    ),
+  );
   const isGitRepo = gitStatusQuery.data?.isRepo ?? true;
   const { turnDiffSummaries, inferredCheckpointTurnCountByTurnId } =
     useTurnDiffSummaries(activeThread);

apps/web/src/diffPanelStore.test.ts+15-1

...	@@ -9,12 +9,26 @@ const THREAD_REF = scopeThreadRef(EnvironmentId.make("environment-1"), ThreadId.	...	@@ -9,12 +9,26 @@ const THREAD_REF = scopeThreadRef(EnvironmentId.make("environment-1"), ThreadId.
9	describe("diffPanelStore", () => {	9	describe("diffPanelStore", () => {
10	beforeEach(() => useDiffPanelStore.setState({ byThreadKey: {}, branchBaseRefByThreadKey: {} }));	10	beforeEach(() => useDiffPanelStore.setState({ byThreadKey: {}, branchBaseRefByThreadKey: {} }));
11		11
12	it("defaults each thread to branch changes with automatic base selection", () => {	12	it("defaults each thread to branch changes when the working tree is clean", () => {
13	expect(	13	expect(
14	selectThreadDiffPanelSelection(useDiffPanelStore.getState().byThreadKey, THREAD_REF),	14	selectThreadDiffPanelSelection(useDiffPanelStore.getState().byThreadKey, THREAD_REF),
15	).toEqual({ kind: "branch", baseRef: null });	15	).toEqual({ kind: "branch", baseRef: null });
16	});	16	});
17		17
		18	it("defaults each thread to working changes when the working tree is dirty", () => {
		19	expect(
		20	selectThreadDiffPanelSelection(useDiffPanelStore.getState().byThreadKey, THREAD_REF, true),
		21	).toEqual({ kind: "unstaged" });
		22	});
		23
		24	it("preserves an explicit scope selection when the working tree state changes", () => {
		25	useDiffPanelStore.getState().selectGitScope(THREAD_REF, "branch");
		26
		27	expect(
		28	selectThreadDiffPanelSelection(useDiffPanelStore.getState().byThreadKey, THREAD_REF, true),
		29	).toEqual({ kind: "branch", baseRef: null });
		30	});
		31
18	it("clears incompatible selection fields when changing scopes", () => {	32	it("clears incompatible selection fields when changing scopes", () => {
19	const store = useDiffPanelStore.getState();	33	const store = useDiffPanelStore.getState();
20	store.selectTurn(THREAD_REF, TurnId.make("turn-1"), "src/app.ts");	34	store.selectTurn(THREAD_REF, TurnId.make("turn-1"), "src/app.ts");

apps/web/src/diffPanelStore.ts+6-1

 @@ -11,6 +11,7 @@ export type DiffPanelSelection =
   | { kind: "turn"; turnId: TurnId; filePath: string | null; revealRequestId: number };
 const DEFAULT_SELECTION: DiffPanelSelection = { kind: "branch", baseRef: null };
+const DEFAULT_WORKING_TREE_SELECTION: DiffPanelSelection = { kind: "unstaged" };
 interface DiffPanelStoreState {
   byThreadKey: Record<string, DiffPanelSelection>;
 @@ -133,7 +134,11 @@ export const useDiffPanelStore = create<DiffPanelStoreState>()(
 export function selectThreadDiffPanelSelection(
   byThreadKey: Record<string, DiffPanelSelection>,
   ref: ScopedThreadRef | null | undefined,
+  hasWorkingTreeChanges = false,
 ): DiffPanelSelection {
   if (!ref) return DEFAULT_SELECTION;
-  return byThreadKey[scopedThreadKey(ref)] ?? DEFAULT_SELECTION;
+  return (
+    byThreadKey[scopedThreadKey(ref)] ??
+    (hasWorkingTreeChanges ? DEFAULT_WORKING_TREE_SELECTION : DEFAULT_SELECTION)
+  );
 }