From 45387700bf49401fd9de4f2db36575e50f9649eb Mon Sep 17 00:00:00 2001 From: maria Date: Sun, 6 Sep 2026 20:24:28 -0300 Subject: [PATCH] fix(web): keep settings section headings description-free (#10415) --- .../src/components/settings/LoadBalancingSettings.tsx | 7 ++----- .../src/components/settings/ProviderInstanceCard.tsx | 10 ++++------ .../src/components/settings/UsageProviderSettings.tsx | 1 - apps/web/src/components/settings/settingsLayout.tsx | 11 ++++------- 4 files changed, 10 insertions(+), 19 deletions(-) diff --git a/apps/web/src/components/settings/LoadBalancingSettings.tsx b/apps/web/src/components/settings/LoadBalancingSettings.tsx index 514b146c3bac80b06b1d22326aa4adef47fab983..b4657b71387e8946a51f7547751976693cbc38b0 100644 --- a/apps/web/src/components/settings/LoadBalancingSettings.tsx +++ b/apps/web/src/components/settings/LoadBalancingSettings.tsx @@ -28,13 +28,10 @@ export function LoadBalancingSettings({ const updateSettings = useUpdateClientSettings(); return ( - + - + {editorStatusNode} + } control={
setAdding(true)}> diff --git a/apps/web/src/components/settings/settingsLayout.tsx b/apps/web/src/components/settings/settingsLayout.tsx index 1bfa8c87146e218dbbd7b34e1707c8222861fb8a..24660734075133c13dabbe3673325493f10f7068 100644 --- a/apps/web/src/components/settings/settingsLayout.tsx +++ b/apps/web/src/components/settings/settingsLayout.tsx @@ -155,9 +155,9 @@ export function useRelativeTimeTick(intervalMs = 1_000) { return nowMs; } +/** Muted section headings have no descriptions; explanatory copy belongs to individual settings. */ export function SettingsSection({ title, - description, hideTitle = false, icon, headerAction, @@ -167,7 +167,6 @@ export function SettingsSection({ ...sectionProps }: ComponentPropsWithoutRef<"section"> & { title: string; - description?: ReactNode; hideTitle?: boolean; icon?: ReactNode; headerAction?: ReactNode; @@ -195,11 +194,6 @@ export function SettingsSection({ {icon} {title} - {description ? ( -
- {description} -
- ) : null}
{headerAction}
@@ -225,6 +219,9 @@ export function SettingsSection({ * the control goes inert with a tooltip instead of showing an editable * default that would never save. * + * Keep descriptions short enough for one line where possible. Allow wrapping + * for clarity or narrow screens instead of truncating or forcing no-wrap. + * * Control sizing across settings follows three tiers so rows share a baseline: * - `control` slot: `size="sm"` (Button, Select, Input, NumberField) or `icon-sm`. * - Section `headerAction`s and buttons inside list items, cards, toolbars: `xs` / `icon-xs`. -- 2.54.0