From 47117a7d85b6696e3ad3ae7d59303b3a60e9eea5 Mon Sep 17 00:00:00 2001 From: Julius Marminge Date: Mon, 9 Mar 2026 10:56:56 -0700 Subject: [PATCH] Inline SidebarInset base classes and remove dead sidebar logic - Replace `SIDEBAR_INSET_BASE_CLASSNAME` with an inline class string in `sidebar.tsx` - Delete the now-unused `sidebar.logic.ts` helper and its focused unit test --- apps/web/src/components/ui/sidebar.logic.ts | 2 -- apps/web/src/components/ui/sidebar.test.tsx | 9 --------- apps/web/src/components/ui/sidebar.tsx | 3 +-- 3 files changed, 1 insertion(+), 13 deletions(-) delete mode 100644 apps/web/src/components/ui/sidebar.logic.ts delete mode 100644 apps/web/src/components/ui/sidebar.test.tsx diff --git a/apps/web/src/components/ui/sidebar.logic.ts b/apps/web/src/components/ui/sidebar.logic.ts deleted file mode 100644 index c9e4b4c1d8cfba537f101c00f3fe7886f8037197..0000000000000000000000000000000000000000 --- a/apps/web/src/components/ui/sidebar.logic.ts +++ /dev/null @@ -1,2 +0,0 @@ -export const SIDEBAR_INSET_BASE_CLASSNAME = - "relative flex min-w-0 w-full flex-1 flex-col bg-background"; diff --git a/apps/web/src/components/ui/sidebar.test.tsx b/apps/web/src/components/ui/sidebar.test.tsx deleted file mode 100644 index 99bf2d0179f7b979e11043ee4624eac589a2c4b2..0000000000000000000000000000000000000000 --- a/apps/web/src/components/ui/sidebar.test.tsx +++ /dev/null @@ -1,9 +0,0 @@ -import { describe, expect, it } from "vitest"; - -import { SIDEBAR_INSET_BASE_CLASSNAME } from "./sidebar.logic"; - -describe("SidebarInset", () => { - it("stays shrinkable inside flex layouts", () => { - expect(SIDEBAR_INSET_BASE_CLASSNAME).toContain("min-w-0"); - }); -}); diff --git a/apps/web/src/components/ui/sidebar.tsx b/apps/web/src/components/ui/sidebar.tsx index ef79926ef226790d18923b8dc481a246ea1878bf..16b9ec4ed377c1d54298740c94108afa1d5caf17 100644 --- a/apps/web/src/components/ui/sidebar.tsx +++ b/apps/web/src/components/ui/sidebar.tsx @@ -18,7 +18,6 @@ import { import { Skeleton } from "~/components/ui/skeleton"; import { Tooltip, TooltipPopup, TooltipTrigger } from "~/components/ui/tooltip"; import { useMediaQuery } from "~/hooks/useMediaQuery"; -import { SIDEBAR_INSET_BASE_CLASSNAME } from "./sidebar.logic"; const SIDEBAR_COOKIE_NAME = "sidebar_state"; const SIDEBAR_COOKIE_MAX_AGE = 60 * 60 * 24 * 7; @@ -596,7 +595,7 @@ function SidebarInset({ className, ...props }: React.ComponentProps<"main">) { return (