Commit 4d790f0064ab99287d3ccb17d2f003f5ed8e8d3e | the-knife

author	Julius Marminge <julius0216@outlook.com> 2026-06-20 11:13:27-07:00
committer	GitHub <noreply@github.com> 2026-06-20 11:13:27-07:00
log	4d790f0064ab99287d3ccb17d2f003f5ed8e8d3e
tree	b7d82104a0a9dcc6ca65f903636b9ab682e42e84
parent	3ecf3685ba7dbaca04f6a1219a8d42e6094dc526
signature	Signed by PGP key B5690EEEBB952194

[codex] Bound relay registration replay diagnostics (#3420)

Co-authored-by: codex <codex@users.noreply.github.com>

2 files changed, 20 insertions(+), 6 deletions(-)

infra
- relay
  - src
    agentActivity
    MobileRegistrations.test.ts
    MobileRegistrations.ts

infra/relay/src/agentActivity/MobileRegistrations.test.ts+12-2

 @@ -7,6 +7,7 @@ import * as NodeCryptoLayer from "@effect/platform-node/NodeCrypto";
 import { describe, expect, it } from "@effect/vitest";
 import * as Effect from "effect/Effect";
 import * as Layer from "effect/Layer";
+import * as Logger from "effect/Logger";
 import * as Redacted from "effect/Redacted";
 import { FetchHttpClient } from "effect/unstable/http";
 @@ -232,6 +233,11 @@ describe("MobileRegistrations", () => {
   });
   it.effect("keeps device registration successful when activity replay fails", () => {
+    const messages: unknown[] = [];
+    const logger = Logger.make(({ message }) => {
+      messages.push(message);
+    });
     return Effect.gen(function* () {
       const result = yield* Effect.gen(function* () {
         const registrations = yield* MobileRegistrations.MobileRegistrations;
 @@ -250,7 +256,7 @@ describe("MobileRegistrations", () => {
                       Effect.fail(
                         new AgentActivityRows.AgentActivityRowListPersistenceError({
                           userId: "dev:julius",
-                          cause: "replay failed",
+                          cause: "sensitive device replay detail",
                         }),
                       ),
                   }),
 @@ -262,7 +268,11 @@ describe("MobileRegistrations", () => {
       );
       expect(result).toEqual({ ok: true });
-    });
+      expect(messages).toContainEqual([
+        "device registration activity replay failed",
+        { errorTag: "AgentActivityRowListPersistenceError" },
+      ]);
+    }).pipe(Effect.provide(Logger.layer([logger], { mergeWithExisting: false })));
   });
   it.effect("unregisters the current user's device", () => {

infra/relay/src/agentActivity/MobileRegistrations.ts+8-4

 @@ -51,8 +51,10 @@ export const make = Effect.gen(function* () {
           deviceId: input.payload.deviceId,
         })
         .pipe(
-          Effect.tapError((cause) =>
+          Effect.tapError((error) =>
-            Effect.logWarning("device registration activity replay failed", { cause }),
+            Effect.logWarning("device registration activity replay failed", {
+              errorTag: error._tag,
+            }),
           ),
           Effect.ignore,
         );
 @@ -70,8 +72,10 @@ export const make = Effect.gen(function* () {
             deviceId: input.payload.deviceId,
           })
           .pipe(
-            Effect.tapError((cause) =>
+            Effect.tapError((error) =>
-              Effect.logWarning("live activity registration replay failed", { cause }),
+              Effect.logWarning("live activity registration replay failed", {
+                errorTag: error._tag,
+              }),
             ),
             Effect.ignore,
           );