Commit 80498f1709e05caa744716b740fdcaa884bef8e0 | the-knife

author	Julius Marminge <julius0216@outlook.com> 2026-02-27 17:55:47-08:00
committer	Julius Marminge <jmarminge@gmail.com> 2026-02-27 18:08:18-08:00
log	80498f1709e05caa744716b740fdcaa884bef8e0
tree	02989fd14c96f6f59b45bee0bc4c2c095f1ac611
parent	e6c5a4a4bb962c8276887c26e889fe97a8668f44

Handle terminal exit writes and auto-close exited terminal view

- Ignore late write calls after a terminal session has already exited
- Add regression test for trailing writes after exit
- Close terminal drawer session once an exit event is handled

3 files changed, 36 insertions(+), 0 deletions(-)

apps
- server
  - src
    terminal
    Layers
    Manager.test.ts
    Manager.ts
- web
  - src
    components
    ThreadTerminalDrawer.tsx

apps/server/src/terminal/Layers/Manager.test.ts+15

...	...	@@ -394,6 +394,21 @@ describe("TerminalManager", () => {
394	394	manager.dispose();
395	395	});
396	396
	397	it("ignores trailing writes after terminal exit", async () => {
	398	const { manager, ptyAdapter } = makeManager();
	399	await manager.open(openInput());
	400	const process = ptyAdapter.processes[0];
	401	expect(process).toBeDefined();
	402	if (!process) return;
	403
	404	process.emitExit({ exitCode: 0, signal: 0 });
	405
	406	await expect(manager.write({ threadId: "thread-1", data: "\r" })).resolves.toBeUndefined();
	407	expect(process.writes).toEqual([]);
	408
	409	manager.dispose();
	410	});
	411
397	412	it("emits subprocess activity events when child-process state changes", async () => {
398	413	let hasRunningSubprocess = false;
399	414	const { manager } = makeManager(5, {

apps/server/src/terminal/Layers/Manager.ts+3

...	...	@@ -438,6 +438,9 @@ export class TerminalManagerRuntime extends EventEmitter<TerminalManagerEvents>
438	438	const input = decodeTerminalWriteInput(raw);
439	439	const session = this.requireSession(input.threadId, input.terminalId);
440	440	if (!session.process \|\| session.status !== "running") {
	441	if (session.status === "exited") {
	442	return;
	443	}
441	444	throw new Error(
442	445	`Terminal is not running for thread: ${input.threadId}, terminal: ${input.terminalId}`,
443	446	);

apps/web/src/components/ThreadTerminalDrawer.tsx+18

...	...	@@ -112,6 +112,7 @@ interface TerminalViewportProps {
112	112	terminalId: string;
113	113	cwd: string;
114	114	runtimeEnv?: Record<string, string>;
	115	onSessionExited: () => void;
115	116	focusRequestId: number;
116	117	autoFocus: boolean;
117	118	resizeEpoch: number;
...	...	@@ -123,6 +124,7 @@ function TerminalViewport({
123	124	terminalId,
124	125	cwd,
125	126	runtimeEnv,
	127	onSessionExited,
126	128	focusRequestId,
127	129	autoFocus,
128	130	resizeEpoch,
...	...	@@ -131,6 +133,12 @@ function TerminalViewport({
131	133	const containerRef = useRef<HTMLDivElement>(null);
132	134	const terminalRef = useRef<Terminal \| null>(null);
133	135	const fitAddonRef = useRef<FitAddon \| null>(null);
	136	const onSessionExitedRef = useRef(onSessionExited);
	137	const hasHandledExitRef = useRef(false);
	138
	139	useEffect(() => {
	140	onSessionExitedRef.current = onSessionExited;
	141	}, [onSessionExited]);
134	142
135	143	useEffect(() => {
136	144	const mount = containerRef.current;
...	...	@@ -306,6 +314,7 @@ function TerminalViewport({
306	314	}
307	315
308	316	if (event.type === "started" \|\| event.type === "restarted") {
	317	hasHandledExitRef.current = false;
309	318	activeTerminal.write("\u001bc");
310	319	if (event.snapshot.history.length > 0) {
311	320	activeTerminal.write(event.snapshot.history);
...	...	@@ -335,6 +344,13 @@ function TerminalViewport({
335	344	activeTerminal,
336	345	details.length > 0 ? `Process exited (${details})` : "Process exited",
337	346	);
	347	if (hasHandledExitRef.current) {
	348	return;
	349	}
	350	hasHandledExitRef.current = true;
	351	window.setTimeout(() => {
	352	onSessionExitedRef.current();
	353	}, 0);
338	354	}
339	355	});
340	356
...	...	@@ -783,6 +799,7 @@ export default function ThreadTerminalDrawer({
783	799	terminalId={terminalId}
784	800	cwd={cwd}
785	801	{...(runtimeEnv ? { runtimeEnv } : {})}
	802	onSessionExited={() => onCloseTerminal(terminalId)}
786	803	focusRequestId={focusRequestId}
787	804	autoFocus={terminalId === resolvedActiveTerminalId}
788	805	resizeEpoch={resizeEpoch}
...	...	@@ -800,6 +817,7 @@ export default function ThreadTerminalDrawer({
800	817	terminalId={resolvedActiveTerminalId}
801	818	cwd={cwd}
802	819	{...(runtimeEnv ? { runtimeEnv } : {})}
	820	onSessionExited={() => onCloseTerminal(resolvedActiveTerminalId)}
803	821	focusRequestId={focusRequestId}
804	822	autoFocus
805	823	resizeEpoch={resizeEpoch}