Commit 9c4095aaaa31c5628d40026cbddf094c0f85146d | the-knife

author	Julius Marminge <julius0216@outlook.com> 2026-02-26 19:23:26-08:00
committer	Julius Marminge <jmarminge@gmail.com> 2026-02-26 19:27:08-08:00
log	9c4095aaaa31c5628d40026cbddf094c0f85146d
tree	fb5dcc2d84b2da9f247308cbdc804ecbe954aedb
parent	961df8597c4c8149febbc95d0ab52f895ca7ff94

Fix Effect type warnings to pass typecheck

- Use generic type parameter for stream errors instead of unknown
- Type ServerShape errors as ServerLifecycleError instead of unknown
- Add error mapping for autoBootstrapProject and httpServerListen
- Type makeServerProviderLayer with ProviderUnsupportedError
- Use Effect.try with decodeUnknownSync in projector to avoid unknown requirements
- Fix test layer types from any/unknown to never

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

6 files changed, 41 insertions(+), 29 deletions(-)

apps
- server
  - src
    git
    Layers
    CodexTextGeneration.ts
    GitService.ts
    orchestration
    projector.ts
    serverLayers.ts
    wsServer.test.ts
    wsServer.ts

apps/server/src/git/Layers/CodexTextGeneration.ts+2-2

...	@@ -129,9 +129,9 @@ const makeCodexTextGeneration = Effect.gen(function* () {	...	@@ -129,9 +129,9 @@ const makeCodexTextGeneration = Effect.gen(function* () {
129	const path = yield* Path.Path;	129	const path = yield* Path.Path;
130	const commandSpawner = yield* ChildProcessSpawner.ChildProcessSpawner;	130	const commandSpawner = yield* ChildProcessSpawner.ChildProcessSpawner;
131		131
132	const readStreamAsString = (	132	const readStreamAsString = <E>(
133	operation: string,	133	operation: string,
134	stream: Stream.Stream<Uint8Array, unknown>,	134	stream: Stream.Stream<Uint8Array, E>,
135	): Effect.Effect<string, TextGenerationError> =>	135	): Effect.Effect<string, TextGenerationError> =>
136	Effect.gen(function* () {	136	Effect.gen(function* () {
137	let text = "";	137	let text = "";

apps/server/src/git/Layers/GitService.ts+2-2

...	@@ -39,9 +39,9 @@ function toGitCommandError(	...	@@ -39,9 +39,9 @@ function toGitCommandError(
39	});	39	});
40	}	40	}
41		41
42	const collectOutput = Effect.fn(function* (	42	const collectOutput = Effect.fn(function* <E>(
43	input: Pick<ExecuteGitInput, "operation" \| "cwd" \| "args">,	43	input: Pick<ExecuteGitInput, "operation" \| "cwd" \| "args">,
44	stream: Stream.Stream<Uint8Array, unknown>,	44	stream: Stream.Stream<Uint8Array, E>,
45	maxOutputBytes: number,	45	maxOutputBytes: number,
46	): Effect.fn.Return<string, GitCommandError> {	46	): Effect.fn.Return<string, GitCommandError> {
47	const decoder = new TextDecoder();	47	const decoder = new TextDecoder();

apps/server/src/orchestration/projector.ts+6-3

 @@ -40,9 +40,12 @@ function decodeForEvent<A>(
   eventType: OrchestrationEvent["type"],
   field: string,
 ): Effect.Effect<A, OrchestrationProjectorDecodeError> {
-  return Schema.decodeUnknownEffect(schema)(value).pipe(
+  return Effect.try({
-    Effect.mapError(toProjectorDecodeError(`${eventType}:${field}`)),
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  ) as Effect.Effect<A, OrchestrationProjectorDecodeError>;
+    try: () => Schema.decodeUnknownSync(schema as any)(value) as A,
+    catch: (error) =>
+      toProjectorDecodeError(`${eventType}:${field}`)(error as Schema.SchemaError),
+  });
 }
 function retainThreadMessagesAfterRevert(

apps/server/src/serverLayers.ts+2-1

...	@@ -17,6 +17,7 @@ import { ProviderCommandReactorLive } from "./orchestration/Layers/ProviderComma	...	@@ -17,6 +17,7 @@ import { ProviderCommandReactorLive } from "./orchestration/Layers/ProviderComma
17	import { OrchestrationProjectionPipelineLive } from "./orchestration/Layers/ProjectionPipeline";	17	import { OrchestrationProjectionPipelineLive } from "./orchestration/Layers/ProjectionPipeline";
18	import { OrchestrationProjectionSnapshotQueryLive } from "./orchestration/Layers/ProjectionSnapshotQuery";	18	import { OrchestrationProjectionSnapshotQueryLive } from "./orchestration/Layers/ProjectionSnapshotQuery";
19	import { ProviderRuntimeIngestionLive } from "./orchestration/Layers/ProviderRuntimeIngestion";	19	import { ProviderRuntimeIngestionLive } from "./orchestration/Layers/ProviderRuntimeIngestion";
		20	import { ProviderUnsupportedError } from "./provider/Errors";
20	import { makeCodexAdapterLive } from "./provider/Layers/CodexAdapter";	21	import { makeCodexAdapterLive } from "./provider/Layers/CodexAdapter";
21	import { ProviderAdapterRegistryLive } from "./provider/Layers/ProviderAdapterRegistry";	22	import { ProviderAdapterRegistryLive } from "./provider/Layers/ProviderAdapterRegistry";
22	import { makeProviderServiceLive } from "./provider/Layers/ProviderService";	23	import { makeProviderServiceLive } from "./provider/Layers/ProviderService";
...	@@ -35,7 +36,7 @@ import { NodePtyAdapterLive } from "./terminal/Layers/NodePTY";	...	@@ -35,7 +36,7 @@ import { NodePtyAdapterLive } from "./terminal/Layers/NodePTY";
35		36
36	export function makeServerProviderLayer(): Layer.Layer<	37	export function makeServerProviderLayer(): Layer.Layer<
37	ProviderService,	38	ProviderService,
38	unknown,	39	ProviderUnsupportedError,
39	SqlClient.SqlClient \| ServerConfig	40	SqlClient.SqlClient \| ServerConfig
40	> {	41	> {
41	return Effect.gen(function* () {	42	return Effect.gen(function* () {

apps/server/src/wsServer.test.ts+2-2

...	@@ -323,14 +323,14 @@ describe("WebSocket Server", () => {	...	@@ -323,14 +323,14 @@ describe("WebSocket Server", () => {
323		323
324	async function createTestServer(	324	async function createTestServer(
325	options: {	325	options: {
326	persistenceLayer?: Layer.Layer<SqlClient.SqlClient, any>;	326	persistenceLayer?: Layer.Layer<SqlClient.SqlClient, never>;
327	cwd?: string;	327	cwd?: string;
328	autoBootstrapProjectFromCwd?: boolean;	328	autoBootstrapProjectFromCwd?: boolean;
329	logWebSocketEvents?: boolean;	329	logWebSocketEvents?: boolean;
330	devUrl?: string;	330	devUrl?: string;
331	authToken?: string;	331	authToken?: string;
332	stateDir?: string;	332	stateDir?: string;
333	providerLayer?: Layer.Layer<ProviderService, unknown>;	333	providerLayer?: Layer.Layer<ProviderService, never>;
334	open?: OpenShape;	334	open?: OpenShape;
335	gitManager?: GitManagerShape;	335	gitManager?: GitManagerShape;
336	gitCore?: Pick<GitCoreShape, "listBranches" \| "initRepo" \| "pullCurrentBranch">;	336	gitCore?: Pick<GitCoreShape, "listBranches" \| "initRepo" \| "pullCurrentBranch">;

apps/server/src/wsServer.ts+27-19

 @@ -66,14 +66,14 @@ export interface ServerShape {
    */
   readonly start: Effect.Effect<
     http.Server,
-    unknown,
+    ServerLifecycleError,
     Scope.Scope | ServerRuntimeServices | ServerConfig
   >;
   /**
    * Wait for process shutdown signals.
    */
-  readonly stopSignal: Effect.Effect<unknown, never>;
+  readonly stopSignal: Effect.Effect<void, never>;
 }
 /**
 @@ -165,7 +165,7 @@ class RouteRequestError extends Schema.TaggedErrorClass<RouteRequestError>()("Ro
 export const createServer = Effect.fn(function* (): Effect.fn.Return<
   http.Server,
-  unknown, // TODO: This should not be unknown
+  ServerLifecycleError,
   Scope.Scope | ServerRuntimeServices | ServerConfig
 > {
   const serverConfig = yield* ServerConfig;
 @@ -338,21 +338,27 @@ export const createServer = Effect.fn(function* (): Effect.fn.Return<
   yield* Scope.provide(orchestrationReactor.start, subscriptionsScope);
   if (autoBootstrapProjectFromCwd) {
-    const snapshot = yield* projectionReadModelQuery.getSnapshot();
+    yield* Effect.gen(function* () {
-    const existing = snapshot.projects.find((project) => project.workspaceRoot === cwd);
+      const snapshot = yield* projectionReadModelQuery.getSnapshot();
-    if (!existing) {
+      const existing = snapshot.projects.find((project) => project.workspaceRoot === cwd);
-      const createdAt = new Date().toISOString();
+      if (!existing) {
-      const projectName = path.basename(cwd) || "project";
+        const createdAt = new Date().toISOString();
-      yield* orchestrationEngine.dispatch({
+        const projectName = path.basename(cwd) || "project";
-        type: "project.create",
+        yield* orchestrationEngine.dispatch({
-        commandId: CommandId.makeUnsafe(crypto.randomUUID()),
+          type: "project.create",
-        projectId: ProjectId.makeUnsafe(crypto.randomUUID()),
+          commandId: CommandId.makeUnsafe(crypto.randomUUID()),
-        title: projectName,
+          projectId: ProjectId.makeUnsafe(crypto.randomUUID()),
-        workspaceRoot: cwd,
+          title: projectName,
-        defaultModel: "gpt-5-codex",
+          workspaceRoot: cwd,
-        createdAt,
+          defaultModel: "gpt-5-codex",
-      });
+          createdAt,
-    }
+        });
+      }
+    }).pipe(
+      Effect.mapError(
+        (cause) => new ServerLifecycleError({ operation: "autoBootstrapProject", cause }),
+      ),
+    );
   }
   const routeRequest = Effect.fnUntraced(function* (request: WebSocketRequest) {
 @@ -618,7 +624,9 @@ export const createServer = Effect.fn(function* (): Effect.fn.Return<
   );
   yield* Effect.addFinalizer(() => Effect.sync(() => unsubscribeTerminalEvents()));
-  yield* NodeHttpServer.make(() => httpServer, listenOptions);
+  yield* NodeHttpServer.make(() => httpServer, listenOptions).pipe(
+    Effect.mapError((cause) => new ServerLifecycleError({ operation: "httpServerListen", cause })),
+  );
   yield* Effect.addFinalizer(() =>
     Effect.all([