From b297e20f4e6e9a89d8f160e021b0b0f91248ca4f Mon Sep 17 00:00:00 2001
From: Julius Marminge <julius0216@outlook.com>
Date: Thu, 5 Mar 2026 16:01:38 -0800
Subject: [PATCH] Fix release target commit and gate version bump steps

- Set `target_commitish` from preflight ref when creating GitHub releases
- Track whether package versions changed and expose it via step output
- Run format, lockfile refresh, and bump commit only when changes exist
---
 .github/workflows/release.yml | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 45e6b989a72a8fecded33dcb54cbb64dea872d5b..2ac0bf32d661f9d46b8131691177d379c13fc334 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -257,6 +257,7 @@ jobs:
         uses: softprops/action-gh-release@v2
         with:
           tag_name: ${{ needs.preflight.outputs.tag }}
+          target_commitish: ${{ needs.preflight.outputs.ref }}
           name: T3 Code v${{ needs.preflight.outputs.version }}
           generate_release_notes: true
           make_latest: true
@@ -290,12 +291,13 @@ jobs:
         with:
           node-version-file: package.json
 
-      - name: Update version strings
+      - id: update_versions
+        name: Update version strings
         env:
           RELEASE_VERSION: ${{ needs.preflight.outputs.version }}
         run: |
           node --input-type=module -e '
-            import { readFileSync, writeFileSync } from "node:fs";
+            import { appendFileSync, readFileSync, writeFileSync } from "node:fs";
 
             const files = [
               "apps/server/package.json",
@@ -317,15 +319,20 @@ jobs:
             if (!changed) {
               console.log("All package.json versions already match release version.");
             }
+
+            appendFileSync(process.env.GITHUB_OUTPUT, `changed=${changed}\n`);
           '
 
       - name: Format package.json files
+        if: steps.update_versions.outputs.changed == 'true'
         run: bunx oxfmt apps/server/package.json apps/desktop/package.json apps/web/package.json packages/contracts/package.json
 
       - name: Refresh lockfile
+        if: steps.update_versions.outputs.changed == 'true'
         run: bun install
 
       - name: Commit and push version bump
+        if: steps.update_versions.outputs.changed == 'true'
         shell: bash
         env:
           RELEASE_TAG: ${{ needs.preflight.outputs.tag }}
-- 
2.54.0