From c18e5ea6ed741443a8ec4a5d22d4b6939b0ecd21 Mon Sep 17 00:00:00 2001
From: shivam <91240327+shivamhwp@users.noreply.github.com>
Date: Wed, 30 Sep 2026 12:35:22 +0530
Subject: [PATCH] fix(web): stop clipping the bottoms of diff file names
 (#14375)

---
 .../src/components/diffs/StyledDiffCodeView.tsx   | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/apps/web/src/components/diffs/StyledDiffCodeView.tsx b/apps/web/src/components/diffs/StyledDiffCodeView.tsx
index 64bc88aab2fdff0ffd593ebd2634d5df15a75c36..cdd9fe272225332e5282d08555919cbd41dfc91d 100644
--- a/apps/web/src/components/diffs/StyledDiffCodeView.tsx
+++ b/apps/web/src/components/diffs/StyledDiffCodeView.tsx
@@ -200,6 +200,13 @@ const DIFF_VIEW_UNSAFE_CSS = `${DIFF_SURFACE_THEME_UNSAFE_CSS}
   line-height: 1 !important;
 }
 
+/* Pierre clips file names with overflow: hidden for its start ellipsis. A 1em line box cuts off
+   descenders. Only the clipped names get room: 16px plus the header's 12px of padding stays
+   inside its 32px min-height, which diffHeaderHeight assumes. */
+[data-diffs-header] :is([data-title], [data-prev-name]) {
+  line-height: 16px !important;
+}
+
 [data-diffs-header] [data-metadata] {
   align-items: center !important;
   line-height: 1 !important;
@@ -222,18 +229,12 @@ const DIFF_VIEW_UNSAFE_CSS = `${DIFF_SURFACE_THEME_UNSAFE_CSS}
 
 [data-title] {
   cursor: pointer;
-  transition:
-    color 120ms ease,
-    text-decoration-color 120ms ease;
-  text-decoration: underline;
-  text-decoration-color: transparent;
-  text-underline-offset: 2px;
+  transition: color 120ms ease;
   font-family: var(--font-sans) !important;
 }
 
 [data-title]:hover {
   color: color-mix(in srgb, var(--code-foreground) 84%, var(--primary)) !important;
-  text-decoration-color: currentColor;
 }
 
 /* Expanding a file mounts its body all at once; easing it in matches the 200ms the app's
-- 
2.54.0