authorgravatar for julius0216@outlook.comJulius Marminge <julius0216@outlook.com> 2026-02-15 13:53:17-08:00
committergravatar for jmarminge@gmail.comJulius Marminge <jmarminge@gmail.com> 2026-02-15 15:51:05-08:00
log20d3ad5d50ba9afb0df99bad1f71dddc762d2032
treee1b2f74b7544e144fa38ab86fe6f14d218de4e3f
parent54fa15c72ed8e3dc8356f458c47462ee6c2f5745

Use Vitest assert API in keybindings tests

- Replace `expect` assertions with `assert` in server and contracts keybinding tests - Keep existing coverage while standardizing assertion style

2 files changed, 21 insertions(+), 19 deletions(-)

apps/server/src/keybindings.test.ts+8-8
...@@ -1,10 +1,10 @@...@@ -1,10 +1,10 @@
1import { describe, expect, it } from "vitest";1import { assert, describe, it } from "vitest";
22
3import { compileResolvedKeybindingRule, parseKeybindingShortcut } from "./keybindings";3import { compileResolvedKeybindingRule, parseKeybindingShortcut } from "./keybindings";
44
5describe("server keybindings", () => {5describe("server keybindings", () => {
6 it("parses shortcuts including plus key", () => {6 it("parses shortcuts including plus key", () => {
7 expect(parseKeybindingShortcut("mod+j")).toEqual({7 assert.deepEqual(parseKeybindingShortcut("mod+j"), {
8 key: "j",8 key: "j",
9 metaKey: false,9 metaKey: false,
10 ctrlKey: false,10 ctrlKey: false,
...@@ -12,7 +12,7 @@ describe("server keybindings", () => {...@@ -12,7 +12,7 @@ describe("server keybindings", () => {
12 altKey: false,12 altKey: false,
13 modKey: true,13 modKey: true,
14 });14 });
15 expect(parseKeybindingShortcut("mod++")).toEqual({15 assert.deepEqual(parseKeybindingShortcut("mod++"), {
16 key: "+",16 key: "+",
17 metaKey: false,17 metaKey: false,
18 ctrlKey: false,18 ctrlKey: false,
...@@ -29,7 +29,7 @@ describe("server keybindings", () => {...@@ -29,7 +29,7 @@ describe("server keybindings", () => {
29 when: "terminalOpen && !terminalFocus",29 when: "terminalOpen && !terminalFocus",
30 });30 });
3131
32 expect(compiled).toEqual({32 assert.deepEqual(compiled, {
33 key: "mod+d",33 key: "mod+d",
34 command: "terminal.split",34 command: "terminal.split",
35 when: "terminalOpen && !terminalFocus",35 when: "terminalOpen && !terminalFocus",
...@@ -53,19 +53,19 @@ describe("server keybindings", () => {...@@ -53,19 +53,19 @@ describe("server keybindings", () => {
53 });53 });
5454
55 it("rejects invalid rules", () => {55 it("rejects invalid rules", () => {
56 expect(56 assert.isNull(
57 compileResolvedKeybindingRule({57 compileResolvedKeybindingRule({
58 key: "mod+shift+d+o",58 key: "mod+shift+d+o",
59 command: "terminal.new",59 command: "terminal.new",
60 }),60 }),
61 ).toBeNull();61 );
6262
63 expect(63 assert.isNull(
64 compileResolvedKeybindingRule({64 compileResolvedKeybindingRule({
65 key: "mod+d",65 key: "mod+d",
66 command: "terminal.split",66 command: "terminal.split",
67 when: "terminalFocus && (",67 when: "terminalFocus && (",
68 }),68 }),
69 ).toBeNull();69 );
70 });70 });
71});71});
packages/contracts/src/keybindings.test.ts+13-11
...@@ -1,4 +1,4 @@...@@ -1,4 +1,4 @@
1import { describe, expect, it } from "vitest";1import { assert, describe, it } from "vitest";
22
3import {3import {
4 keybindingRuleSchema,4 keybindingRuleSchema,
...@@ -13,16 +13,18 @@ describe("keybindings contracts", () => {...@@ -13,16 +13,18 @@ describe("keybindings contracts", () => {
13 key: "mod+j",13 key: "mod+j",
14 command: "terminal.toggle",14 command: "terminal.toggle",
15 });15 });
16 expect(parsed.command).toBe("terminal.toggle");16 assert.strictEqual(parsed.command, "terminal.toggle");
17 });17 });
1818
19 it("rejects invalid command values", () => {19 it("rejects invalid command values", () => {
20 expect(() =>20 assert.throws(() =>
21 keybindingRuleSchema.parse({21 keybindingRuleSchema.parse(
22 key: "mod+j",22 {
23 command: "invalid.command" as unknown as "terminal.toggle",23 key: "mod+j",
24 }),24 command: "invalid.command" as unknown as "terminal.toggle",
25 ).toThrow();25 },
26 ),
27 );
26 });28 });
2729
28 it("parses keybindings array payload", () => {30 it("parses keybindings array payload", () => {
...@@ -30,7 +32,7 @@ describe("keybindings contracts", () => {...@@ -30,7 +32,7 @@ describe("keybindings contracts", () => {
30 { key: "mod+j", command: "terminal.toggle" },32 { key: "mod+j", command: "terminal.toggle" },
31 { key: "mod+d", command: "terminal.split", when: "terminalFocus" },33 { key: "mod+d", command: "terminal.split", when: "terminalFocus" },
32 ]);34 ]);
33 expect(parsed).toHaveLength(2);35 assert.lengthOf(parsed, 2);
34 });36 });
3537
36 it("parses resolved keybinding rules", () => {38 it("parses resolved keybinding rules", () => {
...@@ -55,7 +57,7 @@ describe("keybindings contracts", () => {...@@ -55,7 +57,7 @@ describe("keybindings contracts", () => {
55 },57 },
56 },58 },
57 });59 });
58 expect(parsed.shortcut.key).toBe("d");60 assert.strictEqual(parsed.shortcut.key, "d");
59 });61 });
6062
61 it("parses resolved keybindings arrays", () => {63 it("parses resolved keybindings arrays", () => {
...@@ -73,6 +75,6 @@ describe("keybindings contracts", () => {...@@ -73,6 +75,6 @@ describe("keybindings contracts", () => {
73 },75 },
74 },76 },
75 ]);77 ]);
76 expect(parsed).toHaveLength(1);78 assert.lengthOf(parsed, 1);
77 });79 });
78});80});