Commit 2120fbc185737b71f09de020b95224f9e636d1e5 | the-knife

author	Rakshith Bhat <88523594+RakshithBhat03@users.noreply.github.com> 2026-09-03 22:06:09+05:30
committer	GitHub <noreply@github.com> 2026-09-03 09:36:09-07:00
log	2120fbc185737b71f09de020b95224f9e636d1e5
tree	609354464b4b4efb80086457503af75e077d6d95
parent	cfddb4201df8941bbfde008919da70fe5ec7552b
signature	Signed by PGP key B5690EEEBB952194

fix(web): avoid duplicate Antigravity install status (#9419)

2 files changed, 51 insertions(+), 15 deletions(-)

apps
- web
  - src
    components
    settings
    ProviderSetupSection.test.tsx
    ProviderSetupSection.tsx

apps/web/src/components/settings/ProviderSetupSection.test.tsx+35-1

...	@@ -1,4 +1,4 @@	...	@@ -1,4 +1,4 @@
1	import type { FunctionComponent, ReactElement } from "react";	1	import { isValidElement, type FunctionComponent, type ReactElement } from "react";
2	import {	2	import {
3	EnvironmentId,	3	EnvironmentId,
4	ProviderDriverKind,	4	ProviderDriverKind,
...	@@ -142,6 +142,23 @@ function button(view: unknown, label: string) {	...	@@ -142,6 +142,23 @@ function button(view: unknown, label: string) {
142	);	142	);
143	}	143	}
144		144
		145	function countElements(
		146	node: unknown,
		147	predicate: (element: ReactElement<Record<string, unknown>>) => boolean,
		148	): number {
		149	if (Array.isArray(node)) {
		150	return node.reduce((total, child) => total + countElements(child, predicate), 0);
		151	}
		152	if (!isValidElement<Record<string, unknown>>(node)) return 0;
		153	return (
		154	Number(predicate(node)) +
		155	Object.values(node.props).reduce<number>(
		156	(total, value) => total + countElements(value, predicate),
		157	0,
		158	)
		159	);
		160	}
		161
145	function click(view: unknown, label: string) {	162	function click(view: unknown, label: string) {
146	const target = button(view, label);	163	const target = button(view, label);
147	if (!target) throw new Error(`Missing button: ${label}`);	164	if (!target) throw new Error(`Missing button: ${label}`);
...	@@ -285,6 +302,23 @@ describe("Antigravity setup", () => {	...	@@ -285,6 +302,23 @@ describe("Antigravity setup", () => {
285	await flushPromises();	302	await flushPromises();
286	});	303	});
287		304
		305	it("shows a repeated runtime status message only once", () => {
		306	setup.installation = {
		307	...setup.installation!,
		308	operationId: "install-1",
		309	phase: "verifying",
		310	message: "Checking the downloaded runtime.",
		311	};
		312
		313	const view = renderSetup();
		314	expect(
		315	countElements(
		316	view,
		317	(element) => element.props.children === "Checking the downloaded runtime.",
		318	),
		319	).toBe(1);
		320	});
		321
288	it("removes an owned damaged runtime only after confirmation", async () => {	322	it("removes an owned damaged runtime only after confirmation", async () => {
289	setup.auth = authState({ phase: "idle", flowId: null, authorizationUrl: null });	323	setup.auth = authState({ phase: "idle", flowId: null, authorizationUrl: null });
290	setup.installation = {	324	setup.installation = {

apps/web/src/components/settings/ProviderSetupSection.tsx+16-14

 @@ -169,6 +169,20 @@ function ProviderSetupActions({
   const authorizationUrl = auth?.phase === "waiting" ? auth.authorizationUrl : null;
   const queryError = authQuery.error ?? installQuery.error;
   const actionsDisabled = pendingLabel !== null || queryError !== null;
+  const installationStatusMessage =
+    installation?.phase === "downloading"
+      ? `Downloading ${(installation.downloadedBytes / 1_000_000).toFixed(1)} MB${installation.totalBytes === null ? "" : ` of ${(installation.totalBytes / 1_000_000).toFixed(1)} MB`}.`
+      : installation?.phase === "extracting"
+        ? "Extracting Antigravity."
+        : installation?.phase === "verifying"
+          ? "Checking the downloaded runtime."
+          : installed
+            ? "Antigravity is installed."
+            : usesCustomBinary
+              ? enabled
+                ? "The configured Antigravity runtime is unavailable."
+                : "The configured Antigravity runtime has not been checked."
+              : "Install the official Antigravity runtime before signing in.";
   async function runCommand<A, E>(
     label: string,
 @@ -252,19 +266,7 @@ function ProviderSetupActions({
       <div className="grid gap-2">
         <p className="font-medium">Runtime</p>
         <p role="status" className="text-muted-foreground">
-          {installation?.phase === "downloading"
+          {installationStatusMessage}
-            ? `Downloading ${(installation.downloadedBytes / 1_000_000).toFixed(1)} MB${installation.totalBytes === null ? "" : ` of ${(installation.totalBytes / 1_000_000).toFixed(1)} MB`}.`
-            : installation?.phase === "extracting"
-              ? "Extracting Antigravity."
-              : installation?.phase === "verifying"
-                ? "Checking the downloaded runtime."
-                : installed
-                  ? "Antigravity is installed."
-                  : usesCustomBinary
-                    ? enabled
-                      ? "The configured Antigravity runtime is unavailable."
-                      : "The configured Antigravity runtime has not been checked."
-                    : "Install the official Antigravity runtime before signing in."}
         </p>
         {installation?.phase === "downloading" &&
         installation.totalBytes !== null &&
 @@ -276,7 +278,7 @@ function ProviderSetupActions({
             max={installation.totalBytes}
           />
         ) : null}
-        {installation?.message ? (
+        {installation?.message && installation.message !== installationStatusMessage ? (
           <p className="text-muted-foreground [overflow-wrap:anywhere]">{installation.message}</p>
         ) : null}
         {usesCustomBinary ? (