authorgravatar for julius0216@outlook.comJulius Marminge <julius0216@outlook.com> 2026-09-05 00:18:14-07:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2026-09-05 00:18:14-07:00
log371e32392570fdc0d2309e9f92490bbd2c6b3f02
treea7ed64e6227a9e31033225b95bbfbebf966967b4
parentf87ecf0cc307f974745da8eea856fab5711023f3
signature Signed by PGP key B5690EEEBB952194

test(server): remove authorization prompt snapshots (#9985)


4 files changed, 3 insertions(+), 35 deletions(-)

apps/server/src/cli/connect.test.ts-19
......@@ -13,31 +13,12 @@ import * as Terminal from "effect/Terminal";
1313import * as BootService from "../cloud/bootService.ts";
1414import {
1515 acquireRelayClientForLink,
16 formatHeadlessAuthorizationPrompt,
17 formatRelayClientReady,
1816 headlessSessionConfig,
1917 isPublishAgentActivityEnabledValue,
2018 reportCloudDisconnectResults,
2119} from "./connect.ts";
2220import { recoverServiceOnboardingOffer } from "./service.ts";
2321
24it("explains how to complete headless authorization", () => {
25 assert.equal(
26 formatHeadlessAuthorizationPrompt("https://example.test/connect"),
27 [
28 "Headless authorization",
29 "Open this URL on a device with a browser:",
30 " https://example.test/connect",
31 "",
32 "After signing in, return here and enter the code shown in your browser.",
33 ].join("\n"),
34 );
35});
36
37it("formats relay readiness without printing its installation path", () => {
38 assert.equal(formatRelayClientReady("2026.5.2"), "✓ Relay client ready · cloudflared 2026.5.2");
39});
40
4122const readHeadlessSessionConfig = (env: Record<string, string>) =>
4223 headlessSessionConfig.pipe(Effect.provide(ConfigProvider.layer(ConfigProvider.fromEnv({ env }))));
4324
apps/server/src/cli/connect.ts+2-2
......@@ -86,7 +86,7 @@ const promptForOutOfBandOAuthCode = Effect.fn("cloud.cli.prompt_for_out_of_band_
8686 },
8787);
8888
89export function formatHeadlessAuthorizationPrompt(authorizeUrl: string): string {
89function formatHeadlessAuthorizationPrompt(authorizeUrl: string): string {
9090 return [
9191 "Headless authorization",
9292 "Open this URL on a device with a browser:",
......@@ -464,7 +464,7 @@ const runCloudCommand = Effect.fn("cloud.cli.run_cloud_command")(function* <A, E
464464
465465const connectedAs = (identity: string | null): string => (identity ? ` as ${identity}` : "");
466466
467export function formatRelayClientReady(version: string): string {
467function formatRelayClientReady(version: string): string {
468468 return `✓ Relay client ready · cloudflared ${version}`;
469469}
470470
apps/server/src/cloud/CliTokenManager.test.ts-13
......@@ -93,19 +93,6 @@ class PromptRejectedError extends Schema.TaggedErrorClass<PromptRejectedError>()
9393 { message: Schema.String },
9494) {}
9595
96it("formats loopback authorization with a headless-host fallback", () => {
97 assert.equal(
98 CliTokenManager.formatLoopbackAuthorizationPrompt("https://clerk.example.test/authorize"),
99 [
100 "Open this URL to authorize T3 Connect:",
101 " https://clerk.example.test/authorize",
102 "",
103 "Press \u001b[1mEnter\u001b[22m to open it in your browser.",
104 "No browser on this device? Press \u001b[1mH\u001b[22m to switch to headless mode.",
105 ].join("\n"),
106 );
107});
108
10996const makeTestTerminal = (queue: Queue.Queue<Terminal.UserInput>) =>
11097 Terminal.make({
11198 columns: Effect.succeed(80),
apps/server/src/cloud/CliTokenManager.ts+1-1
......@@ -44,7 +44,7 @@ const CLOUD_CLI_OAUTH_CALLBACK_TIMEOUT = Duration.minutes(10);
4444const CLOUD_CLI_OAUTH_REFRESH_EARLY_MS = Duration.toMillis(Duration.minutes(5));
4545const boldTerminalText = (value: string): string => `\u001b[1m${value}\u001b[22m`;
4646
47export function formatLoopbackAuthorizationPrompt(authorizationUrl: string): string {
47function formatLoopbackAuthorizationPrompt(authorizationUrl: string): string {
4848 return [
4949 "Open this URL to authorize T3 Connect:",
5050 ` ${authorizationUrl}`,