Commit 447236d51f4d6835482f6707d627dbc8a39eb553 | the-knife

author	cursor[bot] <206951365+cursor[bot]@users.noreply.github.com> 2026-05-11 10:07:50+00:00
committer	GitHub <noreply@github.com> 2026-05-11 10:07:50+00:00
log	447236d51f4d6835482f6707d627dbc8a39eb553
tree	dbc06768f653be34829b8590f21ae70c1fe7a1ea
parent	5165b8c333c0da8566a93f98011672ebd1dff9bb
signature	Signed by PGP key B5690EEEBB952194

Stabilize project grouping settings selector (#2629)

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>

5 files changed, 24 insertions(+), 22 deletions(-)

apps
- web
  - src
    components
    ChatView.tsx
    Sidebar.tsx
    hooks
    useHandleNewThread.ts
    logicalProject.ts
    routes
    __root.tsx

apps/web/src/components/ChatView.tsx+5-5

 @@ -119,7 +119,10 @@ import { getProviderModelCapabilities, resolveSelectableProvider } from "../prov
 import { useSettings } from "../hooks/useSettings";
 import { resolveAppModelSelectionForInstance } from "../modelSelection";
 import { isTerminalFocused } from "../lib/terminalFocus";
-import { deriveLogicalProjectKeyFromSettings } from "../logicalProject";
+import {
+  deriveLogicalProjectKeyFromSettings,
+  selectProjectGroupingSettings,
+} from "../logicalProject";
 import {
   reconnectSavedEnvironment,
   useSavedEnvironmentRegistryStore,
 @@ -942,10 +945,7 @@ export default function ChatView(props: ChatViewProps) {
     },
     [],
   );
-  const projectGroupingSettings = useSettings((settings) => ({
+  const projectGroupingSettings = useSettings(selectProjectGroupingSettings);
-    sidebarProjectGroupingMode: settings.sidebarProjectGroupingMode,
-    sidebarProjectGroupingOverrides: settings.sidebarProjectGroupingOverrides,
-  }));
   const logicalProjectEnvironments = useMemo(() => {
     if (!activeProject) return [];
     const logicalKey = deriveLogicalProjectKeyFromSettings(activeProject, projectGroupingSettings);

apps/web/src/components/Sidebar.tsx+3-8

 @@ -183,6 +183,7 @@ import {
   derivePhysicalProjectKey,
   deriveProjectGroupingOverrideKey,
   getProjectOrderKey,
+  selectProjectGroupingSettings,
 } from "../logicalProject";
 import {
   useSavedEnvironmentRegistryStore,
 @@ -940,10 +941,7 @@ const SidebarProjectItem = memo(function SidebarProjectItem(props: SidebarProjec
   const defaultThreadEnvMode = useSettings<ThreadEnvMode>(
     (settings) => settings.defaultThreadEnvMode,
   );
-  const projectGroupingSettings = useSettings((settings) => ({
+  const projectGroupingSettings = useSettings(selectProjectGroupingSettings);
-    sidebarProjectGroupingMode: settings.sidebarProjectGroupingMode,
-    sidebarProjectGroupingOverrides: settings.sidebarProjectGroupingOverrides,
-  }));
   const { updateSettings } = useUpdateSettings();
   const sidebarThreadPreviewCount = useSettings<SidebarThreadPreviewCount>(
     (settings) => settings.sidebarThreadPreviewCount,
 @@ -2800,10 +2798,7 @@ export default function Sidebar() {
   const sidebarThreadSortOrder = useSettings((s) => s.sidebarThreadSortOrder);
   const sidebarProjectSortOrder = useSettings((s) => s.sidebarProjectSortOrder);
   const sidebarProjectGroupingMode = useSettings((s) => s.sidebarProjectGroupingMode);
-  const projectGroupingSettings = useSettings((settings) => ({
+  const projectGroupingSettings = useSettings(selectProjectGroupingSettings);
-    sidebarProjectGroupingMode: settings.sidebarProjectGroupingMode,
-    sidebarProjectGroupingOverrides: settings.sidebarProjectGroupingOverrides,
-  }));
   const sidebarThreadPreviewCount = useSettings((s) => s.sidebarThreadPreviewCount);
   const { updateSettings } = useUpdateSettings();
   const { handleNewThread } = useNewThreadHandler();

apps/web/src/hooks/useHandleNewThread.ts+6-5

 @@ -10,7 +10,11 @@ import {
 } from "../composerDraftStore";
 import { newDraftId, newThreadId } from "../lib/utils";
 import { orderItemsByPreferredIds } from "../components/Sidebar.logic";
-import { deriveLogicalProjectKeyFromSettings, getProjectOrderKey } from "../logicalProject";
+import {
+  deriveLogicalProjectKeyFromSettings,
+  getProjectOrderKey,
+  selectProjectGroupingSettings,
+} from "../logicalProject";
 import { selectProjectsAcrossEnvironments, useStore } from "../store";
 import { createThreadSelectorByRef } from "../storeSelectors";
 import { resolveThreadRouteTarget } from "../threadRoutes";
 @@ -19,10 +23,7 @@ import { useSettings } from "./useSettings";
 function useNewThreadState() {
   const projects = useStore(useShallow((store) => selectProjectsAcrossEnvironments(store)));
-  const projectGroupingSettings = useSettings((settings) => ({
+  const projectGroupingSettings = useSettings(selectProjectGroupingSettings);
-    sidebarProjectGroupingMode: settings.sidebarProjectGroupingMode,
-    sidebarProjectGroupingOverrides: settings.sidebarProjectGroupingOverrides,
-  }));
   const router = useRouter();
   const getCurrentRouteTarget = useCallback(() => {
     const currentRouteParams = router.state.matches[router.state.matches.length - 1]?.params ?? {};

apps/web/src/logicalProject.ts+8

 @@ -1,5 +1,6 @@
 import { scopedProjectKey, scopeProjectRef } from "@t3tools/client-runtime";
 import type { ScopedProjectRef, SidebarProjectGroupingMode } from "@t3tools/contracts";
+import type { UnifiedSettings } from "@t3tools/contracts/settings";
 import { normalizeProjectPathForComparison } from "./lib/projectPaths";
 import type { Project } from "./types";
 @@ -10,6 +11,13 @@ export interface ProjectGroupingSettings {
 export type ProjectGroupingMode = SidebarProjectGroupingMode;
+export function selectProjectGroupingSettings(settings: UnifiedSettings): ProjectGroupingSettings {
+  return {
+    sidebarProjectGroupingMode: settings.sidebarProjectGroupingMode,
+    sidebarProjectGroupingOverrides: settings.sidebarProjectGroupingOverrides,
+  };
+}
 function uniqueNonEmptyValues(values: ReadonlyArray<string | null | undefined>): string[] {
   const seen = new Set<string>();
   const unique: string[] = [];

apps/web/src/routes/__root.tsx+2-4

...	@@ -33,6 +33,7 @@ import { useSettings } from "../hooks/useSettings";	...	@@ -33,6 +33,7 @@ import { useSettings } from "../hooks/useSettings";
33	import {	33	import {
34	deriveLogicalProjectKeyFromSettings,	34	deriveLogicalProjectKeyFromSettings,
35	derivePhysicalProjectKeyFromPath,	35	derivePhysicalProjectKeyFromPath,
		36	selectProjectGroupingSettings,
36	} from "../logicalProject";	37	} from "../logicalProject";
37	import {	38	import {
38	getServerConfigUpdatedNotification,	39	getServerConfigUpdatedNotification,
...	@@ -281,10 +282,7 @@ function EventRouter() {	...	@@ -281,10 +282,7 @@ function EventRouter() {
281	const setActiveEnvironmentId = useStore((store) => store.setActiveEnvironmentId);	282	const setActiveEnvironmentId = useStore((store) => store.setActiveEnvironmentId);
282	const navigate = useNavigate();	283	const navigate = useNavigate();
283	const pathname = useLocation({ select: (loc) => loc.pathname });	284	const pathname = useLocation({ select: (loc) => loc.pathname });
284	const projectGroupingSettings = useSettings((settings) => ({	285	const projectGroupingSettings = useSettings(selectProjectGroupingSettings);
285	sidebarProjectGroupingMode: settings.sidebarProjectGroupingMode,
286	sidebarProjectGroupingOverrides: settings.sidebarProjectGroupingOverrides,
287	}));
288	const readPathname = useEffectEvent(() => pathname);	286	const readPathname = useEffectEvent(() => pathname);
289	const handledBootstrapThreadIdRef = useRef<string \| null>(null);	287	const handledBootstrapThreadIdRef = useRef<string \| null>(null);
290	const seenServerConfigUpdateIdRef = useRef(getServerConfigUpdatedNotification()?.id ?? 0);	288	const seenServerConfigUpdateIdRef = useRef(getServerConfigUpdatedNotification()?.id ?? 0);