| author |  Julius Marminge <julius0216@outlook.com> 2026-03-01 18:49:54-08:00 |
| committer |  Julius Marminge <jmarminge@gmail.com> 2026-03-01 22:36:35-08:00 |
| log | 508872e04b87dc7cb53632988115b54b15f78e06 |
| tree | a04d878a974cb1e9b99118576ce9a55f93606a13 |
| parent | aced302b638608042c8a1d30b6fc91dc5661657a |
Preserve explicit DEFAULT_MODEL draft overrides
Co-authored-by: codex <codex@users.noreply.github.com>2 files changed, 21 insertions(+), 6 deletions(-)
apps/web/src/composerDraftStore.test.ts+20
| ... | @@ -242,3 +242,23 @@ describe("composerDraftStore project draft thread mapping", () => { | ... | @@ -242,3 +242,23 @@ describe("composerDraftStore project draft thread mapping", () => { |
| 242 | }); | 242 | }); |
| 243 | }); | 243 | }); |
| 244 | }); | 244 | }); |
| 245 | |||
| 246 | describe("composerDraftStore setModel", () => { | ||
| 247 | const threadId = ThreadId.makeUnsafe("thread-model"); | ||
| 248 | |||
| 249 | beforeEach(() => { | ||
| 250 | useComposerDraftStore.setState({ | ||
| 251 | draftsByThreadId: {}, | ||
| 252 | draftThreadsByThreadId: {}, | ||
| 253 | projectDraftThreadIdByProjectId: {}, | ||
| 254 | }); | ||
| 255 | }); | ||
| 256 | |||
| 257 | it("keeps explicit DEFAULT_MODEL overrides instead of coercing to null", () => { | ||
| 258 | const store = useComposerDraftStore.getState(); | ||
| 259 | |||
| 260 | store.setModel(threadId, "gpt-5.3-codex"); | ||
| 261 | |||
| 262 | expect(useComposerDraftStore.getState().draftsByThreadId[threadId]?.model).toBe("gpt-5.3-codex"); | ||
| 263 | }); | ||
| 264 | }); |
apps/web/src/composerDraftStore.ts+1-6
| ... | @@ -1,5 +1,4 @@ | ... | @@ -1,5 +1,4 @@ |
| 1 | import { | 1 | import { |
| 2 | DEFAULT_MODEL, | ||
| 3 | DEFAULT_REASONING, | 2 | DEFAULT_REASONING, |
| 4 | ProjectId, | 3 | ProjectId, |
| 5 | REASONING_OPTIONS, | 4 | REASONING_OPTIONS, |
| ... | @@ -671,11 +670,7 @@ export const useComposerDraftStore = create<ComposerDraftStoreState>()( | ... | @@ -671,11 +670,7 @@ export const useComposerDraftStore = create<ComposerDraftStoreState>()( |
| 671 | if (threadId.length === 0) { | 670 | if (threadId.length === 0) { |
| 672 | return; | 671 | return; |
| 673 | } | 672 | } |
| 674 | const normalizedModelCandidate = normalizeModelSlug(model); | 673 | const normalizedModel = normalizeModelSlug(model) ?? null; |
| 675 | const normalizedModel = | ||
| 676 | normalizedModelCandidate && normalizedModelCandidate !== DEFAULT_MODEL | ||
| 677 | ? normalizedModelCandidate | ||
| 678 | : null; | ||
| 679 | set((state) => { | 674 | set((state) => { |
| 680 | const existing = state.draftsByThreadId[threadId]; | 675 | const existing = state.draftsByThreadId[threadId]; |
| 681 | if (!existing && normalizedModel === null) { | 676 | if (!existing && normalizedModel === null) { |