Commit 5e828bf3de1c86d85afdd91a02cc4ca1a38d4aef | the-knife

author	Julius Marminge <julius0216@outlook.com> 2026-09-05 01:25:11-07:00
committer	GitHub <noreply@github.com> 2026-09-05 01:25:11-07:00
log	5e828bf3de1c86d85afdd91a02cc4ca1a38d4aef
tree	a6c888f5c944d7e3c1a3001b4d3bc0436b2a2fb5
parent	a21c0d724684fe3e1775014fa0dad14e483c8315
signature	Signed by PGP key B5690EEEBB952194

refactor(mobile): keep appearance calculations private (#10043)

2 files changed, 10 insertions(+), 17 deletions(-)

apps
- mobile
  - src
    lib
    appearancePreferences.test.ts
    appearancePreferences.ts

apps/mobile/src/lib/appearancePreferences.test.ts+6-13

...	...	@@ -2,11 +2,7 @@ import { describe, expect, it } from "vite-plus/test";
2	2
3	3	import {
4	4	DEFAULT_BASE_FONT_SIZE,
5		deriveCodeFontSize,
6		deriveTerminalFontSize,
7	5	normalizeBaseFontSize,
8		normalizeCodeFontSize,
9		normalizeCodeWordBreak,
10	6	resolveAppearance,
11	7	resolveAppearancePreferences,
12	8	resolveMarkdownFontSizes,
...	...	@@ -48,10 +44,8 @@ describe("appearancePreferences", () => {
48	44	expect(appearance.isCodeFontSizeCustom).toBe(false);
49	45
50	46	const scaled = resolveAppearance(resolveAppearancePreferences({ baseFontSize: 22 }));
51		expect(scaled.terminalFontSize).toBe(deriveTerminalFontSize(22));
52		expect(scaled.codeFontSize).toBe(deriveCodeFontSize(22));
53		expect(scaled.terminalFontSize).toBeGreaterThan(10);
54		expect(scaled.codeFontSize).toBeGreaterThan(11);
	47	expect(scaled.terminalFontSize).toBe(14);
	48	expect(scaled.codeFontSize).toBe(17);
55	49	});
56	50
57	51	it("applies explicit overrides over derived values", () => {
...	...	@@ -67,8 +61,8 @@ describe("appearancePreferences", () => {
67	61	it("clamps base and code font sizes", () => {
68	62	expect(normalizeBaseFontSize(4)).toBe(11);
69	63	expect(normalizeBaseFontSize(30)).toBe(22);
70		expect(normalizeCodeFontSize(4)).toBe(8);
71		expect(normalizeCodeFontSize(30)).toBe(18);
	64	expect(resolveAppearancePreferences({ codeFontSize: 4 }).codeFontSize).toBe(8);
	65	expect(resolveAppearancePreferences({ codeFontSize: 30 }).codeFontSize).toBe(18);
72	66	});
73	67
74	68	it("steps terminal font size within bounds", () => {
...	...	@@ -92,9 +86,8 @@ describe("appearancePreferences", () => {
92	86	});
93	87	});
94	88
95		it("defaults code word break to false", () => {
96		expect(normalizeCodeWordBreak(undefined)).toBe(false);
97		expect(normalizeCodeWordBreak(true)).toBe(true);
	89	it("keeps explicit code word break enabled", () => {
	90	expect(resolveAppearancePreferences({ codeWordBreak: true }).codeWordBreak).toBe(true);
98	91	});
99	92
100	93	it("returns the authored text scale at the 16pt default", () => {

apps/mobile/src/lib/appearancePreferences.ts+4-4

...	...	@@ -75,7 +75,7 @@ export function normalizeBaseFontSize(value: number \| null \| undefined): number
75	75	return Math.min(MAX_BASE_FONT_SIZE, Math.max(MIN_BASE_FONT_SIZE, Math.round(value)));
76	76	}
77	77
78		export function normalizeCodeFontSize(value: number \| null \| undefined): number {
	78	function normalizeCodeFontSize(value: number \| null \| undefined): number {
79	79	if (typeof value !== "number" \|\| !Number.isFinite(value)) {
80	80	return DEFAULT_CODE_FONT_SIZE;
81	81	}
...	...	@@ -83,18 +83,18 @@ export function normalizeCodeFontSize(value: number \| null \| undefined): number
83	83	return Math.min(MAX_CODE_FONT_SIZE, Math.max(MIN_CODE_FONT_SIZE, Math.round(value)));
84	84	}
85	85
86		export function normalizeCodeWordBreak(value: boolean \| null \| undefined): boolean {
	86	function normalizeCodeWordBreak(value: boolean \| null \| undefined): boolean {
87	87	return value === true;
88	88	}
89	89
90	90	/** Terminal size derived from base: 10.5pt at base 16, snapped to 0.5pt steps. */
91		export function deriveTerminalFontSize(baseFontSize: number): number {
	91	function deriveTerminalFontSize(baseFontSize: number): number {
92	92	const scale = normalizeBaseFontSize(baseFontSize) / DEFAULT_BASE_FONT_SIZE;
93	93	return normalizeTerminalFontSize(Math.round(DEFAULT_TERMINAL_FONT_SIZE * scale * 2) / 2);
94	94	}
95	95
96	96	/** Code/diff size derived from base: 12pt at base 16. */
97		export function deriveCodeFontSize(baseFontSize: number): number {
	97	function deriveCodeFontSize(baseFontSize: number): number {
98	98	const scale = normalizeBaseFontSize(baseFontSize) / DEFAULT_BASE_FONT_SIZE;
99	99	return normalizeCodeFontSize(Math.round(DEFAULT_CODE_FONT_SIZE * scale));
100	100	}