| author |  Cursor Agent <cursoragent@cursor.com> 2026-03-04 04:59:14+00:00 |
| committer |  Julius Marminge <jmarminge@gmail.com> 2026-03-03 22:31:45-08:00 |
| log | 6d2f4f4cdf257cf84e7b89aae14c0d9781392216 |
| tree | 446b93dadbe52cb6ab0bee05f890902126451f46 |
| parent | 865d7bd6849de306932bbffabd3a06075313dbc4 |
fix: remove misleading log and redundant guard in handleCheckForUpdatesMenuClick
The guard for status === 'downloaded' logged 'skipping automatic install'
but the function only checks for updates, never installs. The guard was
also redundant since checkForUpdates() already returns early for
'downloaded', 'downloading', and 'available' statuses with correct
log messages.
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Applied via @cursor push command1 files changed, 0 insertions(+), 7 deletions(-)
apps
desktop
src
apps/desktop/src/main.ts-7
| ... | @@ -424,13 +424,6 @@ function dispatchMenuAction(action: string): void { | ... | @@ -424,13 +424,6 @@ function dispatchMenuAction(action: string): void { |
| 424 | } | 424 | } |
| 425 | 425 | ||
| 426 | function handleCheckForUpdatesMenuClick(): void { | 426 | function handleCheckForUpdatesMenuClick(): void { |
| 427 | if (updateState.status === "downloaded") { | ||
| 428 | console.info( | ||
| 429 | "[desktop-updater] Check for updates clicked while an update is already downloaded; skipping automatic install.", | ||
| 430 | ); | ||
| 431 | return; | ||
| 432 | } | ||
| 433 | |||
| 434 | if (!shouldEnableAutoUpdates()) { | 427 | if (!shouldEnableAutoUpdates()) { |
| 435 | console.info("[desktop-updater] Manual update check requested, but updates are disabled."); | 428 | console.info("[desktop-updater] Manual update check requested, but updates are disabled."); |
| 436 | return; | 429 | return; |