Commit 7931227977ca3e6f3354a63467caa634ab79796f | the-knife

author	Julius Marminge <julius0216@outlook.com> 2026-09-14 16:01:36-07:00
committer	GitHub <noreply@github.com> 2026-09-14 16:01:36-07:00
log	7931227977ca3e6f3354a63467caa634ab79796f
tree	ffc38b854be8c091304282ae17d582ca03265973
parent	84192388b3a54ef593d35b64390f99bf6dec6a74
signature	Signed by PGP key B5690EEEBB952194

fix(server): stop refreshing providers on every config subscription (#11811)

Co-authored-by: Bil0000 <bilal.bakr.elsherif@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

2 files changed, 15 insertions(+), 41 deletions(-)

apps
- server
  - src
    server.test.ts
    ws.ts

apps/server/src/server.test.ts+15-37

 @@ -6327,48 +6327,26 @@ it.layer(NodeServices.layer)("server router seam", (it) => {
     }).pipe(Effect.provide(NodeHttpServer.layerTest)),
   );
-  it.effect("refreshes providers for each subscribeServerConfig connection", () =>
+  it.effect("serves config on reconnect without starting provider probes", () =>
     Effect.gen(function* () {
-      const refreshCalls = yield* Ref.make(0);
+      const refresh = vi.fn(() => Effect.never);
-      const firstRefreshDone = yield* Deferred.make<void>();
-      const secondRefreshDone = yield* Deferred.make<void>();
       yield* buildAppUnderTest({
-        layers: {
+        layers: { providerRegistry: { refresh } },
-          providerRegistry: {
-            refresh: () =>
-              Ref.updateAndGet(refreshCalls, (count) => count + 1).pipe(
-                Effect.tap((count) =>
-                  Deferred.succeed(
-                    count === 1 ? firstRefreshDone : secondRefreshDone,
-                    undefined,
-                  ).pipe(Effect.ignore),
-                ),
-                Effect.as([]),
-              ),
-          },
-        },
       });
       const wsUrl = yield* getWsServerUrl("/ws");
-      yield* Effect.scoped(
+      for (let connection = 0; connection < 2; connection += 1) {
-        withWsRpcClient(wsUrl, (client) =>
+        const event = yield* Effect.scoped(
-          Effect.gen(function* () {
+          withWsRpcClient(wsUrl, (client) =>
-            yield* client[WS_METHODS.subscribeServerConfig]({}).pipe(Stream.runHead);
+            client[WS_METHODS.subscribeServerConfig]({}).pipe(
-            yield* Deferred.await(firstRefreshDone);
+              Stream.runHead,
-          }),
+              Effect.map(Option.getOrThrow),
-        ),
+            ),
-      );
+          ),
-      yield* Effect.scoped(
+        );
-        withWsRpcClient(wsUrl, (client) =>
+        assert.equal(event.type, "snapshot");
-          Effect.gen(function* () {
+      }
-            yield* client[WS_METHODS.subscribeServerConfig]({}).pipe(Stream.runHead);
+      assert.equal(refresh.mock.calls.length, 0);
-            yield* Deferred.await(secondRefreshDone);
-          }),
-        ),
-      );
-      assert.equal(yield* Ref.get(refreshCalls), 2);
     }).pipe(Effect.provide(NodeHttpServer.layerTest)),
   );

apps/server/src/ws.ts-4

 @@ -3371,10 +3371,6 @@ const makeWsRpcLayer = (
                 })),
               );
-              yield* providerRegistry
-                .refresh()
-                .pipe(Effect.ignoreCause({ log: true }), Effect.forkScoped);
               const liveUpdates = Stream.merge(
                 keybindingsUpdates,
                 Stream.merge(