authorgravatar for ethorelli@gmail.comErik Thorelli <ethorelli@gmail.com> 2026-10-06 14:26:16-07:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2026-10-06 14:26:16-07:00
log7bee189dfb5cd6807457e98af0c2f95f5ed50edd
treee70494d8e8584ac543de8df0cd6f477e09ce9446
parentfbe5df2d4b630d13adc8fe2d38cab354e6d66d67
signature Signed by PGP key B5690EEEBB952194

chore(tsconfig): turn off the Schema-over-JSON diagnostic in test files (#16375)

Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

32 files changed, 14 insertions(+), 192 deletions(-)

apps/mobile/src/features/cloud/linkEnvironment.test.ts-2
......@@ -293,7 +293,6 @@ describe("mobile cloud link environment client", () => {
293293 const bodies: Array<unknown> = [];
294294 const fetchMock = vi.fn((url: string | URL, init?: RequestInit) => {
295295 if (init?.body) {
296 // @effect-diagnostics-next-line preferSchemaOverJson:off
297296 bodies.push(JSON.parse(requestBodyText(init.body)));
298297 }
299298 if (String(url).endsWith("/v1/client/environment-link-challenges")) {
......@@ -348,7 +347,6 @@ describe("mobile cloud link environment client", () => {
348347 const bodies: Array<Record<string, unknown>> = [];
349348 const fetchMock = vi.fn((url: string | URL, init?: RequestInit) => {
350349 if (init?.body) {
351 // @effect-diagnostics-next-line preferSchemaOverJson:off
352350 bodies.push(JSON.parse(requestBodyText(init.body)) as Record<string, unknown>);
353351 }
354352 if (String(url).endsWith("/v1/client/environment-link-challenges")) {
apps/server/src/cli/config.test.ts-5
......@@ -650,7 +650,6 @@ it.layer(NodeServices.layer)("cli config resolution", (it) => {
650650 yield* fs.makeDirectory(path.dirname(derivedPaths.settingsPath), { recursive: true });
651651 yield* fs.writeFileString(
652652 derivedPaths.settingsPath,
653 // @effect-diagnostics-next-line preferSchemaOverJson:off
654653 `${JSON.stringify({
655654 observability: {
656655 otlpTracesUrl: "http://localhost:4318/v1/traces",
......@@ -722,7 +721,6 @@ it.layer(NodeServices.layer)("cli config resolution", (it) => {
722721 yield* fs.makeDirectory(path.dirname(derivedPaths.settingsPath), { recursive: true });
723722 yield* fs.writeFileString(
724723 derivedPaths.settingsPath,
725 // @effect-diagnostics-next-line preferSchemaOverJson:off
726724 `${JSON.stringify({
727725 observability: {
728726 otlpTracesUrl: "http://localhost:4318/v1/traces",
......@@ -774,7 +772,6 @@ it.layer(NodeServices.layer)("cli config resolution", (it) => {
774772 yield* fs.makeDirectory(path.dirname(derivedPaths.settingsPath), { recursive: true });
775773 yield* fs.writeFileString(
776774 derivedPaths.settingsPath,
777 // @effect-diagnostics-next-line preferSchemaOverJson:off
778775 `${JSON.stringify({
779776 observability: {
780777 otlpTracesUrl: "http://localhost:4318/v1/traces",
......@@ -1073,7 +1070,6 @@ it.layer(NodeServices.layer)("cli config resolution", (it) => {
10731070 yield* fs.makeDirectory(path.dirname(derivedPaths.settingsPath), { recursive: true });
10741071 yield* fs.writeFileString(
10751072 derivedPaths.settingsPath,
1076 // @effect-diagnostics-next-line preferSchemaOverJson:off
10771073 `${JSON.stringify({ observability: { otlpLogsUrl: "http://settings:4318/v1/logs" } })}\n`,
10781074 );
10791075
......@@ -1145,7 +1141,6 @@ it.layer(NodeServices.layer)("cli config resolution", (it) => {
11451141 yield* fs.makeDirectory(path.dirname(derivedPaths.settingsPath), { recursive: true });
11461142 yield* fs.writeFileString(
11471143 derivedPaths.settingsPath,
1148 // @effect-diagnostics-next-line preferSchemaOverJson:off
11491144 `${JSON.stringify({ observability: { otlpLogsUrl: "http://settings:4318/v1/logs" } })}\n`,
11501145 );
11511146
apps/server/src/cli/pair.test.ts-1
......@@ -173,7 +173,6 @@ describe("t3 pair", () => {
173173 const listed = yield* captureStdout(
174174 runCli(["auth", "pairing", "list", "--base-dir", baseDir, "--json"]),
175175 );
176 // @effect-diagnostics-next-line preferSchemaOverJson:off - CLI JSON output is decoded as a presentation DTO.
177176 const credentials = JSON.parse(listed) as ReadonlyArray<{ readonly label?: string }>;
178177 assert.equal(credentials.length, 1);
179178 assert.equal(credentials[0]?.label, "t3 pair");
apps/server/src/cloud/bootService.test.ts-4
......@@ -359,7 +359,6 @@ it.layer(NodeServices.layer)("boot service install", (it) => {
359359 current: true,
360360 installedVersion: "1.2.3",
361361 });
362 // @effect-diagnostics-next-line preferSchemaOverJson:off - fixed launcher-owned test document.
363362 const pendingState = JSON.stringify({
364363 protocol: SERVICE_LAUNCHER_PROTOCOL,
365364 activeVersion: "1.2.3",
......@@ -546,7 +545,6 @@ it.layer(NodeServices.layer)("boot service install", (it) => {
546545 Effect.gen(function* () {
547546 const { service, fs, statePath } = yield* makeHarness();
548547 yield* service.install();
549 // @effect-diagnostics-next-line preferSchemaOverJson:off - fixed launcher-owned test document.
550548 const pendingState = JSON.stringify({
551549 protocol: SERVICE_LAUNCHER_PROTOCOL,
552550 activeVersion: "1.2.3",
......@@ -647,7 +645,6 @@ it.layer(NodeServices.layer)("boot service install", (it) => {
647645 Effect.gen(function* () {
648646 const { service, fs, statePath, commands } = yield* makeHarness();
649647 yield* service.install();
650 // @effect-diagnostics-next-line preferSchemaOverJson:off - fixed launcher-owned test document.
651648 const pendingState = JSON.stringify({
652649 protocol: SERVICE_LAUNCHER_PROTOCOL - 1,
653650 activeVersion: "1.2.3",
......@@ -808,7 +805,6 @@ it.layer(NodeServices.layer)("boot service install", (it) => {
808805 const { service, fs, statePath, commands } = yield* makeHarness("darwin");
809806 yield* service.install();
810807 const plistPath = (yield* service.status).unitPath;
811 // @effect-diagnostics-next-line preferSchemaOverJson:off - fixed launcher-owned test document.
812808 const pendingState = JSON.stringify({
813809 protocol: SERVICE_LAUNCHER_PROTOCOL - 1,
814810 activeVersion: "1.2.3",
apps/server/src/cloud/selfUpdate.test.ts-1
......@@ -84,7 +84,6 @@ const makeHarness = Effect.fn("test.make_self_update_harness")(function* (
8484 launcherProtocol: SERVICE_LAUNCHER_PROTOCOL,
8585 };
8686 return {
87 // @effect-diagnostics-next-line preferSchemaOverJson:off - fake child-process stdout.
8887 stdout: JSON.stringify(result),
8988 stderr: "",
9089 code: ChildProcessSpawner.ExitCode(0),
apps/server/src/device/SshDeviceHost.test.ts-1
......@@ -1,4 +1,3 @@
1// @effect-diagnostics preferSchemaOverJson:off - the external process fixture emits raw JSON over SSH stdout.
21import { expect, it } from "@effect/vitest";
32import * as NodeServices from "@effect/platform-node/NodeServices";
43import * as Net from "@t3tools/shared/Net";
apps/server/src/device/sshDeviceScript.test.ts+1-1
......@@ -1,4 +1,4 @@
1// @effect-diagnostics nodeBuiltinImport:off globalFetchInEffect:off preferSchemaOverJson:off - verifies generated remote scripts using real shell and Node processes.
1// @effect-diagnostics nodeBuiltinImport:off globalFetchInEffect:off - verifies generated remote scripts using real shell and Node processes.
22import * as Effect from "effect/Effect";
33import { HostProcessPlatform } from "@t3tools/shared/hostProcess";
44import { describe, expect, it } from "@effect/vitest";
apps/server/src/git/GitManager.test.ts-52
......@@ -790,7 +790,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
790790 const { manager } = yield* makeManager({
791791 ghScenario: {
792792 prListSequence: [
793 // @effect-diagnostics-next-line preferSchemaOverJson:off
794793 JSON.stringify([
795794 {
796795 number: 13,
......@@ -835,7 +834,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
835834 const { manager } = yield* makeManager({
836835 ghScenario: {
837836 prListSequence: [
838 // @effect-diagnostics-next-line preferSchemaOverJson:off
839837 JSON.stringify([
840838 {
841839 number: 14,
......@@ -875,7 +873,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
875873 const { manager } = yield* makeManager({
876874 ghScenario: {
877875 prListSequence: [
878 // @effect-diagnostics-next-line preferSchemaOverJson:off
879876 JSON.stringify([
880877 {
881878 number: 0,
......@@ -928,7 +925,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
928925 const { manager } = yield* makeManager({
929926 ghScenario: {
930927 prListSequence: [
931 // @effect-diagnostics-next-line preferSchemaOverJson:off
932928 JSON.stringify([
933929 {
934930 number: 16,
......@@ -1042,7 +1038,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
10421038 };
10431039 const { manager, ghCalls } = yield* makeManager({
10441040 ghScenario: {
1045 // @effect-diagnostics-next-line preferSchemaOverJson:off
10461041 prListSequence: [JSON.stringify([existingPr]), JSON.stringify([existingPr])],
10471042 },
10481043 });
......@@ -1095,7 +1090,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
10951090 ghScenario: {
10961091 prListSequence: [
10971092 // Fake gh returns raw JSON stdout, matching the CLI boundary under test.
1098 // @effect-diagnostics-next-line preferSchemaOverJson:off
10991093 JSON.stringify([
11001094 {
11011095 number: 217,
......@@ -1138,7 +1132,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
11381132 prListSequence: [
11391133 "[]",
11401134 // Fake gh returns raw JSON stdout, matching the CLI boundary under test.
1141 // @effect-diagnostics-next-line preferSchemaOverJson:off
11421135 JSON.stringify([
11431136 {
11441137 number: 114,
......@@ -1244,7 +1237,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
12441237 ghScenario: {
12451238 prListSequence: [
12461239 // Fake gh returns raw JSON stdout, matching the CLI boundary under test.
1247 // @effect-diagnostics-next-line preferSchemaOverJson:off
12481240 JSON.stringify([
12491241 {
12501242 number: 216,
......@@ -1296,7 +1288,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
12961288 ghScenario: {
12971289 // Fake gh returns raw JSON stdout, matching the CLI boundary under test.
12981290 prListSequence: [
1299 // @effect-diagnostics-next-line preferSchemaOverJson:off
13001291 JSON.stringify([
13011292 {
13021293 number: 221,
......@@ -1347,7 +1338,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
13471338 ghScenario: {
13481339 prListSequence: [
13491340 // Fake gh returns raw JSON stdout, matching the CLI boundary under test.
1350 // @effect-diagnostics-next-line preferSchemaOverJson:off
13511341 JSON.stringify([
13521342 {
13531343 number: 217,
......@@ -1410,7 +1400,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
14101400 ghScenario: {
14111401 prListByHeadSelector: {
14121402 // Fake gh returns raw JSON stdout, matching the CLI boundary under test.
1413 // @effect-diagnostics-next-line preferSchemaOverJson:off
14141403 "feature/deleted-fork-branch": JSON.stringify([
14151404 {
14161405 number: 218,
......@@ -1492,7 +1481,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
14921481 ghScenario: {
14931482 prListSequence: [
14941483 // Fake gh returns raw JSON stdout, matching the CLI boundary under test.
1495 // @effect-diagnostics-next-line preferSchemaOverJson:off
14961484 JSON.stringify([
14971485 {
14981486 number: 219,
......@@ -1545,7 +1533,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
15451533 ghScenario: {
15461534 prListSequence: [
15471535 // Fake gh returns raw JSON stdout, matching the CLI boundary under test.
1548 // @effect-diagnostics-next-line preferSchemaOverJson:off
15491536 JSON.stringify([
15501537 {
15511538 number: 220,
......@@ -1719,7 +1706,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
17191706 const { manager, ghCalls } = yield* makeManager({
17201707 ghScenario: {
17211708 prListSequence: [
1722 // @effect-diagnostics-next-line preferSchemaOverJson:off
17231709 JSON.stringify([
17241710 {
17251711 number: 215,
......@@ -1768,7 +1754,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
17681754 const { manager, ghCalls } = yield* makeManager({
17691755 ghScenario: {
17701756 prListSequence: [
1771 // @effect-diagnostics-next-line preferSchemaOverJson:off
17721757 JSON.stringify([
17731758 {
17741759 number: 214,
......@@ -1991,7 +1976,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
19911976 const { manager } = yield* makeManager({
19921977 ghScenario: {
19931978 prListSequence: [
1994 // @effect-diagnostics-next-line preferSchemaOverJson:off
19951979 JSON.stringify([
19961980 {
19971981 number: 1661,
......@@ -2045,7 +2029,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
20452029 const { manager, ghCalls } = yield* makeManager({
20462030 ghScenario: {
20472031 prListSequence: [
2048 // @effect-diagnostics-next-line preferSchemaOverJson:off
20492032 JSON.stringify([
20502033 {
20512034 number: 488,
......@@ -2111,7 +2094,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
21112094 const { manager, ghCalls } = yield* makeManager({
21122095 ghScenario: {
21132096 prListByHeadSelector: {
2114 // @effect-diagnostics-next-line preferSchemaOverJson:off
21152097 main: JSON.stringify([
21162098 {
21172099 number: 777,
......@@ -2187,7 +2169,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
21872169 const { manager, ghCalls } = yield* makeManager({
21882170 ghScenario: {
21892171 prListByHeadSelector: {
2190 // @effect-diagnostics-next-line preferSchemaOverJson:off
21912172 "effect-atom": JSON.stringify([
21922173 {
21932174 number: 1618,
......@@ -2199,7 +2180,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
21992180 updatedAt: "2026-03-01T10:00:00Z",
22002181 },
22012182 ]),
2202 // @effect-diagnostics-next-line preferSchemaOverJson:off
22032183 "upstream/effect-atom": JSON.stringify([
22042184 {
22052185 number: 1518,
......@@ -2250,7 +2230,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
22502230 const { manager } = yield* makeManager({
22512231 ghScenario: {
22522232 prListSequence: [
2253 // @effect-diagnostics-next-line preferSchemaOverJson:off
22542233 JSON.stringify([
22552234 {
22562235 number: 22,
......@@ -2289,7 +2268,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
22892268 const { manager } = yield* makeManager({
22902269 ghScenario: {
22912270 prListSequence: [
2292 // @effect-diagnostics-next-line preferSchemaOverJson:off
22932271 JSON.stringify([
22942272 {
22952273 number: 23,
......@@ -2325,7 +2303,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
23252303 const { manager, ghCalls } = yield* makeManager({
23262304 ghScenario: {
23272305 prListSequence: [
2328 // @effect-diagnostics-next-line preferSchemaOverJson:off
23292306 JSON.stringify([
23302307 {
23312308 number: 54,
......@@ -2365,7 +2342,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
23652342 ghScenario: {
23662343 prListByHeadSelector: {
23672344 // Fake gh returns raw JSON stdout, matching the CLI boundary under test.
2368 // @effect-diagnostics-next-line preferSchemaOverJson:off
23692345 "feature/pushed-plain": JSON.stringify([
23702346 {
23712347 number: 88,
......@@ -2420,7 +2396,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
24202396 ghScenario: {
24212397 prListByHeadSelector: {
24222398 // Fake gh returns raw JSON stdout, matching the CLI boundary under test.
2423 // @effect-diagnostics-next-line preferSchemaOverJson:off
24242399 "feature/fork-plain": JSON.stringify([
24252400 {
24262401 number: 89,
......@@ -2476,7 +2451,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
24762451 ghScenario: {
24772452 prListByHeadSelector: {
24782453 // Fake gh returns raw JSON stdout, matching the CLI boundary under test.
2479 // @effect-diagnostics-next-line preferSchemaOverJson:off
24802454 "feature/fork-settle": JSON.stringify([
24812455 {
24822456 number: 91,
......@@ -2524,7 +2498,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
25242498 ghScenario: {
25252499 prListByHeadSelector: {
25262500 // Fake gh returns raw JSON stdout, matching the CLI boundary under test.
2527 // @effect-diagnostics-next-line preferSchemaOverJson:off
25282501 "feature/sticky-plain": JSON.stringify([
25292502 {
25302503 number: 90,
......@@ -2564,7 +2537,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
25642537 const { manager } = yield* makeManager({
25652538 ghScenario: {
25662539 prListSequence: [
2567 // @effect-diagnostics-next-line preferSchemaOverJson:off
25682540 JSON.stringify([
25692541 {
25702542 number: 45,
......@@ -2698,7 +2670,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
26982670 };
26992671 const { manager } = yield* makeManager({
27002672 ghScenario: {
2701 // @effect-diagnostics-next-line preferSchemaOverJson:off
27022673 prListSequence: [JSON.stringify([existingPr])],
27032674 failWith: new GitHubCli.GitHubCliUnavailableError({
27042675 command: "gh",
......@@ -2742,7 +2713,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
27422713 };
27432714 const { manager } = yield* makeManager({
27442715 ghScenario: {
2745 // @effect-diagnostics-next-line preferSchemaOverJson:off
27462716 prListSequence: [JSON.stringify([existingPr])],
27472717 failWith: new GitHubCli.GitHubCliUnavailableError({
27482718 command: "gh",
......@@ -2791,7 +2761,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
27912761 };
27922762 const { manager } = yield* makeManager({
27932763 ghScenario: {
2794 // @effect-diagnostics-next-line preferSchemaOverJson:off
27952764 prListSequence: [JSON.stringify([existingPr])],
27962765 failWith: new GitHubCli.GitHubCliUnavailableError({
27972766 command: "gh",
......@@ -2831,7 +2800,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
28312800 };
28322801 const { manager } = yield* makeManager({
28332802 ghScenario: {
2834 // @effect-diagnostics-next-line preferSchemaOverJson:off
28352803 prListSequence: [JSON.stringify([existingPr])],
28362804 failWith: new GitHubCli.GitHubCliUnavailableError({
28372805 command: "gh",
......@@ -2874,7 +2842,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
28742842 };
28752843 const { manager } = yield* makeManager({
28762844 ghScenario: {
2877 // @effect-diagnostics-next-line preferSchemaOverJson:off
28782845 prListSequence: [JSON.stringify([existingPr])],
28792846 failWith: new GitHubCli.GitHubCliUnavailableError({
28802847 command: "gh",
......@@ -3469,7 +3436,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
34693436 ghScenario: {
34703437 prListSequence: [
34713438 "[]",
3472 // @effect-diagnostics-next-line preferSchemaOverJson:off
34733439 JSON.stringify([
34743440 {
34753441 number: 77,
......@@ -3605,7 +3571,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
36053571 ghScenario: {
36063572 prListSequence: [
36073573 "[]",
3608 // @effect-diagnostics-next-line preferSchemaOverJson:off
36093574 JSON.stringify([
36103575 {
36113576 number: 303,
......@@ -3652,7 +3617,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
36523617 ghScenario: {
36533618 prListSequence: [
36543619 "[]",
3655 // @effect-diagnostics-next-line preferSchemaOverJson:off
36563620 JSON.stringify([
36573621 {
36583622 number: 404,
......@@ -3704,7 +3668,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
37043668 defaultBranch: "",
37053669 prListSequence: [
37063670 "[]",
3707 // @effect-diagnostics-next-line preferSchemaOverJson:off
37083671 JSON.stringify([
37093672 {
37103673 number: 505,
......@@ -3744,7 +3707,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
37443707 const { manager, ghCalls } = yield* makeManager({
37453708 ghScenario: {
37463709 prListSequence: [
3747 // @effect-diagnostics-next-line preferSchemaOverJson:off
37483710 JSON.stringify([
37493711 {
37503712 number: 42,
......@@ -3798,7 +3760,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
37983760 const { manager, ghCalls } = yield* makeManager({
37993761 ghScenario: {
38003762 prListSequence: [
3801 // @effect-diagnostics-next-line preferSchemaOverJson:off
38023763 JSON.stringify([
38033764 {
38043765 number: 142,
......@@ -3875,7 +3836,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
38753836 const { manager, ghCalls } = yield* makeManager({
38763837 ghScenario: {
38773838 prListByHeadSelector: {
3878 // @effect-diagnostics-next-line preferSchemaOverJson:off
38793839 "effect-atom": JSON.stringify([
38803840 {
38813841 number: 1618,
......@@ -3885,7 +3845,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
38853845 headRefName: "effect-atom",
38863846 },
38873847 ]),
3888 // @effect-diagnostics-next-line preferSchemaOverJson:off
38893848 "upstream/effect-atom": JSON.stringify([
38903849 {
38913850 number: 1518,
......@@ -3935,9 +3894,7 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
39353894 const { manager, ghCalls } = yield* makeManager({
39363895 ghScenario: {
39373896 prListByHeadSelector: {
3938 // @effect-diagnostics-next-line preferSchemaOverJson:off
39393897 "t3code/pr-142/statemachine": JSON.stringify([]),
3940 // @effect-diagnostics-next-line preferSchemaOverJson:off
39413898 statemachine: JSON.stringify([
39423899 {
39433900 number: 41,
......@@ -4003,7 +3960,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
40033960 const { manager, ghCalls } = yield* makeManager({
40043961 ghScenario: {
40053962 prListByHeadSelector: {
4006 // @effect-diagnostics-next-line preferSchemaOverJson:off
40073963 statemachine: JSON.stringify([
40083964 {
40093965 number: 142,
......@@ -4021,7 +3977,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
40213977 },
40223978 },
40233979 ]),
4024 // @effect-diagnostics-next-line preferSchemaOverJson:off
40253980 "t3code/pr-142/statemachine": JSON.stringify([]),
40263981 },
40273982 },
......@@ -4264,7 +4219,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
42644219 ghScenario: {
42654220 prListSequence: [
42664221 "[]",
4267 // @effect-diagnostics-next-line preferSchemaOverJson:off
42684222 JSON.stringify([
42694223 {
42704224 number: 88,
......@@ -4385,7 +4339,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
43854339 const { manager, ghCalls } = yield* makeManager({
43864340 ghScenario: {
43874341 prListSequence: [
4388 // @effect-diagnostics-next-line preferSchemaOverJson:off
43894342 JSON.stringify([
43904343 {
43914344 number: 1661,
......@@ -4403,7 +4356,6 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
44034356 },
44044357 },
44054358 ]),
4406 // @effect-diagnostics-next-line preferSchemaOverJson:off
44074359 JSON.stringify([
44084360 {
44094361 number: 188,
......@@ -4466,9 +4418,7 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
44664418 ghScenario: {
44674419 prListSequenceByHeadSelector: {
44684420 statemachine: [
4469 // @effect-diagnostics-next-line preferSchemaOverJson:off
44704421 JSON.stringify([]),
4471 // @effect-diagnostics-next-line preferSchemaOverJson:off
44724422 JSON.stringify([
44734423 {
44744424 number: 188,
......@@ -6084,9 +6034,7 @@ it.layer(layerGitManagerTest)("GitManager", (it) => {
60846034 const { manager } = yield* makeManager({
60856035 ghScenario: {
60866036 prListSequence: [
6087 // @effect-diagnostics-next-line preferSchemaOverJson:off
60886037 JSON.stringify([]),
6089 // @effect-diagnostics-next-line preferSchemaOverJson:off
60906038 JSON.stringify([
60916039 {
60926040 number: 201,
apps/server/src/keybindings.test.ts-1
......@@ -219,7 +219,6 @@ it.layer(NodeServices.layer)("keybindings", (it) => {
219219 const { keybindingsConfigPath } = yield* ServerConfig.ServerConfig;
220220 yield* fs.writeFileString(
221221 keybindingsConfigPath,
222 // @effect-diagnostics-next-line preferSchemaOverJson:off
223222 JSON.stringify([
224223 { key: "mod+j", command: "terminal.toggle" },
225224 { key: "mod+shift+d+o", command: "terminal.new" },
apps/server/src/mcp/AcpMcpOverAcpBridge.test.ts-1
......@@ -1,5 +1,4 @@
11// The bridge intentionally treats MCP JSON-RPC messages as opaque JSON.
2// @effect-diagnostics preferSchemaOverJson:off
32import { describe, expect, it } from "@effect/vitest";
43import * as Effect from "effect/Effect";
54import * as Fiber from "effect/Fiber";
apps/server/src/mcp/AcpMcpStdioBridge.test.ts+1-1
......@@ -1,6 +1,6 @@
11// The harness asserts raw JSON-RPC wire strings, mirroring the bridge's
22// schema-free passthrough.
3// @effect-diagnostics nodeBuiltinImport:off globalTimers:off preferSchemaOverJson:off
3// @effect-diagnostics nodeBuiltinImport:off globalTimers:off
44import * as NodeStream from "node:stream";
55
66import { describe, expect, it } from "@effect/vitest";
apps/server/src/orchestration-v2/ProjectStore.test.ts-1
......@@ -44,7 +44,6 @@ it.layer(ProjectStore.layer.pipe(Layer.provideMerge(SqlitePersistence.layerMemor
4444 FROM projection_projects
4545 WHERE project_id = ${projectId}
4646 `;
47 // @effect-diagnostics-next-line preferSchemaOverJson:off
4847 assert.strictEqual(rows[0]?.defaultModelSelection, JSON.stringify(modelSelection));
4948 assert.deepStrictEqual(
5049 Option.getOrNull(yield* projects.get(projectId))?.defaultModelSelection,
apps/server/src/persistence/Migrations/016_CanonicalizeModelSelections.test.ts-7
......@@ -265,7 +265,6 @@ layer("016_CanonicalizeModelSelections", (it) => {
265265 FROM orchestration_events
266266 ORDER BY rowid ASC
267267 `;
268 // @effect-diagnostics-next-line preferSchemaOverJson:off
269268 assert.deepStrictEqual(JSON.parse(eventRows[0]!.payloadJson), {
270269 projectId: "project-1",
271270 title: "Project",
......@@ -281,7 +280,6 @@ layer("016_CanonicalizeModelSelections", (it) => {
281280 createdAt: "2026-01-01T00:00:00.000Z",
282281 updatedAt: "2026-01-01T00:00:00.000Z",
283282 });
284 // @effect-diagnostics-next-line preferSchemaOverJson:off
285283 assert.deepStrictEqual(JSON.parse(eventRows[1]!.payloadJson), {
286284 projectId: "project-2",
287285 title: "Fallback Project",
......@@ -297,7 +295,6 @@ layer("016_CanonicalizeModelSelections", (it) => {
297295 createdAt: "2026-01-01T00:00:00.000Z",
298296 updatedAt: "2026-01-01T00:00:00.000Z",
299297 });
300 // @effect-diagnostics-next-line preferSchemaOverJson:off
301298 assert.deepStrictEqual(JSON.parse(eventRows[2]!.payloadJson), {
302299 projectId: "project-3",
303300 title: "Null Model Project",
......@@ -307,7 +304,6 @@ layer("016_CanonicalizeModelSelections", (it) => {
307304 createdAt: "2026-01-01T00:00:00.000Z",
308305 updatedAt: "2026-01-01T00:00:00.000Z",
309306 });
310 // @effect-diagnostics-next-line preferSchemaOverJson:off
311307 assert.deepStrictEqual(JSON.parse(eventRows[3]!.payloadJson), {
312308 threadId: "thread-1",
313309 projectId: "project-1",
......@@ -327,7 +323,6 @@ layer("016_CanonicalizeModelSelections", (it) => {
327323 createdAt: "2026-01-01T00:00:00.000Z",
328324 updatedAt: "2026-01-01T00:00:00.000Z",
329325 });
330 // @effect-diagnostics-next-line preferSchemaOverJson:off
331326 assert.deepStrictEqual(JSON.parse(eventRows[4]!.payloadJson), {
332327 threadId: "thread-2",
333328 projectId: "project-1",
......@@ -346,7 +341,6 @@ layer("016_CanonicalizeModelSelections", (it) => {
346341 createdAt: "2026-01-01T00:00:00.000Z",
347342 updatedAt: "2026-01-01T00:00:00.000Z",
348343 });
349 // @effect-diagnostics-next-line preferSchemaOverJson:off
350344 assert.deepStrictEqual(JSON.parse(eventRows[5]!.payloadJson), {
351345 threadId: "thread-1",
352346 turnId: "turn-1",
......@@ -360,7 +354,6 @@ layer("016_CanonicalizeModelSelections", (it) => {
360354 },
361355 deliveryMode: "buffered",
362356 });
363 // @effect-diagnostics-next-line preferSchemaOverJson:off
364357 assert.deepStrictEqual(JSON.parse(eventRows[6]!.payloadJson), {
365358 threadId: "thread-3",
366359 projectId: "project-1",
apps/server/src/provider/ClaudeCapabilitiesProbe.test.ts-2
......@@ -293,7 +293,6 @@ it.layer(NodeServices.layer)("Claude capability probe SDK boundary", (it) => {
293293 },
294294 });
295295
296 // @effect-diagnostics-next-line preferSchemaOverJson:off
297296 const invocation = JSON.parse(yield* fs.readFileString(invocationPath)) as {
298297 readonly args: ReadonlyArray<string>;
299298 readonly cwd: string;
......@@ -310,7 +309,6 @@ it.layer(NodeServices.layer)("Claude capability probe SDK boundary", (it) => {
310309
311310 const settingsFlagIndex = invocation.args.indexOf("--settings");
312311 assert.notEqual(settingsFlagIndex, -1);
313 // @effect-diagnostics-next-line preferSchemaOverJson:off
314312 const flagSettings = JSON.parse(invocation.args[settingsFlagIndex + 1] ?? "{}") as {
315313 readonly disableAllHooks?: boolean;
316314 };
apps/server/src/provider/CodexChatGptAuth.test.ts+1-1
......@@ -1,4 +1,4 @@
1// @effect-diagnostics nodeBuiltinImport:off globalFetchInEffect:off preferSchemaOverJson:off - Local mock OAuth server validates the browser callback boundary.
1// @effect-diagnostics nodeBuiltinImport:off globalFetchInEffect:off - Local mock OAuth server validates the browser callback boundary.
22import * as NodeHttp from "node:http";
33import * as NodeCrypto from "node:crypto";
44import * as NodeServices from "@effect/platform-node/NodeServices";
apps/server/src/provider/CodexChatGptModels.test.ts-1
......@@ -1,4 +1,3 @@
1// @effect-diagnostics preferSchemaOverJson:off - Mock HTTP responses use JSON fixtures.
21import { assert, it } from "@effect/vitest";
32import * as Effect from "effect/Effect";
43import { HttpClient, HttpClientResponse } from "effect/http";
apps/server/src/provider/GrokProvider.test.ts-2
......@@ -380,7 +380,6 @@ it.layer(NodeServices.layer)("checkGrokProviderStatus", (it) => {
380380 directory: dir,
381381 name: "grok",
382382 source: [
383 // @effect-diagnostics-next-line preferSchemaOverJson:off
384383 `process.stderr.write(${JSON.stringify(`${secretStderr}\n`)});`,
385384 "process.exit(2);",
386385 "",
......@@ -417,7 +416,6 @@ it.layer(NodeServices.layer)("checkGrokProviderStatus", (it) => {
417416 " process.exit(0);",
418417 "}",
419418 'if (process.argv[2] === "models") {',
420 // @effect-diagnostics-next-line preferSchemaOverJson:off
421419 ` process.stdout.write(${JSON.stringify(input.modelsOutput)});`,
422420 " process.exit(0);",
423421 "}",
apps/server/src/provider/ProviderInstanceRegistry.test.ts-2
......@@ -172,7 +172,6 @@ const makeTildeProviderFixtures = Effect.fn(
172172 );
173173 yield* fileSystem.writeFileString(
174174 codexScriptPath,
175 // @effect-diagnostics-next-line preferSchemaOverJson:off - fixed script document read by the external Codex mock peer.
176175 JSON.stringify({ rootThreadId: "probe-thread", notifications: [] }),
177176 );
178177 yield* fileSystem.chmod(codexPath, 0o755);
......@@ -346,7 +345,6 @@ describe("ProviderInstanceRegistry — multi-instance codex slice", () => {
346345 const fixtures = yield* makeTildeProviderFixtures();
347346 yield* fileSystem.writeFileString(
348347 fixtures.codexScriptPath,
349 // @effect-diagnostics-next-line preferSchemaOverJson:off - fixed script document read by the external Codex mock peer.
350348 JSON.stringify({
351349 rootThreadId: "probe-thread",
352350 notifications: [],
apps/server/src/pullRequest/AzureDevOpsPullRequestCli.test.ts-9
......@@ -228,7 +228,6 @@ layer("AzureDevOpsPullRequestCli.layer", (it) => {
228228 ...row,
229229 description: "x".repeat(10_000),
230230 }));
231 // @effect-diagnostics-next-line preferSchemaOverJson:off
232231 const response = JSON.stringify(rows);
233232 expect(Buffer.byteLength(response)).toBeGreaterThan(1_000_000);
234233
......@@ -341,7 +340,6 @@ layer("AzureDevOpsPullRequestCli.layer", (it) => {
341340 .mockReturnValueOnce(
342341 Effect.succeed(
343342 output(
344 // @effect-diagnostics-next-line preferSchemaOverJson:off
345343 JSON.stringify([
346344 { pullRequestId: "malformed" },
347345 pullRequestRows(1, 1)[0],
......@@ -434,7 +432,6 @@ layer("AzureDevOpsPullRequestCli.layer", (it) => {
434432 Effect.gen(function* () {
435433 // `--query user` unwraps the object, so the wrapper has to put it back.
436434 mockedExecute.mockReturnValueOnce(
437 // @effect-diagnostics-next-line preferSchemaOverJson:off
438435 Effect.succeed(output(JSON.stringify({ name: "bilal@acme.dev", type: "user" }))),
439436 );
440437 const cli = yield* AzureDevOpsPullRequestCli.AzureDevOpsPullRequestCli;
......@@ -636,7 +633,6 @@ layer("AzureDevOpsPullRequestCli.layer", (it) => {
636633 .mockReturnValueOnce(
637634 Effect.succeed(
638635 output(
639 // @effect-diagnostics-next-line preferSchemaOverJson:off
640636 JSON.stringify({
641637 pullRequestId: 42,
642638 title: "Add the page",
......@@ -653,7 +649,6 @@ layer("AzureDevOpsPullRequestCli.layer", (it) => {
653649 .mockReturnValueOnce(
654650 Effect.succeed(
655651 output(
656 // @effect-diagnostics-next-line preferSchemaOverJson:off
657652 JSON.stringify({
658653 value: [
659654 {
......@@ -674,7 +669,6 @@ layer("AzureDevOpsPullRequestCli.layer", (it) => {
674669 .mockReturnValueOnce(
675670 Effect.succeed(
676671 output(
677 // @effect-diagnostics-next-line preferSchemaOverJson:off
678672 JSON.stringify({
679673 changeEntries: [
680674 { changeType: "edit", item: { path: "/README.md", objectId: "8f80" } },
......@@ -713,7 +707,6 @@ layer("AzureDevOpsPullRequestCli.layer", (it) => {
713707 // pull request read every time they checked whether a file had been pushed to.
714708 const pullRequest = Effect.succeed(
715709 output(
716 // @effect-diagnostics-next-line preferSchemaOverJson:off
717710 JSON.stringify({
718711 pullRequestId: 42,
719712 title: "Add the page",
......@@ -1219,7 +1212,6 @@ layer("AzureDevOpsPullRequestCli.layer", (it) => {
12191212 mockedExecute.mockReturnValueOnce(
12201213 Effect.succeed(
12211214 output(
1222 // @effect-diagnostics-next-line preferSchemaOverJson:off
12231215 JSON.stringify({
12241216 value: [
12251217 {
......@@ -1374,7 +1366,6 @@ layer("AzureDevOpsPullRequestCli.layer", (it) => {
13741366 Effect.succeed(
13751367 output(
13761368 // Well-formed, but with nothing to build a link from: not a decode failure.
1377 // @effect-diagnostics-next-line preferSchemaOverJson:off
13781369 JSON.stringify({
13791370 pullRequestId: 42,
13801371 title: "Add the page",
apps/server/src/pullRequest/BitbucketPullRequestApi.test.ts-16
......@@ -676,7 +676,6 @@ layer("BitbucketPullRequestApi.layer", (it) => {
676676 expect(call.method).toBe("PUT");
677677 expect(call.url).toBe("/repositories/acme/web/pullrequests/7");
678678 // Bitbucket's PUT is a partial update, so a field left out of the body is left as it was.
679 // @effect-diagnostics-next-line preferSchemaOverJson:off
680679 expect(JSON.parse(call.body ?? "")).toEqual({ title: "A new title" });
681680 }),
682681 );
......@@ -688,7 +687,6 @@ layer("BitbucketPullRequestApi.layer", (it) => {
688687
689688 yield* api.updateChangeRequest({ repository: "acme/web", number: 7, body: "New body." });
690689
691 // @effect-diagnostics-next-line preferSchemaOverJson:off
692690 expect(JSON.parse(callAt(0).body ?? "")).toEqual({ description: "New body." });
693691 }),
694692 );
......@@ -705,7 +703,6 @@ layer("BitbucketPullRequestApi.layer", (it) => {
705703 body: "New body.",
706704 });
707705
708 // @effect-diagnostics-next-line preferSchemaOverJson:off
709706 expect(JSON.parse(callAt(0).body ?? "")).toEqual({
710707 title: "A new title",
711708 description: "New body.",
......@@ -736,7 +733,6 @@ layer("BitbucketPullRequestApi.layer", (it) => {
736733 it.effect("fails the read when Bitbucket answers with something unreadable", () =>
737734 Effect.gen(function* () {
738735 mockedRequest.mockReturnValueOnce(
739 // @effect-diagnostics-next-line preferSchemaOverJson:off
740736 Effect.succeed(response(JSON.stringify({ error: "nope" }))),
741737 );
742738 const api = yield* BitbucketPullRequestApi.BitbucketPullRequestApi;
......@@ -769,7 +765,6 @@ layer("BitbucketPullRequestApi.layer", (it) => {
769765
770766 it.effect("fails when the credentials belong to no named account", () =>
771767 Effect.gen(function* () {
772 // @effect-diagnostics-next-line preferSchemaOverJson:off
773768 mockedRequest.mockReturnValueOnce(Effect.succeed(response(JSON.stringify({}))));
774769 const api = yield* BitbucketPullRequestApi.BitbucketPullRequestApi;
775770
......@@ -784,7 +779,6 @@ layer("BitbucketPullRequestApi.layer", (it) => {
784779 mockedRequest.mockReturnValueOnce(
785780 Effect.succeed(
786781 response(
787 // @effect-diagnostics-next-line preferSchemaOverJson:off
788782 JSON.stringify({
789783 next: "https://api.bitbucket.org/2.0/comments?page=2",
790784 values: [
......@@ -805,7 +799,6 @@ layer("BitbucketPullRequestApi.layer", (it) => {
805799 response(
806800 // The reply arrives a page after the remark it answers, which is why the threads
807801 // are only assembled once every page is in hand.
808 // @effect-diagnostics-next-line preferSchemaOverJson:off
809802 JSON.stringify({
810803 values: [
811804 {
......@@ -840,7 +833,6 @@ layer("BitbucketPullRequestApi.layer", (it) => {
840833 mockedRequest.mockReturnValue(
841834 Effect.succeed(
842835 response(
843 // @effect-diagnostics-next-line preferSchemaOverJson:off
844836 JSON.stringify({
845837 next: "https://api.bitbucket.org/2.0/comments?page=2",
846838 values: [
......@@ -868,7 +860,6 @@ layer("BitbucketPullRequestApi.layer", (it) => {
868860 mockedRequest.mockReturnValueOnce(
869861 Effect.succeed(
870862 response(
871 // @effect-diagnostics-next-line preferSchemaOverJson:off
872863 JSON.stringify({
873864 values: [
874865 {
......@@ -941,7 +932,6 @@ layer("BitbucketPullRequestApi.layer", (it) => {
941932 });
942933
943934 expect(callAt(0).url).toContain("/pullrequests/7/comments");
944 // @effect-diagnostics-next-line preferSchemaOverJson:off
945935 expect(JSON.parse(callAt(0).body ?? "")).toEqual({
946936 content: { raw: "why remove?" },
947937 inline: { path: "src/a.ts", from: 12 },
......@@ -988,7 +978,6 @@ layer("BitbucketPullRequestApi.layer", (it) => {
988978 body: "Fixed.",
989979 });
990980
991 // @effect-diagnostics-next-line preferSchemaOverJson:off
992981 expect(JSON.parse(callAt(0).body ?? "")).toEqual({
993982 content: { raw: "Fixed." },
994983 parent: { id: 10 },
......@@ -1001,7 +990,6 @@ layer("BitbucketPullRequestApi.layer", (it) => {
1001990 mockedRequest.mockReturnValue(
1002991 Effect.succeed(
1003992 response(
1004 // @effect-diagnostics-next-line preferSchemaOverJson:off
1005993 JSON.stringify({ values: [{ type: "repository_permission", permission: "read" }] }),
1006994 ),
1007995 ),
......@@ -1017,7 +1005,6 @@ layer("BitbucketPullRequestApi.layer", (it) => {
10171005
10181006 it.effect("escapes a repository name before it goes inside a filter literal", () =>
10191007 Effect.gen(function* () {
1020 // @effect-diagnostics-next-line preferSchemaOverJson:off
10211008 mockedRequest.mockReturnValue(Effect.succeed(response(JSON.stringify({ values: [] }))));
10221009 const api = yield* BitbucketPullRequestApi.BitbucketPullRequestApi;
10231010
......@@ -1075,7 +1062,6 @@ layer("BitbucketPullRequestApi.layer", (it) => {
10751062 .mockReturnValueOnce(
10761063 Effect.succeed(
10771064 response(
1078 // @effect-diagnostics-next-line preferSchemaOverJson:off
10791065 JSON.stringify({ values: [{ user: bilal }, { user: octocat }, { user: hubot }] }),
10801066 ),
10811067 ),
......@@ -1113,7 +1099,6 @@ layer("BitbucketPullRequestApi.layer", (it) => {
11131099 const call = callAt(1);
11141100 expect(call.method).toBe("PUT");
11151101 expect(call.url).toBe("/repositories/acme/web/pullrequests/7");
1116 // @effect-diagnostics-next-line preferSchemaOverJson:off
11171102 expect(JSON.parse(call.body ?? "")).toEqual({
11181103 reviewers: [{ uuid: "{octocat}" }, { uuid: "{hubot}" }],
11191104 });
......@@ -1136,7 +1121,6 @@ layer("BitbucketPullRequestApi.layer", (it) => {
11361121 requested: false,
11371122 });
11381123
1139 // @effect-diagnostics-next-line preferSchemaOverJson:off
11401124 expect(JSON.parse(callAt(1).body ?? "")).toEqual({ reviewers: [{ uuid: "{octocat}" }] });
11411125 }),
11421126 );
apps/server/src/pullRequest/GitHubPullRequestCli.test.ts-1
......@@ -789,7 +789,6 @@ layer("GitHubPullRequestCli.layer", (it) => {
789789 mockedExecute.mockReturnValueOnce(
790790 Effect.succeed(
791791 output(
792 // @effect-diagnostics-next-line preferSchemaOverJson:off
793792 JSON.stringify({
794793 data: { w0: { pullRequest: node(1) }, w1: { pullRequest: null } },
795794 }),
apps/server/src/pullRequest/GitLabPullRequestCli.test.ts+2-38
......@@ -226,10 +226,8 @@ layer("GitLabPullRequestCli.layer", (it) => {
226226
227227 it.effect("advances the cursor through malformed raw rows", () =>
228228 Effect.gen(function* () {
229 // @effect-diagnostics-next-line preferSchemaOverJson:off
230229 const rows = JSON.parse(mergeRequests(2, 1)) as ReadonlyArray<unknown>;
231230 mockedExecute.mockReturnValueOnce(
232 // @effect-diagnostics-next-line preferSchemaOverJson:off
233231 Effect.succeed(output(JSON.stringify([{ iid: "malformed" }, ...rows]))),
234232 );
235233 const cli = yield* GitLabPullRequestCli.GitLabPullRequestCli;
......@@ -314,7 +312,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
314312 Effect.gen(function* () {
315313 // Full pages of unusable rows: nothing is collected, so the collected-count bound never
316314 // trips and only the page bound can end the walk.
317 // @effect-diagnostics-next-line preferSchemaOverJson:off
318315 const unusable = JSON.stringify(Array.from({ length: 100 }, () => ({ iid: "nope" })));
319316 mockedExecute.mockReturnValue(Effect.succeed(output(unusable)));
320317 const cli = yield* GitLabPullRequestCli.GitLabPullRequestCli;
......@@ -627,7 +624,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
627624 it.effect("reports a commit with no parent as a structured error", () =>
628625 Effect.gen(function* () {
629626 mockedExecute.mockReturnValueOnce(
630 // @effect-diagnostics-next-line preferSchemaOverJson:off
631627 Effect.succeed(output(JSON.stringify({ id: "a1b2c3d", parent_ids: [] }))),
632628 );
633629 const cli = yield* GitLabPullRequestCli.GitLabPullRequestCli;
......@@ -654,7 +650,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
654650 it.effect("expands a new file from a root commit without requiring a parent", () =>
655651 Effect.gen(function* () {
656652 mockedExecute.mockReturnValueOnce(
657 // @effect-diagnostics-next-line preferSchemaOverJson:off
658653 Effect.succeed(output(JSON.stringify({ id: "a1b2c3d", parent_ids: [] }))),
659654 );
660655 mockedExecute.mockReturnValueOnce(Effect.succeed(output("first contents\n")));
......@@ -680,7 +675,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
680675 mockedExecute.mockReturnValueOnce(
681676 Effect.succeed(
682677 output(
683 // @effect-diagnostics-next-line preferSchemaOverJson:off
684678 JSON.stringify({
685679 diff_refs: {
686680 base_sha: "a1b2c3d",
......@@ -718,7 +712,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
718712 mockedExecute.mockReturnValueOnce(
719713 Effect.succeed(
720714 output(
721 // @effect-diagnostics-next-line preferSchemaOverJson:off
722715 JSON.stringify({
723716 diff_refs: {
724717 base_sha: "a1b2c3d",
......@@ -758,7 +751,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
758751 mockedExecute.mockReturnValueOnce(
759752 Effect.succeed(
760753 output(
761 // @effect-diagnostics-next-line preferSchemaOverJson:off
762754 JSON.stringify({
763755 diff_refs: {
764756 base_sha: "a1b2c3d",
......@@ -823,7 +815,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
823815 it.effect("offers no squash when the project does not say it allows one", () =>
824816 Effect.gen(function* () {
825817 mockedExecute.mockReturnValueOnce(
826 // @effect-diagnostics-next-line preferSchemaOverJson:off
827818 Effect.succeed(output(JSON.stringify({ merge_method: "merge" }))),
828819 );
829820 const cli = yield* GitLabPullRequestCli.GitLabPullRequestCli;
......@@ -840,7 +831,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
840831 it.effect("reads the project's merge settings as its merge capabilities", () =>
841832 Effect.gen(function* () {
842833 mockedExecute.mockReturnValueOnce(
843 // @effect-diagnostics-next-line preferSchemaOverJson:off
844834 Effect.succeed(output(JSON.stringify({ merge_method: "ff", squash_option: "never" }))),
845835 );
846836 const cli = yield* GitLabPullRequestCli.GitLabPullRequestCli;
......@@ -884,7 +874,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
884874
885875 it.effect("fails when the authenticated account has no username", () =>
886876 Effect.gen(function* () {
887 // @effect-diagnostics-next-line preferSchemaOverJson:off
888877 mockedExecute.mockReturnValueOnce(Effect.succeed(output(JSON.stringify({ username: "" }))));
889878 const cli = yield* GitLabPullRequestCli.GitLabPullRequestCli;
890879
......@@ -935,7 +924,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
935924 mockedExecute.mockReturnValueOnce(
936925 Effect.succeed(
937926 output(
938 // @effect-diagnostics-next-line preferSchemaOverJson:off
939927 JSON.stringify([
940928 {
941929 id: "abc123",
......@@ -994,7 +982,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
994982 mockedExecute.mockReturnValueOnce(
995983 Effect.succeed(
996984 output(
997 // @effect-diagnostics-next-line preferSchemaOverJson:off
998985 JSON.stringify({
999986 iid: 7,
1000987 title: "t",
......@@ -1030,7 +1017,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
10301017 // The diff revisions first, because a positioned comment cannot be placed without them.
10311018 expect(argsOfCall(0)[1]).toContain("merge_requests/7");
10321019 expect(argsOfCall(1)[1]).toContain("/discussions");
1033 // @effect-diagnostics-next-line preferSchemaOverJson:off
10341020 expect(JSON.parse(callAt(1).stdin ?? "")).toEqual({
10351021 body: "why remove?",
10361022 position: {
......@@ -1086,7 +1072,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
10861072 expect(argsOfCall(0)).toContain("--method");
10871073 expect(argsOfCall(0)).toContain("PUT");
10881074 expect(argsOfCall(0)[1]).toContain("/discussions/abc123");
1089 // @effect-diagnostics-next-line preferSchemaOverJson:off
10901075 expect(JSON.parse(callAt(0).stdin ?? "")).toEqual({ resolved: true });
10911076 }),
10921077 );
......@@ -1117,13 +1102,11 @@ layer("GitLabPullRequestCli.layer", (it) => {
11171102 it.effect("removes an award by listing them and deleting the reader's own id", () =>
11181103 Effect.gen(function* () {
11191104 mockedExecute.mockReturnValueOnce(
1120 // @effect-diagnostics-next-line preferSchemaOverJson:off
11211105 Effect.succeed(output(JSON.stringify({ username: "bilal" }))),
11221106 );
11231107 mockedExecute.mockReturnValueOnce(
11241108 Effect.succeed(
11251109 output(
1126 // @effect-diagnostics-next-line preferSchemaOverJson:off
11271110 JSON.stringify([
11281111 { id: 5, name: "thumbsup", user: { username: "bilal" } },
11291112 { id: 6, name: "thumbsup", user: { username: "julius" } },
......@@ -1155,7 +1138,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
11551138 it.effect("does nothing when the reader has no award of that name to take back", () =>
11561139 Effect.gen(function* () {
11571140 mockedExecute.mockReturnValueOnce(
1158 // @effect-diagnostics-next-line preferSchemaOverJson:off
11591141 Effect.succeed(output(JSON.stringify({ username: "bilal" }))),
11601142 );
11611143 mockedExecute.mockReturnValueOnce(Effect.succeed(output("[]")));
......@@ -1179,7 +1161,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
11791161 mockedExecute.mockReturnValueOnce(
11801162 Effect.succeed(
11811163 output(
1182 // @effect-diagnostics-next-line preferSchemaOverJson:off
11831164 JSON.stringify({
11841165 iid: 7,
11851166 title: "t",
......@@ -1217,10 +1198,7 @@ layer("GitLabPullRequestCli.layer", (it) => {
12171198 mockedExecute
12181199 .mockReturnValueOnce(Effect.succeed(output(mergeRequestJson({ reviewers: [reviewer] }))))
12191200 .mockReturnValueOnce(
1220 Effect.succeed(
1221 // @effect-diagnostics-next-line preferSchemaOverJson:off
1222 output(JSON.stringify([author, reviewer, { id: 9, username: "hubot" }])),
1223 ),
1201 Effect.succeed(output(JSON.stringify([author, reviewer, { id: 9, username: "hubot" }]))),
12241202 );
12251203 const cli = yield* GitLabPullRequestCli.GitLabPullRequestCli;
12261204
......@@ -1258,7 +1236,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
12581236 // GitLab replaces the whole set, so the reviewer already on the merge request has to be
12591237 // sent back with the new one or the request would take them off it.
12601238 expect(argsOfCall(1)).toContain("PUT");
1261 // @effect-diagnostics-next-line preferSchemaOverJson:off
12621239 expect(JSON.parse(callAt(1).stdin ?? "")).toEqual({ reviewer_ids: [5, 9] });
12631240 }),
12641241 );
......@@ -1282,7 +1259,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
12821259 requested: false,
12831260 });
12841261
1285 // @effect-diagnostics-next-line preferSchemaOverJson:off
12861262 expect(JSON.parse(callAt(1).stdin ?? "")).toEqual({ reviewer_ids: [5] });
12871263 }),
12881264 );
......@@ -1303,7 +1279,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
13031279 });
13041280
13051281 // Sending it as a number would rewrite the reviewer set around something nobody chose.
1306 // @effect-diagnostics-next-line preferSchemaOverJson:off
13071282 expect(JSON.parse(callAt(1).stdin ?? "")).toEqual({ reviewer_ids: [5] });
13081283 }),
13091284 );
......@@ -1330,7 +1305,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
13301305 "--header",
13311306 "Content-Type: application/json",
13321307 ]);
1333 // @effect-diagnostics-next-line preferSchemaOverJson:off
13341308 expect(JSON.parse(callAt(0).stdin ?? "")).toEqual({ title: "A better title" });
13351309 }),
13361310 );
......@@ -1348,7 +1322,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
13481322 });
13491323
13501324 // A title sent as an empty string would wipe the one the merge request already has.
1351 // @effect-diagnostics-next-line preferSchemaOverJson:off
13521325 expect(JSON.parse(callAt(0).stdin ?? "")).toEqual({ description: "What this changes." });
13531326 }),
13541327 );
......@@ -1367,7 +1340,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
13671340 });
13681341
13691342 assert.strictEqual(mockedExecute.mock.calls.length, 1);
1370 // @effect-diagnostics-next-line preferSchemaOverJson:off
13711343 expect(JSON.parse(callAt(0).stdin ?? "")).toEqual({
13721344 title: "A better title",
13731345 description: "What this changes.",
......@@ -1407,7 +1379,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
14071379 mockedExecute.mockReturnValueOnce(
14081380 Effect.succeed(
14091381 output(
1410 // @effect-diagnostics-next-line preferSchemaOverJson:off
14111382 JSON.stringify({
14121383 iid: 7,
14131384 title: "t",
......@@ -1424,7 +1395,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
14241395 mockedExecute.mockReturnValueOnce(
14251396 Effect.succeed(
14261397 output(
1427 // @effect-diagnostics-next-line preferSchemaOverJson:off
14281398 JSON.stringify({
14291399 data: {
14301400 project: { repository: { blobs: { nodes: [{ path: "src/a.ts", oid: "aaa" }] } } },
......@@ -1449,7 +1419,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
14491419 ["src/gone.ts", ""],
14501420 ]);
14511421 // The head the reader is looking at, not whatever the source branch has moved on to.
1452 // @effect-diagnostics-next-line preferSchemaOverJson:off
14531422 const body: unknown = JSON.parse(callAt(1).stdin ?? "{}");
14541423 expect(body).toMatchObject({
14551424 variables: { fullPath: "acme/web", ref: "head", paths: ["src/a.ts", "src/gone.ts"] },
......@@ -1462,7 +1431,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
14621431 mockedExecute.mockReturnValueOnce(
14631432 Effect.succeed(
14641433 output(
1465 // @effect-diagnostics-next-line preferSchemaOverJson:off
14661434 JSON.stringify({
14671435 iid: 7,
14681436 title: "t",
......@@ -1480,10 +1448,7 @@ layer("GitLabPullRequestCli.layer", (it) => {
14801448 // these files, and reading it that way would report every file the reader has cleared as
14811449 // changed on nothing worse than a permission.
14821450 mockedExecute.mockReturnValueOnce(
1483 Effect.succeed(
1484 // @effect-diagnostics-next-line preferSchemaOverJson:off
1485 output(JSON.stringify({ data: { project: null } })),
1486 ),
1451 Effect.succeed(output(JSON.stringify({ data: { project: null } }))),
14871452 );
14881453 const cli = yield* GitLabPullRequestCli.GitLabPullRequestCli;
14891454
......@@ -1520,7 +1485,6 @@ layer("GitLabPullRequestCli.layer", (it) => {
15201485 mockedExecute.mockReturnValueOnce(
15211486 Effect.succeed(
15221487 output(
1523 // @effect-diagnostics-next-line preferSchemaOverJson:off
15241488 JSON.stringify({
15251489 iid: 7,
15261490 title: "t",
apps/server/src/serverSettings.test.ts+1-11
......@@ -578,7 +578,6 @@ it.layer(NodeServices.layer)("server settings", (it) => {
578578 const change = Option.getOrUndefined(yield* Stream.runHead(changes));
579579 const raw = yield* fileSystem.readFileString(serverConfig.settingsPath);
580580 // Inspect raw persisted JSON before schema decoding can apply defaults.
581 // @effect-diagnostics-next-line preferSchemaOverJson:off
582581 const persisted = JSON.parse(raw) as Record<string, unknown>;
583582
584583 assert.strictEqual(next.sidebarAutoSettleAfterDays, null);
......@@ -759,7 +758,6 @@ it.layer(NodeServices.layer)("server settings", (it) => {
759758
760759 const raw = yield* fileSystem.readFileString(serverConfig.settingsPath);
761760 assert.deepEqual(
762 // @effect-diagnostics-next-line preferSchemaOverJson:off
763761 JSON.parse(raw).sourceControlWriterModelSelection,
764762 sourceControlWriterModelSelection,
765763 );
......@@ -1046,7 +1044,6 @@ it.layer(NodeServices.layer)("server settings", (it) => {
10461044 assert.isFalse(settings.providers.grok.enabled);
10471045
10481046 const raw = yield* fileSystem.readFileString(serverConfig.settingsPath);
1049 // @effect-diagnostics-next-line preferSchemaOverJson:off
10501047 assert.isFalse(JSON.parse(raw).providers.grok.enabled);
10511048 }).pipe(Effect.provide(layerServerSettings())),
10521049 );
......@@ -1067,7 +1064,6 @@ it.layer(NodeServices.layer)("server settings", (it) => {
10671064 yield* serverSettings.updateSettings({ addProjectBaseDirectory: "~/Development" });
10681065
10691066 const raw = yield* fileSystem.readFileString(serverConfig.settingsPath);
1070 // @effect-diagnostics-next-line preferSchemaOverJson:off
10711067 const persisted = JSON.parse(raw);
10721068 assert.isTrue(persisted.providers.cursor.enabled);
10731069 assert.isTrue(persisted.providers.grok.enabled);
......@@ -1104,7 +1100,6 @@ it.layer(NodeServices.layer)("server settings", (it) => {
11041100 assert.isFalse(resolveProviderInstanceEnabled(grok));
11051101
11061102 const raw = yield* fileSystem.readFileString(serverConfig.settingsPath);
1107 // @effect-diagnostics-next-line preferSchemaOverJson:off
11081103 const persisted = JSON.parse(raw);
11091104 assert.isFalse(persisted.providers.cursor.enabled);
11101105 assert.isFalse(persisted.providers.grok.enabled);
......@@ -1288,7 +1283,6 @@ it.layer(NodeServices.layer)("server settings", (it) => {
12881283 assert.equal(next.providers.codex.binaryPath, "/opt/homebrew/bin/codex");
12891284
12901285 const raw = yield* fileSystem.readFileString(serverConfig.settingsPath);
1291 // @effect-diagnostics-next-line preferSchemaOverJson:off
12921286 assert.deepEqual(JSON.parse(raw), {
12931287 addProjectBaseDirectory: "~/Development",
12941288 observability: {
......@@ -1506,7 +1500,6 @@ it.layer(NodeServices.layer)("server settings", (it) => {
15061500
15071501 const raw = yield* fileSystem.readFileString(serverConfig.settingsPath);
15081502 assert.notInclude(raw, "sk-or-secret");
1509 // @effect-diagnostics-next-line preferSchemaOverJson:off
15101503 assert.deepEqual(JSON.parse(raw).providerInstances.codex_personal.environment, [
15111504 {
15121505 name: "OPENROUTER_API_KEY",
......@@ -1992,10 +1985,7 @@ it.layer(NodeServices.layer)("server settings", (it) => {
19921985 projectSettingsOverrides: { [legacyProject]: null },
19931986 });
19941987 const raw = yield* fileSystem.readFileString(serverConfig.settingsPath);
1995 const persisted = yield* decodeServerSettings(
1996 // @effect-diagnostics-next-line preferSchemaOverJson:off
1997 JSON.parse(raw),
1998 );
1988 const persisted = yield* decodeServerSettings(JSON.parse(raw));
19991989 assert.isTrue(persisted.projectSettingsFolded);
20001990 assert.isUndefined(persisted.projectSettingsOverrides[legacyProject]);
20011991 }).pipe(Effect.provide(layerServerSettings())),
apps/server/src/serviceLauncher.test.ts-3
......@@ -198,7 +198,6 @@ it.layer(NodeServices.layer)("service state persistence", (it) => {
198198 const databasePath = path.join(root, "userdata", "state.sqlite");
199199 yield* fs.makeDirectory(path.dirname(databasePath), { recursive: true });
200200 yield* fs.writeFileString(databasePath, "before trial");
201 // @effect-diagnostics-next-line preferSchemaOverJson:off - embeds a path in fake child source.
202201 const encodedDatabasePath = JSON.stringify(databasePath);
203202 const childSource = `
204203const context = JSON.parse(process.env.T3_SERVICE_LAUNCHER_CONTEXT);
......@@ -252,7 +251,6 @@ if (context.update?.status === "pending") {
252251 const databasePath = path.join(root, "userdata", "state.sqlite");
253252 yield* fs.makeDirectory(path.dirname(databasePath), { recursive: true });
254253 yield* fs.writeFileString(databasePath, "before trial");
255 // @effect-diagnostics-next-line preferSchemaOverJson:off - embeds a path in fake child source.
256254 const encodedDatabasePath = JSON.stringify(databasePath);
257255 const childSource = `
258256const context = JSON.parse(process.env.T3_SERVICE_LAUNCHER_CONTEXT);
......@@ -308,7 +306,6 @@ if (context.update?.status === "pending") {
308306 const original = "database before migration";
309307 yield* fs.makeDirectory(path.dirname(databasePath), { recursive: true });
310308 yield* fs.writeFileString(databasePath, original);
311 // @effect-diagnostics-next-line preferSchemaOverJson:off - embeds a path in fake child source.
312309 const encodedDatabasePath = JSON.stringify(databasePath);
313310 const childSource = `
314311import { writeFileSync } from "node:fs";
apps/server/src/sourceControl/AzureDevOpsCli.test.ts-5
......@@ -39,7 +39,6 @@ describe("AzureDevOpsCli.layer", () => {
3939 mockRun.mockReturnValueOnce(
4040 Effect.succeed(
4141 processOutput(
42 // @effect-diagnostics-next-line preferSchemaOverJson:off
4342 JSON.stringify({
4443 pullRequestId: 42,
4544 title: "Add Azure provider",
......@@ -97,7 +96,6 @@ describe("AzureDevOpsCli.layer", () => {
9796 mockRun.mockReturnValueOnce(
9897 Effect.succeed(
9998 processOutput(
100 // @effect-diagnostics-next-line preferSchemaOverJson:off
10199 JSON.stringify({
102100 pullRequestId: 863,
103101 title: "Fix Azure link",
......@@ -134,7 +132,6 @@ describe("AzureDevOpsCli.layer", () => {
134132 mockRun.mockReturnValueOnce(
135133 Effect.succeed(
136134 processOutput(
137 // @effect-diagnostics-next-line preferSchemaOverJson:off
138135 JSON.stringify([
139136 {
140137 pullRequestId: 7,
......@@ -195,7 +192,6 @@ describe("AzureDevOpsCli.layer", () => {
195192 mockRun.mockReturnValueOnce(
196193 Effect.succeed(
197194 processOutput(
198 // @effect-diagnostics-next-line preferSchemaOverJson:off
199195 JSON.stringify({
200196 name: "repo",
201197 webUrl: "https://dev.azure.com/acme/project/_git/repo",
......@@ -228,7 +224,6 @@ describe("AzureDevOpsCli.layer", () => {
228224 mockRun.mockReturnValueOnce(
229225 Effect.succeed(
230226 processOutput(
231 // @effect-diagnostics-next-line preferSchemaOverJson:off
232227 JSON.stringify({
233228 name: "repo",
234229 webUrl: "https://dev.azure.com/acme/project/_git/repo",
apps/server/src/sourceControl/BitbucketApi.test.ts-2
......@@ -541,7 +541,6 @@ it.effect("creates repositories through the Bitbucket REST API", () => {
541541 assert.ok(request);
542542 const rawBody = (request.body as { readonly body?: Uint8Array }).body;
543543 assert.ok(rawBody);
544 // @effect-diagnostics-next-line preferSchemaOverJson:off
545544 assert.deepStrictEqual(JSON.parse(new TextDecoder().decode(rawBody)), {
546545 scm: "git",
547546 is_private: true,
......@@ -577,7 +576,6 @@ it.effect("creates pull requests using the official REST payload shape", () => {
577576 assert.ok(request);
578577 const rawBody = (request.body as { readonly body?: Uint8Array }).body;
579578 assert.ok(rawBody);
580 // @effect-diagnostics-next-line preferSchemaOverJson:off
581579 assert.deepStrictEqual(JSON.parse(new TextDecoder().decode(rawBody)), {
582580 title: "Provider PR",
583581 description: "PR body",
apps/server/src/sourceControl/GitLabCli.test.ts+1-12
......@@ -39,7 +39,6 @@ layer("GitLabCli.layer", (it) => {
3939 mockedRun.mockReturnValueOnce(
4040 Effect.succeed(
4141 processOutput(
42 // @effect-diagnostics-next-line preferSchemaOverJson:off
4342 JSON.stringify({
4443 iid: 42,
4544 title: "Add MR thread creation",
......@@ -94,7 +93,6 @@ layer("GitLabCli.layer", (it) => {
9493 mockedRun.mockReturnValueOnce(
9594 Effect.succeed(
9695 processOutput(
97 // @effect-diagnostics-next-line preferSchemaOverJson:off
9896 JSON.stringify([
9997 {
10098 iid: 0,
......@@ -163,7 +161,6 @@ layer("GitLabCli.layer", (it) => {
163161 mockedRun.mockReturnValueOnce(
164162 Effect.succeed(
165163 processOutput(
166 // @effect-diagnostics-next-line preferSchemaOverJson:off
167164 JSON.stringify({
168165 path_with_namespace: "octocat/t3code",
169166 web_url: "https://gitlab.com/octocat/t3code",
......@@ -230,18 +227,10 @@ layer("GitLabCli.layer", (it) => {
230227 Effect.gen(function* () {
231228 mockedRun
232229
230 .mockReturnValueOnce(Effect.succeed(processOutput(JSON.stringify({ id: 1234 }))))
233231 .mockReturnValueOnce(
234232 Effect.succeed(
235233 processOutput(
236 // @effect-diagnostics-next-line preferSchemaOverJson:off
237 JSON.stringify({ id: 1234 }),
238 ),
239 ),
240 )
241 .mockReturnValueOnce(
242 Effect.succeed(
243 processOutput(
244 // @effect-diagnostics-next-line preferSchemaOverJson:off
245234 JSON.stringify({
246235 path_with_namespace: "octocat/t3code",
247236 web_url: "https://gitlab.com/octocat/t3code",
apps/server/src/textGeneration/ClaudeTextGeneration.test.ts-1
......@@ -367,7 +367,6 @@ it.layer(layerClaudeTextGenerationTest)("ClaudeTextGeneration", (it) => {
367367 const claudeConfigDir = path.join(process.cwd(), ".claude-work-test");
368368 return yield* withFakeClaudeEnv(
369369 {
370 // @effect-diagnostics-next-line preferSchemaOverJson:off
371370 output: JSON.stringify({
372371 structured_output: {
373372 title: "Use Claude home",
apps/server/src/vcs/VcsProjectConfig.test.ts-2
......@@ -42,7 +42,6 @@ describe("VcsProjectConfig", () => {
4242 yield* fileSystem.makeDirectory(nested, { recursive: true });
4343 yield* fileSystem.writeFileString(
4444 path.join(configDir, "vcs.json"),
45 // @effect-diagnostics-next-line preferSchemaOverJson:off
4645 JSON.stringify({ vcs: { kind: "jj" } }),
4746 );
4847
......@@ -72,7 +71,6 @@ describe("VcsProjectConfig", () => {
7271 yield* fileSystem.makeDirectory(configDir, { recursive: true });
7372 yield* fileSystem.writeFileString(
7473 path.join(configDir, "vcs.json"),
75 // @effect-diagnostics-next-line preferSchemaOverJson:off
7674 JSON.stringify({ vcs: { kind: "jj" } }),
7775 );
7876
apps/web/src/cloud/linkEnvironment.test.ts-4
......@@ -240,7 +240,6 @@ describe("web cloud link environment client", () => {
240240 "http://127.0.0.1:3000/api/connect/preferences",
241241 );
242242 expect(fetchMock.mock.calls[0]?.[1]?.method).toBe("POST");
243 // @effect-diagnostics-next-line preferSchemaOverJson:off
244243 expect(JSON.parse(bodyText(fetchMock.mock.calls[0]?.[1]?.body))).toEqual({
245244 publishAgentActivity: true,
246245 });
......@@ -290,7 +289,6 @@ describe("web cloud link environment client", () => {
290289 expect(String(fetchMock.mock.calls[1]?.[0])).toBe(
291290 "http://127.0.0.1:3000/api/connect/link-proof",
292291 );
293 // @effect-diagnostics-next-line preferSchemaOverJson:off
294292 expect(JSON.parse(bodyText(fetchMock.mock.calls[1]?.[1]?.body))).toMatchObject({
295293 challenge: "challenge",
296294 endpoint: {
......@@ -341,11 +339,9 @@ describe("web cloud link environment client", () => {
341339 }),
342340 );
343341
344 // @effect-diagnostics-next-line preferSchemaOverJson:off
345342 expect(JSON.parse(bodyText(fetchMock.mock.calls[0]?.[1]?.body))).toMatchObject({
346343 managedTunnelsEnabled: false,
347344 });
348 // @effect-diagnostics-next-line preferSchemaOverJson:off
349345 expect(JSON.parse(bodyText(fetchMock.mock.calls[1]?.[1]?.body))).toMatchObject({
350346 endpoint: { providerKind: "manual" },
351347 });
packages/client-runtime/src/state/pullRequestDiffHttp.test.ts-1
......@@ -71,7 +71,6 @@ describe("fetchEnvironmentPullRequestDiff", () => {
7171 : "";
7272 // The assertion deliberately inspects the serialized wire body rather than decoding a
7373 // domain value for use in application code.
74 // @effect-diagnostics-next-line preferSchemaOverJson:off
7574 expect(JSON.parse(body)).toEqual({
7675 projectId: "project-1",
7776 repository: "owner/repository",
tsconfig.base.json+7-1
......@@ -51,7 +51,13 @@
5151 "globalFetch": "error",
5252 "globalFetchInEffect": "error",
5353 "schemaNumber": "off"
54 }
54 },
55 "overrides": [
56 {
57 "include": ["**/*.test.ts", "**/*.test.tsx"],
58 "options": { "diagnosticSeverity": { "preferSchemaOverJson": "off" } }
59 }
60 ]
5561 }
5662 ]
5763 }