authorgravatar for 72638975+ohbentos@users.noreply.github.comohbentos <72638975+ohbentos@users.noreply.github.com> 2026-07-29 13:27:00-03:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2026-07-29 16:27:00+00:00
log85a89868703530e03c5e79797c7b952c684bd222
treecd64c067b0e2a79bb179da74dbfcd80f2cbeb61c
parentfaea70aebae41f1257140c6722f1d78f12f5eb74
signature Signed by PGP key B5690EEEBB952194

fix(git): disable external diff for review diff previews (#4854)

1 files changed, 18 insertions(+), 1 deletions(-)

apps/server/src/vcs/GitVcsDriverCore.ts+18-1
......@@ -2049,7 +2049,18 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
20492049 executeGit(
20502050 "GitVcsDriver.readUntrackedReviewDiffs.diff",
20512051 cwd,
2052 ["diff", "--no-index", "--patch", "--minimal", "--", "/dev/null", relativePath],
2052 [
2053 "diff",
2054 "--no-index",
2055 "--patch",
2056 "--no-color",
2057 "--no-ext-diff",
2058 "--no-textconv",
2059 "--minimal",
2060 "--",
2061 "/dev/null",
2062 relativePath,
2063 ],
20532064 {
20542065 allowNonZeroExit: true,
20552066 maxOutputBytes: REVIEW_UNTRACKED_DIFF_MAX_OUTPUT_BYTES,
......@@ -2094,6 +2105,9 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
20942105 [
20952106 "diff",
20962107 "--patch",
2108 "--no-color",
2109 "--no-ext-diff",
2110 "--no-textconv",
20972111 "--minimal",
20982112 ...(input.ignoreWhitespace ? ["--ignore-all-space"] : []),
20992113 "HEAD",
......@@ -2127,6 +2141,9 @@ export const makeGitVcsDriverCore = Effect.fn("makeGitVcsDriverCore")(function*
21272141 [
21282142 "diff",
21292143 "--patch",
2144 "--no-color",
2145 "--no-ext-diff",
2146 "--no-textconv",
21302147 "--minimal",
21312148 ...(input.ignoreWhitespace ? ["--ignore-all-space"] : []),
21322149 `${baseRef}...HEAD`,