authorgravatar for julius0216@outlook.comJulius Marminge <julius0216@outlook.com> 2026-09-02 22:59:46-07:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2026-09-02 22:59:46-07:00
log9f9359bd8132c425493720080149dcc0d3da9436
treef141565feece6066a04f8b543317c453ae4375df
parent854541a04e07b7960698b381bcfd2fda73eb276c
signature Signed by PGP key B5690EEEBB952194

fix(web): stop usage summary requests reporting slow RPCs (#9358)

2 files changed, 11 insertions(+), 1 deletions(-)

apps/web/src/rpc/requestLatencyState.test.ts+7
...@@ -59,6 +59,13 @@ describe("requestLatencyState", () => {...@@ -59,6 +59,13 @@ describe("requestLatencyState", () => {
59 expect(getSlowRpcAckRequests()).toEqual([]);59 expect(getSlowRpcAckRequests()).toEqual([]);
60 });60 });
6161
62 it("ignores usage summary requests", () => {
63 trackRpcRequestSent("1", WS_METHODS.serverGetUsageSummary);
64 vi.advanceTimersByTime(SLOW_RPC_ACK_THRESHOLD_MS * 2);
65
66 expect(getSlowRpcAckRequests()).toEqual([]);
67 });
68
62 it.each(Object.values(WS_METHODS).filter((method) => method.startsWith("pullRequests.")))(69 it.each(Object.values(WS_METHODS).filter((method) => method.startsWith("pullRequests.")))(
63 "ignores pull request workspace request %s",70 "ignores pull request workspace request %s",
64 (method) => {71 (method) => {
apps/web/src/rpc/requestLatencyState.ts+4-1
...@@ -28,7 +28,10 @@ interface PendingRpcAckRequest {...@@ -28,7 +28,10 @@ interface PendingRpcAckRequest {
28}28}
2929
30const pendingRpcAckRequests = new Map<string, PendingRpcAckRequest>();30const pendingRpcAckRequests = new Map<string, PendingRpcAckRequest>();
31const untrackedRpcAckMethods = new Set<string>([WS_METHODS.previewAutomationConnect]);31const untrackedRpcAckMethods = new Set<string>([
32 WS_METHODS.previewAutomationConnect,
33 WS_METHODS.serverGetUsageSummary,
34]);
32const longRunningRpcAckMethods = new Set<string>([35const longRunningRpcAckMethods = new Set<string>([
33 WS_METHODS.serverUpdateProvider,36 WS_METHODS.serverUpdateProvider,
34 WS_METHODS.serverRefreshProviders,37 WS_METHODS.serverRefreshProviders,