Commit ac3b2adf96e755580fc09e149b7c7eb057d0b282 | the-knife

author	Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com> 2026-08-29 04:47:04+05:30
committer	GitHub <noreply@github.com> 2026-08-29 04:47:04+05:30
log	ac3b2adf96e755580fc09e149b7c7eb057d0b282
tree	d6b637426f4e34fa8cd170c89bae190739387e40
parent	e898008959247befda6b5e6c40079cd6dee33cad
signature	Signed by PGP key B5690EEEBB952194

Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com>

3 files changed, 32 insertions(+), 3 deletions(-)

apps/web/src/components/chat/ChatComposer.tsx+8-1

...	...	@@ -90,7 +90,7 @@ import {
90	90	} from "../../lib/attachmentUploadState";
91	91	import { isCommandPaletteOpen } from "../../commandPaletteBus";
92	92	import { getTerminalFocusOwner } from "../../lib/terminalFocus";
93		import { resolveShortcutCommand } from "../../keybindings";
	93	import { resolveShortcutCommand, shortcutLabelForCommand } from "../../keybindings";
94	94	import {
95	95	type TerminalContextDraft,
96	96	type TerminalContextSelection,
...	...	@@ -3201,6 +3201,13 @@ export const ChatComposer = memo(function ChatComposer(props: ChatComposerProps)
3201	3201	<ComposerCommandMenuLayer anchor={composerMenuAnchor}>
3202	3202	<ComposerStashMenu
3203	3203	entries={stashQueue}
	3204	stashShortcutLabel={shortcutLabelForCommand(keybindings, "composer.stash", {
	3205	context: {
	3206	terminalFocus: false,
	3207	terminalOpen,
	3208	modelPickerOpen: false,
	3209	},
	3210	})}
3204	3211	onRestore={restoreStashEntry}
3205	3212	onDelete={deleteStashEntry}
3206	3213	onClose={() => setIsStashMenuOpen(false)}

apps/web/src/components/chat/ComposerStashMenu.test.tsx+18

...	...	@@ -8,6 +8,7 @@ describe("ComposerStashMenu", () => {
8	8	const markup = renderToStaticMarkup(
9	9	<ComposerStashMenu
10	10	entries={[]}
	11	stashShortcutLabel="Ctrl+S"
11	12	onRestore={() => {}}
12	13	onDelete={() => {}}
13	14	onClose={() => {}}
...	...	@@ -20,6 +21,22 @@ describe("ComposerStashMenu", () => {
20	21	expect(markup).toContain('aria-label="Close stash"');
21	22	expect(markup).not.toContain("dropdown-glass");
22	23	expect(markup).not.toContain("Stashed prompts");
	24	expect(markup).toContain("Press Ctrl+S with a prompt in the composer to stash it.");
	25	});
	26
	27	it("does not advertise a shortcut when stash is unbound", () => {
	28	const markup = renderToStaticMarkup(
	29	<ComposerStashMenu
	30	entries={[]}
	31	stashShortcutLabel={null}
	32	onRestore={() => {}}
	33	onDelete={() => {}}
	34	onClose={() => {}}
	35	/>,
	36	);
	37
	38	expect(markup).toContain("Nothing stashed yet.");
	39	expect(markup).not.toContain("Press");
23	40	});
24	41
25	42	it("shows saved image thumbnails and incomplete image states", () => {
...	...	@@ -53,6 +70,7 @@ describe("ComposerStashMenu", () => {
53	70	pendingImageCount: 1,
54	71	},
55	72	]}
	73	stashShortcutLabel="Ctrl+S"
56	74	onRestore={() => {}}
57	75	onDelete={() => {}}
58	76	onClose={() => {}}

apps/web/src/components/chat/ComposerStashMenu.tsx+6-2

...	...	@@ -31,11 +31,12 @@ function stashEntrySnippet(entry: PromptStashEntry): string {
31	31	*/
32	32	export const ComposerStashMenu = memo(function ComposerStashMenu(props: {
33	33	entries: ReadonlyArray<PromptStashEntry>;
	34	stashShortcutLabel: string \| null;
34	35	onRestore: (entry: PromptStashEntry) => void;
35	36	onDelete: (entry: PromptStashEntry) => void;
36	37	onClose: () => void;
37	38	}) {
38		const { entries, onRestore, onDelete, onClose } = props;
	39	const { entries, stashShortcutLabel, onRestore, onDelete, onClose } = props;
39	40	const drawerRef = useRef<HTMLDivElement>(null);
40	41	const [highlightedId, setHighlightedId] = useState<string \| null>(entries[0]?.id ?? null);
41	42
...	...	@@ -128,7 +129,10 @@ export const ComposerStashMenu = memo(function ComposerStashMenu(props: {
128	129	<CommandGroup>
129	130	{entries.length === 0 ? (
130	131	<p className="px-3 py-1.5 text-secondary-label text-xs">
131		Nothing stashed yet. Press ⌘S with a prompt in the composer to stash it.
	132	Nothing stashed yet.
	133	{stashShortcutLabel
	134	? ` Press ${stashShortcutLabel} with a prompt in the composer to stash it.`
	135	: null}
132	136	</p>
133	137	) : (
134	138	entries.map((entry) => (