Commit b125b7635170ec0c33f8ddf39299155a21f8c9b9 | the-knife

author	Max Katz <me@maxkatz.me> 2026-07-30 06:35:53+04:00
committer	GitHub <noreply@github.com> 2026-07-29 22:35:53-04:00
log	b125b7635170ec0c33f8ddf39299155a21f8c9b9
tree	ddf97e570a0d90db4b12d03c1c980954c8bbd2f8
parent	758decaa565f021f85af756669b18bd9f80cacf5
signature	Signed by PGP key B5690EEEBB952194

fix(composer): hide default Codex service tier (#4784)

2 files changed, 33 insertions(+), 5 deletions(-)

apps
- web
  - src
    components
    chat
    TraitsPicker.test.ts
    TraitsPicker.tsx

apps/web/src/components/chat/TraitsPicker.test.ts+19-5

 @@ -1,10 +1,10 @@
 import { describe, expect, it } from "vite-plus/test";
-import type { ProviderOptionDescriptor } from "@t3tools/contracts";
+import { ProviderDriverKind, type ProviderOptionDescriptor } from "@t3tools/contracts";
 import { buildTraitsTriggerDisplay } from "./TraitsPicker";
 function selectDescriptor(
   id: string,
-  options: ReadonlyArray<{ id: string; label: string }>,
+  options: ReadonlyArray<{ id: string; label: string; isDefault?: boolean }>,
   currentValue: string,
 ): Extract<ProviderOptionDescriptor, { type: "select" }> {
   return { id, label: id, type: "select", options: [...options], currentValue };
 @@ -17,7 +17,7 @@ function fastModeDescriptor(
 }
 const EFFORT = selectDescriptor(
-  "effort",
+  "reasoningEffort",
   [
     { id: "high", label: "High" },
     { id: "max", label: "Max" },
 @@ -33,10 +33,13 @@ const CONTEXT_WINDOW = selectDescriptor(
   "1m",
 );
+const CODEX = ProviderDriverKind.make("codex");
 function display(descriptors: ReadonlyArray<ProviderOptionDescriptor>, fastModeEnabled: boolean) {
   return buildTraitsTriggerDisplay({
+    provider: CODEX,
     descriptors,
-    primarySelectDescriptorId: "effort",
+    primarySelectDescriptorId: "reasoningEffort",
     ultrathinkPromptControlled: false,
     fastModeEnabled,
   });
 @@ -57,6 +60,16 @@ describe("buildTraitsTriggerDisplay", () => {
     });
   });
+  it("omits Codex's default Standard tier beside reasoning", () => {
+    const serviceTier = selectDescriptor(
+      "serviceTier",
+      [{ id: "default", label: "Standard", isDefault: true }],
+      "default",
+    );
+    expect(display([EFFORT, serviceTier], false).label).toBe("High");
+  });
   it("keeps non-fastMode booleans as text labels", () => {
     const thinking: Extract<ProviderOptionDescriptor, { type: "boolean" }> = {
       id: "thinking",
 @@ -100,8 +113,9 @@ describe("buildTraitsTriggerDisplay", () => {
   it("still renders the prompt-controlled ultrathink label alongside the bolt", () => {
     expect(
       buildTraitsTriggerDisplay({
+        provider: CODEX,
         descriptors: [EFFORT, fastModeDescriptor(true)],
-        primarySelectDescriptorId: "effort",
+        primarySelectDescriptorId: "reasoningEffort",
         ultrathinkPromptControlled: true,
         fastModeEnabled: true,
       }),

apps/web/src/components/chat/TraitsPicker.tsx+14

 @@ -388,6 +388,7 @@ export const TraitsMenuContent = memo(function TraitsMenuContentImpl({
  * chevron) would leave the trigger unreadable.
  */
 export function buildTraitsTriggerDisplay(input: {
+  provider: ProviderDriverKind;
   descriptors: ReadonlyArray<ProviderOptionDescriptor>;
   primarySelectDescriptorId: string | null;
   ultrathinkPromptControlled: boolean;
 @@ -400,6 +401,18 @@ export function buildTraitsTriggerDisplay(input: {
       hasFastMode = true;
       continue;
     }
+    if (
+      input.provider === "codex" &&
+      descriptor.id === "serviceTier" &&
+      descriptor.type === "select" &&
+      input.descriptors.some(({ id }) => id === "reasoningEffort")
+    ) {
+      const currentValue = getProviderOptionCurrentValue(descriptor);
+      const currentOption = descriptor.options.find((option) => option.id === currentValue);
+      if (currentOption?.id === "default" && currentOption.isDefault === true) {
+        continue;
+      }
+    }
     const label =
       input.ultrathinkPromptControlled && descriptor.id === input.primarySelectDescriptorId
         ? "Ultrathink"
 @@ -457,6 +470,7 @@ export const TraitsPicker = memo(function TraitsPicker({
   }
   const { label: triggerLabel, showFastModeIcon } = buildTraitsTriggerDisplay({
+    provider,
     descriptors,
     primarySelectDescriptorId: primarySelectDescriptor?.id ?? null,
     ultrathinkPromptControlled,