Commit b5149f595962b51bf237a4de4a43e3cd4e450272 | the-knife

author	Julius Marminge <julius0216@outlook.com> 2026-02-14 23:04:34-08:00
committer	Julius Marminge <jmarminge@gmail.com> 2026-02-14 23:35:48-08:00
log	b5149f595962b51bf237a4de4a43e3cd4e450272
tree	3064793777c7bb1359d19c782e08f80293440d9a
parent	ea661fb635f66860d4c03e2c518bc29db2383d68

Close git action toast before triggering follow-up action

- Dismiss the success toast before handling Push/Open PR/Create PR CTA clicks
- Prevent stale result toasts from lingering while starting the next git action

1 files changed, 15 insertions(+), 3 deletions(-)

apps
- web
  - src
    components
    GitActionsControl.tsx

apps/web/src/components/GitActionsControl.tsx+15-3

 @@ -271,6 +271,9 @@ export default function GitActionsControl({ api, gitCwd }: GitActionsControlProp
           (action === "commit_push" || action === "commit_push_pr") && !!prUrl;
         const shouldOfferCreatePrCta =
           action === "commit_push" && !prUrl && result.push.status === "pushed";
+        const closeResultToast = () => {
+          toastManager.close(progressToastId);
+        };
         toastManager.update(progressToastId, {
           type: "success",
 @@ -281,21 +284,30 @@ export default function GitActionsControl({ api, gitCwd }: GitActionsControlProp
             ? {
                 actionProps: {
                   children: "Push",
-                  onClick: () => void runGitActionWithToast({ action: "commit_push" }),
+                  onClick: () => {
+                    closeResultToast();
+                    void runGitActionWithToast({ action: "commit_push" });
+                  },
                 },
               }
             : shouldOfferOpenPrCta
               ? {
                   actionProps: {
                     children: "Open PR",
-                    onClick: () => void api?.shell.openExternal(prUrl),
+                    onClick: () => {
+                      closeResultToast();
+                      void api?.shell.openExternal(prUrl);
+                    },
                   },
                 }
               : shouldOfferCreatePrCta
                 ? {
                     actionProps: {
                       children: "Create PR",
-                      onClick: () => setActiveDialogAction("create_pr"),
+                      onClick: () => {
+                        closeResultToast();
+                        setActiveDialogAction("create_pr");
+                      },
                     },
                   }
                 : {}),