Commit b6eefc926ae305f4cb85cca797668b010cee1136 | the-knife

author	Theo Browne <me@t3.gg> 2026-09-25 20:28:03-07:00
committer	GitHub <noreply@github.com> 2026-09-25 20:28:03-07:00
log	b6eefc926ae305f4cb85cca797668b010cee1136
tree	d33d8a5d048d3401f1f47130d0da4073cb96524e
parent	574b18090281225de3449816c8366f0ee9ab886c
signature	Signed by PGP key B5690EEEBB952194

perf(server): build the thread list snapshot without decoding it twice (#13693)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

1 files changed, 8 insertions(+), 22 deletions(-)

apps
- server
  - src
    orchestration
    Layers
    ProjectionSnapshotQuery.ts

apps/server/src/orchestration/Layers/ProjectionSnapshotQuery.ts+8-22

 @@ -12,7 +12,7 @@ import {
   OrchestrationProposedPlanId,
   OrchestrationReadModel,
   OrchestrationThreadSearchSource,
-  OrchestrationShellSnapshot,
+  type OrchestrationShellSnapshot,
   OrchestrationThread,
   OrchestrationThreadDetailSnapshot,
   ProjectScript,
 @@ -82,7 +82,6 @@ import {
 } from "../Services/ProjectionSnapshotQuery.ts";
 const decodeReadModel = Schema.decodeUnknownEffect(OrchestrationReadModel);
-const decodeShellSnapshot = Schema.decodeUnknownEffect(OrchestrationShellSnapshot);
 const decodeThread = Schema.decodeUnknownEffect(OrchestrationThread);
 const decodeImportedTranscriptsPayload = Schema.decodeUnknownOption(
   Schema.fromJsonString(
 @@ -2746,7 +2745,10 @@ pending_approval_requests AS (
               );
               const pullRequestsByThread = groupPullRequestRowsByThread(pullRequestRows);
-              const snapshot = {
+              // Built from schema-decoded rows, so no second decode here. The HTTP
+              // and RPC layers encode it against OrchestrationShellSnapshot on the
+              // way out, like the per-item shells from getThreadShellById.
+              return {
                 snapshotSequence: computeSnapshotSequence(stateRows),
                 projects: Arr.filterMap(projectRows, (row) =>
                   row.deletedAt === null
 @@ -2800,15 +2802,7 @@ pending_approval_requests AS (
                     : Result.failVoid,
                 ),
                 updatedAt: updatedAt ?? "1970-01-01T00:00:00.000Z",
-              };
+              } satisfies OrchestrationShellSnapshot;
-              return yield* decodeShellSnapshot(snapshot).pipe(
-                Effect.mapError(
-                  toPersistenceDecodeError(
-                    "ProjectionSnapshotQuery.getShellSnapshot:decodeShellSnapshot",
-                  ),
-                ),
-              );
             }),
         ),
         Effect.mapError((error) => {
 @@ -2941,7 +2935,7 @@ pending_approval_requests AS (
                 sessionRows.map((row) => [row.threadId, mapSessionRow(row)] as const),
               );
-              const snapshot = {
+              return {
                 snapshotSequence: computeSnapshotSequence(stateRows),
                 projects: Arr.filterMap(projectRows, (row) =>
                   row.deletedAt === null && activeProjectIds.has(row.projectId)
 @@ -2991,15 +2985,7 @@ pending_approval_requests AS (
                   planProgress: threadPlanProgress.getThreadPlanProgress(row.threadId),
                 })),
                 updatedAt: updatedAt ?? "1970-01-01T00:00:00.000Z",
-              };
+              } satisfies OrchestrationShellSnapshot;
-              return yield* decodeShellSnapshot(snapshot).pipe(
-                Effect.mapError(
-                  toPersistenceDecodeError(
-                    "ProjectionSnapshotQuery.getArchivedShellSnapshot:decodeShellSnapshot",
-                  ),
-                ),
-              );
             }),
         ),
         Effect.mapError((error) => {