Commit bc2748241776066c532f3312a26f1756d9740f9c | the-knife

1 files changed, 13 insertions(+), 2 deletions(-)

apps/web/src/components/settings/FontFamilyPicker.tsx+13-2

 @@ -12,6 +12,7 @@ import {
   ComboboxTrigger,
 } from "../ui/combobox";
 import { SelectButton } from "../ui/select";
+import { stackedThreadToast, toastManager } from "../ui/toast";
 const DEFAULT_FONT_VALUE = "__default__";
 @@ -141,8 +142,8 @@ export function FontFamilyPicker({
   const families = useMemo(() => {
     if (enumeration.status !== "granted") return [];
-    return requireMonospace ? enumeration.families.filter(isMonospaceFamily) : enumeration.families;
+    return enumeration.families;
-  }, [enumeration, requireMonospace]);
+  }, [enumeration]);
   const items = useMemo(() => {
     const trimmedQuery = query.trim().toLowerCase();
 @@ -160,6 +161,16 @@ export function FontFamilyPicker({
   const handlePick = (value: string) => {
     setOpen(false);
+    if (value !== DEFAULT_FONT_VALUE && requireMonospace && !isMonospaceFamily(value)) {
+      toastManager.add(
+        stackedThreadToast({
+          type: "error",
+          title: `"${value}" isn't monospace`,
+          description: "Code and terminal need a fixed-width font, so the current font was kept.",
+        }),
+      );
+      return;
+    }
     onSelect(value === DEFAULT_FONT_VALUE ? "" : value);
   };