authorgravatar for 80079528+sheehanmunim@users.noreply.github.comSheehan Munim <80079528+sheehanmunim@users.noreply.github.com> 2026-10-11 01:49:25-05:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2026-10-11 01:49:25-05:00
logcf821991863d5e374f698cb45bcef4759d3a0b7f
tree7980a2082ffba789abdb86c977e8f9a70d3dd547
parent78089500e40e9d0ce6e9c1610e52f9c0d656a673
signature Signed by PGP key B5690EEEBB952194

test(server): ACP teardown tests pass on Windows hosts (#17080)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Yash Singh <saiansh2525@gmail.com>

1 files changed, 6 insertions(+), 1 deletions(-)

apps/server/src/orchestration-v2/Adapters/AcpAdapterV2.test.ts+6-1
...@@ -12316,7 +12316,11 @@ describe("AcpAdapterV2", () => {...@@ -12316,7 +12316,11 @@ describe("AcpAdapterV2", () => {
12316 });12316 });
12317 assert.equal(taskkillCommands.length, 1);12317 assert.equal(taskkillCommands.length, 1);
12318 yield* Scope.close(runtimeScope, Exit.void);12318 yield* Scope.close(runtimeScope, Exit.void);
12319 assert.equal(taskkillCommands.length, 1);12319 // The scope finalizer picks its kill path from the host, not processGroupPlatform,
12320 // so only a Windows host sends it through taskkill a second time.
12321 const finalizerTaskkills = (yield* HostProcess.Platform) === "win32" ? 1 : 0;
12322 assert.equal(taskkillCommands.length, 1 + finalizerTaskkills);
12323 assert.deepEqual(taskkillCommands.at(-1), taskkillCommands[0]);
12320 }).pipe(Effect.provide(layerTest)),12324 }).pipe(Effect.provide(layerTest)),
12321 );12325 );
1232212326
...@@ -12433,6 +12437,7 @@ describe("AcpAdapterV2", () => {...@@ -12433,6 +12437,7 @@ describe("AcpAdapterV2", () => {
1243312437
12434 it.live("poisons the session when hard teardown defects and blocks replacement work", () =>12438 it.live("poisons the session when hard teardown defects and blocks replacement work", () =>
12435 Effect.gen(function* () {12439 Effect.gen(function* () {
12440 if ((yield* HostProcess.Platform) !== "linux") return;
12436 const childProcessSpawner = yield* ChildProcessSpawner.ChildProcessSpawner;12441 const childProcessSpawner = yield* ChildProcessSpawner.ChildProcessSpawner;
12437 const fileSystem = yield* FileSystem.FileSystem;12442 const fileSystem = yield* FileSystem.FileSystem;
12438 const idAllocator = yield* IdAllocator.IdAllocatorV2;12443 const idAllocator = yield* IdAllocator.IdAllocatorV2;