authorgravatar for julius0216@outlook.comJulius Marminge <julius0216@outlook.com> 2026-09-05 00:02:19-07:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2026-09-05 00:02:19-07:00
logdfc70a3294641a2acb021766a759ac4c79665944
tree864fd3001a4c2b65b2c8fd39737bec09187607ef
parentd2c3e2e5d7360b5d87f7516bdbce46b5c5444ef4
signature Signed by PGP key B5690EEEBB952194

test(contracts): keep driver default lookup private (#9968)

2 files changed, 5 insertions(+), 10 deletions(-)

packages/contracts/src/settings.test.ts+4-9
...@@ -7,7 +7,6 @@ import {...@@ -7,7 +7,6 @@ import {
7 ClientSettingsPatch,7 ClientSettingsPatch,
8 ClaudeSettings,8 ClaudeSettings,
9 DEFAULT_SERVER_SETTINGS,9 DEFAULT_SERVER_SETTINGS,
10 defaultEnabledForDriver,
11 resolveProviderInstanceEnabled,10 resolveProviderInstanceEnabled,
12 ServerSettings,11 ServerSettings,
13 ServerSettingsPatch,12 ServerSettingsPatch,
...@@ -432,14 +431,6 @@ describe("provider enabled defaults", () => {...@@ -432,14 +431,6 @@ describe("provider enabled defaults", () => {
432 expect(decoded.providers.opencode.enabled).toBe(false);431 expect(decoded.providers.opencode.enabled).toBe(false);
433 });432 });
434433
435 it("derives per-driver defaults from the settings schemas", () => {
436 expect(defaultEnabledForDriver(ProviderDriverKind.make("codex"))).toBe(true);
437 expect(defaultEnabledForDriver(ProviderDriverKind.make("cursor"))).toBe(false);
438 expect(defaultEnabledForDriver(ProviderDriverKind.make("grok"))).toBe(false);
439 // Unknown fork drivers stay enabled; their own build decides otherwise.
440 expect(defaultEnabledForDriver(ProviderDriverKind.make("ollama"))).toBe(true);
441 });
442
443 it("keeps Cursor enabled when an existing user explicitly opted in", () => {434 it("keeps Cursor enabled when an existing user explicitly opted in", () => {
444 const cursor = ProviderDriverKind.make("cursor");435 const cursor = ProviderDriverKind.make("cursor");
445 const cursorId = ProviderInstanceId.make("cursor");436 const cursorId = ProviderInstanceId.make("cursor");
...@@ -460,6 +451,10 @@ describe("provider enabled defaults", () => {...@@ -460,6 +451,10 @@ describe("provider enabled defaults", () => {
460 // No flags anywhere: driver default applies.451 // No flags anywhere: driver default applies.
461 expect(resolveProviderInstanceEnabled({ driver: grok, config: {} })).toBe(false);452 expect(resolveProviderInstanceEnabled({ driver: grok, config: {} })).toBe(false);
462 expect(resolveProviderInstanceEnabled({ driver: codex, config: {} })).toBe(true);453 expect(resolveProviderInstanceEnabled({ driver: codex, config: {} })).toBe(true);
454 // Unknown fork drivers stay enabled.
455 expect(
456 resolveProviderInstanceEnabled({ driver: ProviderDriverKind.make("ollama"), config: {} }),
457 ).toBe(true);
463 // Envelope flag wins over the driver default.458 // Envelope flag wins over the driver default.
464 expect(resolveProviderInstanceEnabled({ driver: grok, enabled: true, config: {} })).toBe(true);459 expect(resolveProviderInstanceEnabled({ driver: grok, enabled: true, config: {} })).toBe(true);
465 expect(resolveProviderInstanceEnabled({ driver: codex, enabled: false, config: {} })).toBe(460 expect(resolveProviderInstanceEnabled({ driver: codex, enabled: false, config: {} })).toBe(
packages/contracts/src/settings.ts+1-1
...@@ -975,7 +975,7 @@ export const providerInstanceConfigEnabledFlag = (config: unknown): boolean | un...@@ -975,7 +975,7 @@ export const providerInstanceConfigEnabledFlag = (config: unknown): boolean | un
975 * through `DEFAULT_SERVER_SETTINGS`, so the schema's decoding default stays975 * through `DEFAULT_SERVER_SETTINGS`, so the schema's decoding default stays
976 * the single source of truth. Unknown (fork) drivers default to enabled.976 * the single source of truth. Unknown (fork) drivers default to enabled.
977 */977 */
978export const defaultEnabledForDriver = (driver: ProviderDriverKind): boolean => {978const defaultEnabledForDriver = (driver: ProviderDriverKind): boolean => {
979 const legacyDefaults = DEFAULT_SERVER_SETTINGS.providers as Record<979 const legacyDefaults = DEFAULT_SERVER_SETTINGS.providers as Record<
980 string,980 string,
981 { readonly enabled?: boolean } | undefined981 { readonly enabled?: boolean } | undefined