authorgravatar for julius0216@outlook.comJulius Marminge <julius0216@outlook.com> 2026-08-30 22:43:19-07:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2026-08-30 22:43:19-07:00
loge9c4775e8738381140af4e5248507b15fc1cd491
tree9b63e603605a98a64f013186365cd83d0103fdf9
parent3958111057c10c10350dd9c20ec2a2df00f504be
signature Signed by PGP key B5690EEEBB952194

fix(web): mark pull request links as external (#8856)

1 files changed, 5 insertions(+), 2 deletions(-)

apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx+5-2
...@@ -16,6 +16,7 @@ import {...@@ -16,6 +16,7 @@ import {
16 BookOpenIcon,16 BookOpenIcon,
17 CircleDotIcon,17 CircleDotIcon,
18 ChevronDownIcon,18 ChevronDownIcon,
19 ExternalLinkIcon,
19 FileDiffIcon,20 FileDiffIcon,
20 FolderGit2Icon,21 FolderGit2Icon,
21 GitBranchIcon,22 GitBranchIcon,
...@@ -1161,12 +1162,13 @@ export function PullRequestDetailPanel({...@@ -1161,12 +1162,13 @@ export function PullRequestDetailPanel({
1161 onClick={() => void readLocalApi()?.shell.openExternal(detail.url)}1162 onClick={() => void readLocalApi()?.shell.openExternal(detail.url)}
1162 onContextMenu={(event) => openNumberContextMenu(event, detail)}1163 onContextMenu={(event) => openNumberContextMenu(event, detail)}
1163 className={cn(1164 className={cn(
1164 "shrink-0 font-medium underline-offset-2 hover:underline",1165 "inline-flex shrink-0 cursor-pointer items-center gap-0.5 font-medium underline-offset-2 hover:underline",
1165 statePresentation.toneClassName,1166 statePresentation.toneClassName,
1166 )}1167 )}
1167 aria-label={`Open pull request #${detail.number} on host`}1168 aria-label={`Open pull request #${detail.number} on host`}
1168 >1169 >
1169 #{detail.number}1170 #{detail.number}
1171 <ExternalLinkIcon aria-hidden className="size-2.5" />
1170 </button>1172 </button>
1171 }1173 }
1172 />1174 />
...@@ -1196,12 +1198,13 @@ export function PullRequestDetailPanel({...@@ -1196,12 +1198,13 @@ export function PullRequestDetailPanel({
1196 onClick={() => void readLocalApi()?.shell.openExternal(detail.url)}1198 onClick={() => void readLocalApi()?.shell.openExternal(detail.url)}
1197 onContextMenu={(event) => openNumberContextMenu(event, detail)}1199 onContextMenu={(event) => openNumberContextMenu(event, detail)}
1198 className={cn(1200 className={cn(
1199 "shrink-0 font-medium underline-offset-2 hover:underline",1201 "inline-flex shrink-0 cursor-pointer items-center gap-0.5 font-medium underline-offset-2 hover:underline",
1200 statePresentation.toneClassName,1202 statePresentation.toneClassName,
1201 )}1203 )}
1202 aria-label={`Open pull request #${detail.number} on host`}1204 aria-label={`Open pull request #${detail.number} on host`}
1203 >1205 >
1204 #{detail.number}1206 #{detail.number}
1207 <ExternalLinkIcon aria-hidden className="size-2.5" />
1205 </button>1208 </button>
1206 }1209 }
1207 />1210 />