Commit ec44bc56f598be16ffbc22ed0e4e095447043844 | the-knife

author	maria <maria@kuuro.net> 2026-09-02 22:39:09-04:00
committer	GitHub <noreply@github.com> 2026-09-02 22:39:09-04:00
log	ec44bc56f598be16ffbc22ed0e4e095447043844
tree	e125223869b0e3345d20bc620b3ba6b9b33fa5f2
parent	922bd692251bc803c12a3fab159efe83c957bb70
signature	Signed by PGP key B5690EEEBB952194

fix(chat): keep live tool labels in present tense (#9316)

Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>

8 files changed, 54 insertions(+), 37 deletions(-)

apps
- mobile
  - src
    lib
    threadActivity.test.ts
    threadActivity.ts
- web
  - src
    components
    chat
    MessagesTimeline.logic.test.ts
    MessagesTimeline.logic.ts
    MessagesTimeline.test.tsx
docs
- user
  - tool-activity.md
packages
- client-runtime
  - src
    work-log
    presentation.test.ts
    presentation.ts

apps/mobile/src/lib/threadActivity.test.ts+8-6

 @@ -868,7 +868,7 @@ describe("buildThreadFeed", () => {
       title: "Call MCP tool",
       item: { server: "t3-code", tool: "preview_click" },
       status: undefined,
-      displayName: "Click in the preview browser",
+      displayName: "Clicking in the preview browser",
       liveDisplayName: "Clicking in the preview browser",
       settledDisplayName: "Clicked in the preview browser",
       icon: "browser",
 @@ -879,7 +879,7 @@ describe("buildThreadFeed", () => {
       title: "Call MCP tool",
       item: { server: "t3-code", tool: "task_status" },
       status: undefined,
-      displayName: "Get delegated task status",
+      displayName: "Getting delegated task status",
       liveDisplayName: "Getting delegated task status",
       settledDisplayName: "Got delegated task status",
       icon: "t3-code",
 @@ -1039,7 +1039,7 @@ describe("buildThreadFeed", () => {
     ).toMatchObject([
       {
         type: "work-toggle",
-        summary: "Clicked in the preview browser",
+        summary: "Clicking in the preview browser",
         summaryToolIcon: "browser",
         live: true,
       },
 @@ -1050,18 +1050,20 @@ describe("buildThreadFeed", () => {
     {
       status: "completed",
       displayName: "Clicked in the preview browser",
+      liveDisplayName: "Clicking in the preview browser",
       detail: "Clicked Continue",
       hasFailure: false,
     },
     {
       status: "failed",
       displayName: "Failed to click in the preview browser",
+      liveDisplayName: "Failed to click in the preview browser",
       detail: "Timed out waiting for Continue",
       hasFailure: true,
     },
   ])(
     "uses the browser call label once its action settles as $status",
-    ({ status, displayName, detail, hasFailure }) => {
+    ({ status, displayName, liveDisplayName, detail, hasFailure }) => {
       const turnId = TurnId.make("turn-preview-lifecycle");
       const toolCallId = "preview-click";
       const groupId = `work-group:tool:${turnId}:${toolCallId}`;
 @@ -1156,7 +1158,7 @@ describe("buildThreadFeed", () => {
           groupId,
           hiddenCount: 1,
           expanded: true,
-          summary: displayName,
+          summary: liveDisplayName,
           summaryToolIcon: "browser",
           hasFailure,
           live: true,
 @@ -1677,7 +1679,7 @@ describe("buildThreadFeed", () => {
       (
         [
           { lifecycleStatus: "inProgress", summary: "Running pnpm", shimmer: true },
-          { lifecycleStatus: "completed", summary: "Ran pnpm", shimmer: false },
+          { lifecycleStatus: "completed", summary: "Running pnpm", shimmer: false },
           { lifecycleStatus: "failed", summary: "Failed pnpm", shimmer: false },
           { lifecycleStatus: "declined", summary: "Declined pnpm", shimmer: false },
           { lifecycleStatus: "stopped", summary: "Stopped pnpm", shimmer: false },

apps/mobile/src/lib/threadActivity.ts+8-7

 @@ -17,6 +17,7 @@ import {
   commandDetailRepeatsCommand,
   extractCommandOutputText,
   isWorktreeSetupActivity,
+  liveActivityToolStatus,
   normalizeCompactToolLabel,
   omitSupersededLifecycleMarkers,
   resolveWorkEntryToolPresentation,
 @@ -1528,7 +1529,7 @@ function appendToolGroupRows(
   const latestActivity = latestActiveActivity ?? activities.at(-1)!;
   const singleActivity = activities.length === 1 ? latestActivity : null;
   const summary = live
-    ? liveToolActivitySummary(latestActivity, active)
+    ? liveToolActivitySummary(latestActivity, live)
     : singleActivity !== null &&
         singleActivity.toolLike &&
         toolGroupAction(singleActivity.workEntry) !== "edit"
 @@ -1580,16 +1581,16 @@ function appendToolGroupRows(
   });
 }
-function liveToolActivitySummary(activity: ThreadFeedActivity, active: boolean): string {
+function liveToolActivitySummary(activity: ThreadFeedActivity, presentTense: boolean): string {
-  const presentation = resolveWorkEntryToolPresentation(
+  const status = liveActivityToolStatus(activity.lifecycleStatus, presentTense);
-    activity.workEntry,
+  const presentation = resolveWorkEntryToolPresentation({
-    active ? "inProgress" : "completed",
+    ...activity.workEntry,
-  );
+    toolLifecycleStatus: status,
+  });
   if (presentation) return presentation.displayName;
   const command = activity.workEntry.command?.trim();
   if (command) {
     const program = commandProgramName(command);
-    const status = activity.lifecycleStatus ?? (active ? "inProgress" : "completed");
     const verb =
       status === "inProgress"
         ? "Running"

apps/web/src/components/chat/MessagesTimeline.logic.test.ts+13-10

 @@ -99,13 +99,16 @@ describe("work entry labels", () => {
     );
   });
-  it("does not describe a finished call as still running while the turn continues", () => {
+  it("keeps the latest live activity in the present tense after the call completes", () => {
     const browserEntry = {
       ...entry,
       toolTitle: "T3-code.preview_click",
       toolLifecycleStatus: "completed" as const,
     };
     expect(liveWorkEntryLabel(browserEntry, undefined, true)).toBe(
+      "Clicking in the preview browser",
+    );
+    expect(liveWorkEntryLabel(browserEntry, undefined, false)).toBe(
       "Clicked in the preview browser",
     );
   });
 @@ -134,21 +137,21 @@ describe("work entry labels", () => {
   });
   it.each([
-    ["inProgress", "Running vp"],
+    ["inProgress", "Running vp", "Running vp"],
-    ["completed", "Ran vp"],
+    ["completed", "Running vp", "Ran vp"],
-    ["failed", "Failed vp"],
+    ["failed", "Failed vp", "Failed vp"],
-    ["declined", "Declined vp"],
+    ["declined", "Declined vp", "Declined vp"],
-    ["stopped", "Stopped vp"],
+    ["stopped", "Stopped vp", "Stopped vp"],
   ] as const)(
-    "uses the command's %s outcome even while the turn continues",
+    "uses present tense for a live %s command and the outcome once it is no longer live",
-    (toolLifecycleStatus, label) => {
+    (toolLifecycleStatus, liveLabel, settledLabel) => {
       const commandEntry = {
         ...entry,
         command: "/bin/bash -lc 'vp test run'",
         toolLifecycleStatus,
       };
-      expect(liveWorkEntryLabel(commandEntry, undefined, true)).toBe(label);
+      expect(liveWorkEntryLabel(commandEntry, undefined, true)).toBe(liveLabel);
-      expect(liveWorkEntryLabel(commandEntry, undefined, false)).toBe(label);
+      expect(liveWorkEntryLabel(commandEntry, undefined, false)).toBe(settledLabel);
     },
   );

apps/web/src/components/chat/MessagesTimeline.logic.ts+6-5

 @@ -2,6 +2,7 @@ import * as Equal from "effect/Equal";
 import { renderCodexDirectivesForCopy } from "@t3tools/client-runtime/codex-markdown-directives";
 import { commandProgramName } from "@t3tools/client-runtime/work-log/command-label";
 import {
+  liveActivityToolStatus,
   normalizeCompactToolLabel,
   omitSupersededLifecycleMarkers,
   resolveWorkEntryToolPresentation,
 @@ -65,14 +66,14 @@ export function liveWorkEntryLabel(
   workspaceRoot: string | undefined,
   active: boolean,
 ) {
-  const toolPresentation = resolveWorkEntryToolPresentation(
+  const status = liveActivityToolStatus(entry.toolLifecycleStatus, active);
-    entry,
+  const toolPresentation = resolveWorkEntryToolPresentation({
-    active ? "inProgress" : "completed",
+    ...entry,
-  );
+    toolLifecycleStatus: status,
+  });
   if (toolPresentation) return toolPresentation.displayName;
   const command = entry.command?.trim();
   if (command) {
-    const status = entry.toolLifecycleStatus ?? (active ? "inProgress" : "completed");
     const verb =
       status === "inProgress"
         ? "Running"

apps/web/src/components/chat/MessagesTimeline.test.tsx+3-3

...	@@ -1224,7 +1224,7 @@ describe("MessagesTimeline", () => {	...	@@ -1224,7 +1224,7 @@ describe("MessagesTimeline", () => {
1224	expect(markup).toContain('data-timeline-row-id="live-activity-row"');	1224	expect(markup).toContain('data-timeline-row-id="live-activity-row"');
1225	});	1225	});
1226		1226
1227	it("keeps the completed command in the shared activity row with a past-tense label", () => {	1227	it("keeps the completed command in the shared activity row with a present-tense label", () => {
1228	const turnId = TurnId.make("turn-live");	1228	const turnId = TurnId.make("turn-live");
1229	const markup = renderToStaticMarkup(	1229	const markup = renderToStaticMarkup(
1230	<MessagesTimeline	1230	<MessagesTimeline
...	@@ -1259,10 +1259,10 @@ describe("MessagesTimeline", () => {	...	@@ -1259,10 +1259,10 @@ describe("MessagesTimeline", () => {
1259	/>,	1259	/>,
1260	);	1260	);
1261		1261
1262	expect(markup).toContain("Ran pnpm");	1262	expect(markup).toContain("Running pnpm");
1263	expect(markup).toContain("lucide-terminal");	1263	expect(markup).toContain("lucide-terminal");
1264	expect(markup).toContain("live-activity-focus");	1264	expect(markup).toContain("live-activity-focus");
1265	expect(markup).not.toContain("Running pnpm");	1265	expect(markup).not.toContain("Ran pnpm");
1266	expect(markup).not.toContain("Thinking");	1266	expect(markup).not.toContain("Thinking");
1267	expect(markup).not.toContain('data-timeline-row-kind="thinking"');	1267	expect(markup).not.toContain('data-timeline-row-kind="thinking"');
1268	});	1268	});

docs/user/tool-activity.md+4-1

...	@@ -8,7 +8,10 @@ indicate more calls above or below. Short groups use only the space they need.	...	@@ -8,7 +8,10 @@ indicate more calls above or below. Short groups use only the space they need.
8	Collapsing and reopening a group preserves your reading position and any open call details.	8	Collapsing and reopening a group preserves your reading position and any open call details.
9		9
10	Recognized T3 tools use descriptive labels in both the running summary and individual rows.	10	Recognized T3 tools use descriptive labels in both the running summary and individual rows.
11	Labels follow the call's state, such as "Clicking" while running and "Clicked" after success.	11	The latest live activity stays in the present tense while the turn continues, such as
		12	"Running vp" or "Clicking in the preview browser", even after that call has completed.
		13	Expanded rows follow the call's own state, such as "Clicked" after success.
		14	When a call has not reported a state yet, the label stays in the present tense.
12	Failed, declined, and stopped calls say what happened without implying success.	15	Failed, declined, and stopped calls say what happened without implying success.
13	Preview browser actions use a globe icon. Other T3 tools keep the T3 mark.	16	Preview browser actions use a globe icon. Other T3 tools keep the T3 mark.
14	Group summaries count browser actions separately, such as "Used browser 18 times" or	17	Group summaries count browser actions separately, such as "Used browser 18 times" or

packages/client-runtime/src/work-log/presentation.test.ts+4-4

packages/client-runtime/src/work-log/presentation.ts+8-1

 @@ -113,7 +113,7 @@ function resolveT3McpToolPresentation(value: string | undefined, status: string
             ? `Declined to ${action.toLowerCase()}`
             : status === "stopped"
               ? `Stopped ${running.toLowerCase()}`
-              : action;
+              : running;
   return {
     displayName: `${verb} ${detail}`,
 @@ -121,6 +121,13 @@ function resolveT3McpToolPresentation(value: string | undefined, status: string
   };
 }
+/** Latest live activity stays present-tense unless the call itself failed, declined, or stopped. */
+export function liveActivityToolStatus(status: string | undefined, presentTense: boolean) {
+  if (status === "failed" || status === "declined" || status === "stopped") return status;
+  if (presentTense || status === "inProgress") return "inProgress";
+  return "completed";
+}
 /** Resolves tool identity before choosing labels or icons in either client. */
 export function resolveWorkEntryToolPresentation(
   entry: Pick<WorkLogPresentationEntry, "label" | "toolTitle" | "toolData" | "toolLifecycleStatus">,

...	@@ -25,7 +25,7 @@ describe("resolveWorkEntryToolPresentation", () => {	...	@@ -25,7 +25,7 @@ describe("resolveWorkEntryToolPresentation", () => {
25	"preview_click",	25	"preview_click",
26	])("recognizes browser tool names across providers: %s", (label) => {	26	])("recognizes browser tool names across providers: %s", (label) => {
27	expect(resolveWorkEntryToolPresentation({ label })).toEqual({	27	expect(resolveWorkEntryToolPresentation({ label })).toEqual({
28	displayName: "Click in the preview browser",	28	displayName: "Clicking in the preview browser",
29	icon: "browser",	29	icon: "browser",
30	});	30	});
31	});	31	});
...	@@ -37,7 +37,7 @@ describe("resolveWorkEntryToolPresentation", () => {	...	@@ -37,7 +37,7 @@ describe("resolveWorkEntryToolPresentation", () => {
37	toolTitle: "Inspect the current page",	37	toolTitle: "Inspect the current page",
38	toolData: { server: "t3-code", tool: "preview_snapshot", result: { title: "Example" } },	38	toolData: { server: "t3-code", tool: "preview_snapshot", result: { title: "Example" } },
39	}),	39	}),
40	).toEqual({ displayName: "Take a snapshot of the preview page", icon: "browser" });	40	).toEqual({ displayName: "Taking a snapshot of the preview page", icon: "browser" });
41	});	41	});
42		42
43	it.each([	43	it.each([
...	@@ -46,7 +46,7 @@ describe("resolveWorkEntryToolPresentation", () => {	...	@@ -46,7 +46,7 @@ describe("resolveWorkEntryToolPresentation", () => {
46	["failed", "Failed to click in the preview browser"],	46	["failed", "Failed to click in the preview browser"],
47	["declined", "Declined to click in the preview browser"],	47	["declined", "Declined to click in the preview browser"],
48	["stopped", "Stopped clicking in the preview browser"],	48	["stopped", "Stopped clicking in the preview browser"],
49	["unknown", "Click in the preview browser"],	49	["unknown", "Clicking in the preview browser"],
50	])("describes the tool's own %s state", (toolLifecycleStatus, displayName) => {	50	])("describes the tool's own %s state", (toolLifecycleStatus, displayName) => {
51	expect(	51	expect(
52	resolveWorkEntryToolPresentation({	52	resolveWorkEntryToolPresentation({
...	@@ -115,7 +115,7 @@ describe("resolveWorkEntryToolPresentation", () => {	...	@@ -115,7 +115,7 @@ describe("resolveWorkEntryToolPresentation", () => {
115	label: "mcp__t3_code__task_status",	115	label: "mcp__t3_code__task_status",
116	toolTitle: "Check the child task",	116	toolTitle: "Check the child task",
117	}),	117	}),
118	).toEqual({ displayName: "Get delegated task status", icon: "t3-code" });	118	).toEqual({ displayName: "Getting delegated task status", icon: "t3-code" });
119	});	119	});
120		120
121	it("does not brand unknown tools or another server's matching tool name", () => {	121	it("does not brand unknown tools or another server's matching tool name", () => {